cla6-hidden - npm Package Compare versions

Comparing version 1.0.3 to 1.0.4

bower.json

 {
   "name": "cla6-hidden",
   "description": "Hidden plugin for Cla6.js",
-  "version": "1.0.3",
+  "version": "1.0.4",
   "main": "client/cla6-hidden.js",
@@ -6,0 +6,0 @@ "repository": {

client/cla6-hidden.js

@@ -35,3 +35,3 @@ (function e(t,n,r){function s(o,u){if(!n[o]){if(!t[o]){var a=typeof require=="function"&&require;if(!u&&a)return a(o,!0);if(i)return i(o,!0);var f=new Error("Cannot find module '"+o+"'");throw f.code="MODULE_NOT_FOUND",f}var l=n[o]={exports:{}};t[o][0].call(l.exports,function(e){var n=t[o][1][e];return s(n?n:e)},l,l.exports,e,t,n,r)}return n[o].exports}var i=typeof require=="function"&&require;for(var o=0;o<r.length;o++)s(r[o]);return s})({1:[function(require,module,exports){
 
-wrapDescriptor = function(descriptor) {
+var wrapDescriptor = function(descriptor) {
   ['value', 'get', 'set'].filter(function(k) {
@@ -45,3 +45,3 @@ return typeof descriptor[k] == 'function';
 
-wrapCtor = function(ctor) {
+var wrapCtor = function(ctor) {
   return function() {
@@ -67,7 +67,14 @@ if (!this.hasOwnProperty(hiddenField)) {
 
-wrapMethod = function(method) {
+var wrapMethod = function(method) {
   return function() {
+    var result;
+
     swapHidden(this);
-    var result = method.apply(this, arguments);
-    swapHidden(this);
+
+    try {
+      result = method.apply(this, arguments);
+    } finally {
+      swapHidden(this);
+    }
+
     return result;
@@ -77,3 +84,3 @@ };
 
-swapHidden = function(obj) {
+var swapHidden = function(obj) {
   var hidden = obj[hiddenField];
@@ -100,3 +107,3 @@ _.swap(hidden, obj);
 
-getAncestors = function(obj) {
+var getAncestors = function(obj) {
   var ancestor = Object.getPrototypeOf(obj).constructor;
@@ -103,0 +110,0 @@

client/cla6-hidden.min.js

@@ -1,1 +0,1 @@
-(function e(t,n,r){function s(o,u){if(!n[o]){if(!t[o]){var a=typeof require=="function"&&require;if(!u&&a)return a(o,!0);if(i)return i(o,!0);var f=new Error("Cannot find module '"+o+"'");throw f.code="MODULE_NOT_FOUND",f}var l=n[o]={exports:{}};t[o][0].call(l.exports,function(e){var n=t[o][1][e];return s(n?n:e)},l,l.exports,e,t,n,r)}return n[o].exports}var i=typeof require=="function"&&require;for(var o=0;o<r.length;o++)s(r[o]);return s})({1:[function(require,module,exports){var Cla6Hidden=require("..");Cla6.use(Cla6Hidden)},{"..":2}],2:[function(require,module,exports){var _=require("./utils");var hiddenField=_.createArr(10).reduce(function(result){return result+_.randomDigit()},"__cla6Hidden__");function Hidden(descriptors){var _descriptors={};descriptors[hiddenField]={value:_descriptors};Object.keys(descriptors).filter(function(k){if(k[0]=="_"&&k!=hiddenField){_.move(descriptors,_descriptors,k);_descriptors[k].enumerable=true}else{return true}}).forEach(function(k){if(k=="constructor")descriptors.constructor.value=wrapCtor(descriptors.constructor.value);else wrapDescriptor(descriptors[k])})}wrapDescriptor=function(descriptor){["value","get","set"].filter(function(k){return typeof descriptor[k]=="function"}).forEach(function(k){descriptor[k]=wrapMethod(descriptor[k])})};wrapCtor=function(ctor){return function(){if(!this.hasOwnProperty(hiddenField)){var ancestors=_.getAncestors(this);var _descriptors=ancestors.map(function(ancestor){return ancestor.prototype[hiddenField]}).reduce(function(result,hidden){_.copy(hidden,result);return result},{});var hidden=Object.defineProperties({},_descriptors);Object.defineProperty(this,hiddenField,{value:hidden})}return wrapMethod(ctor).apply(this,arguments)}};wrapMethod=function(method){return function(){swapHidden(this);var result=method.apply(this,arguments);swapHidden(this);return result}};swapHidden=function(obj){var hidden=obj[hiddenField];_.swap(hidden,obj);Object.keys(hidden).filter(function(k){return k[0]!="_"}).forEach(function(k){_.move(hidden,obj,k)})};module.exports=Hidden},{"./utils":3}],3:[function(require,module,exports){var createArr=function(length){return Array.apply(null,{length:length})};var randomDigit=function(){return parseInt(Math.random()*10)};getAncestors=function(obj){var ancestor=Object.getPrototypeOf(obj).constructor;if(ancestor===Object)return[];else return getAncestors(ancestor.prototype).concat(ancestor)};var swap=function(src,dst){var temp={};move(src,temp);move(dst,src);copy(temp,dst)};var move=function(src,dst,k){if(k==null){Object.keys(src).forEach(function(k){move(src,dst,k)})}else{copy(src,dst,k);delete src[k]}};var copy=function(src,dst,k){if(k==null){Object.keys(src).forEach(function(k){copy(src,dst,k)})}else{var descriptor=Object.getOwnPropertyDescriptor(src,k);Object.defineProperty(dst,k,descriptor)}};module.exports={createArr:createArr,randomDigit:randomDigit,getAncestors:getAncestors,swap:swap,move:move,copy:copy}},{}]},{},[1]);
+(function e(t,n,r){function s(o,u){if(!n[o]){if(!t[o]){var a=typeof require=="function"&&require;if(!u&&a)return a(o,!0);if(i)return i(o,!0);var f=new Error("Cannot find module '"+o+"'");throw f.code="MODULE_NOT_FOUND",f}var l=n[o]={exports:{}};t[o][0].call(l.exports,function(e){var n=t[o][1][e];return s(n?n:e)},l,l.exports,e,t,n,r)}return n[o].exports}var i=typeof require=="function"&&require;for(var o=0;o<r.length;o++)s(r[o]);return s})({1:[function(require,module,exports){var Cla6Hidden=require("..");Cla6.use(Cla6Hidden)},{"..":2}],2:[function(require,module,exports){var _=require("./utils");var hiddenField=_.createArr(10).reduce(function(result){return result+_.randomDigit()},"__cla6Hidden__");function Hidden(descriptors){var _descriptors={};descriptors[hiddenField]={value:_descriptors};Object.keys(descriptors).filter(function(k){if(k[0]=="_"&&k!=hiddenField){_.move(descriptors,_descriptors,k);_descriptors[k].enumerable=true}else{return true}}).forEach(function(k){if(k=="constructor")descriptors.constructor.value=wrapCtor(descriptors.constructor.value);else wrapDescriptor(descriptors[k])})}var wrapDescriptor=function(descriptor){["value","get","set"].filter(function(k){return typeof descriptor[k]=="function"}).forEach(function(k){descriptor[k]=wrapMethod(descriptor[k])})};var wrapCtor=function(ctor){return function(){if(!this.hasOwnProperty(hiddenField)){var ancestors=_.getAncestors(this);var _descriptors=ancestors.map(function(ancestor){return ancestor.prototype[hiddenField]}).reduce(function(result,hidden){_.copy(hidden,result);return result},{});var hidden=Object.defineProperties({},_descriptors);Object.defineProperty(this,hiddenField,{value:hidden})}return wrapMethod(ctor).apply(this,arguments)}};var wrapMethod=function(method){return function(){var result;swapHidden(this);try{result=method.apply(this,arguments)}finally{swapHidden(this)}return result}};var swapHidden=function(obj){var hidden=obj[hiddenField];_.swap(hidden,obj);Object.keys(hidden).filter(function(k){return k[0]!="_"}).forEach(function(k){_.move(hidden,obj,k)})};module.exports=Hidden},{"./utils":3}],3:[function(require,module,exports){var createArr=function(length){return Array.apply(null,{length:length})};var randomDigit=function(){return parseInt(Math.random()*10)};var getAncestors=function(obj){var ancestor=Object.getPrototypeOf(obj).constructor;if(ancestor===Object)return[];else return getAncestors(ancestor.prototype).concat(ancestor)};var swap=function(src,dst){var temp={};move(src,temp);move(dst,src);copy(temp,dst)};var move=function(src,dst,k){if(k==null){Object.keys(src).forEach(function(k){move(src,dst,k)})}else{copy(src,dst,k);delete src[k]}};var copy=function(src,dst,k){if(k==null){Object.keys(src).forEach(function(k){copy(src,dst,k)})}else{var descriptor=Object.getOwnPropertyDescriptor(src,k);Object.defineProperty(dst,k,descriptor)}};module.exports={createArr:createArr,randomDigit:randomDigit,getAncestors:getAncestors,swap:swap,move:move,copy:copy}},{}]},{},[1]);

lib/hidden.js

@@ -30,3 +30,3 @@ var _ = require('./utils');
 
-wrapDescriptor = function(descriptor) {
+var wrapDescriptor = function(descriptor) {
   ['value', 'get', 'set'].filter(function(k) {
@@ -40,3 +40,3 @@ return typeof descriptor[k] == 'function';
 
-wrapCtor = function(ctor) {
+var wrapCtor = function(ctor) {
   return function() {
@@ -62,7 +62,14 @@ if (!this.hasOwnProperty(hiddenField)) {
 
-wrapMethod = function(method) {
+var wrapMethod = function(method) {
   return function() {
+    var result;
+
     swapHidden(this);
-    var result = method.apply(this, arguments);
-    swapHidden(this);
+
+    try {
+      result = method.apply(this, arguments);
+    } finally {
+      swapHidden(this);
+    }
+
     return result;
@@ -72,3 +79,3 @@ };
 
-swapHidden = function(obj) {
+var swapHidden = function(obj) {
   var hidden = obj[hiddenField];
@@ -75,0 +82,0 @@ _.swap(hidden, obj);

lib/utils.js

@@ -9,3 +9,3 @@ var createArr = function(length) {
 
-getAncestors = function(obj) {
+var getAncestors = function(obj) {
   var ancestor = Object.getPrototypeOf(obj).constructor;
@@ -12,0 +12,0 @@

package.json

 {
   "name": "cla6-hidden",
   "description": "Hidden plugin for Cla6.js",
-  "version": "1.0.3",
+  "version": "1.0.4",
   "main": "lib/hidden.js",
@@ -6,0 +6,0 @@ "repository": {

test/hidden.js

@@ -102,2 +102,26 @@ var Chai = require('chai');
   });
+
+  it('should swap hidden properties back if an error was thrown', function() {
+    var Klass = Cla6('Klass', {
+      constructor: function() {
+        this._internal = 'internal';
+        this.revealed = 'revealed';
+      },
+
+      assert: function() {
+        throw Error();
+      }
+    });
+
+    var obj = new Klass();
+    obj._external = 'external';
+    
+    try {
+      obj.assert();
+    } catch (e) {
+      expect(obj.revealed).to.equal('revealed');
+      expect(obj._external).to.equal('external');
+      expect(obj._internal).to.be.not.exist;
+    }
+  });
 });

Fixed alerts

Deprecated

Maintenance

The maintainer of the package marked it as deprecated. This could indicate that a single version should not be used, or that the package is no longer maintained and any new vulnerabilities will not be fixed.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

15787

increased by4.94%

Lines of code

380

increased by7.95%

Number of medium maintenance alerts

0

decreased by-100%

No dependency changes