classnames - npm Package Compare versions

Comparing version 1.1.0 to 1.1.1

index.js

 function classNames() {
-	var args = arguments, classes = [];
+	var args = arguments;
+	var classes = [];
+
 	for (var i = 0; i < args.length; i++) {
@@ -12,5 +14,8 @@ var arg = args[i];
 		} else if ('object' === typeof arg) {
-			classes = classes.concat(Object.keys(arg).filter(function(cls) {
-				return arg[cls];
-			}));
+			for (var key in arg) {
+				if (!arg.hasOwnProperty(key) || !arg[key]) {
+					continue;
+				}
+				classes.push(key);
+			}
 		}
@@ -17,0 +22,0 @@ }

package.json

 {
   "name": "classnames",
-  "version": "1.1.0",
+  "version": "1.1.1",
   "description": "A simple utility for conditionally joining classNames together",
@@ -5,0 +5,0 @@ "main": "index.js",

tests.js

@@ -16,4 +16,4 @@ var assert = require("assert");
 
-  it('joins arrays of class names and ignore falsy values', function() {
-    assert.equal(classNames('a', 0, null, undefined, 'b'), 'a b');
+  it('joins arrays of class names and ignore non-string values', function() {
+    assert.equal(classNames('a', 0, null, undefined, true, 1, 'b'), 'a b');
   });
@@ -20,0 +20,0 @@

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

4455

increased by1.07%

Lines of code

45

increased by9.76%

No dependency changes