codecov - npm Package Compare versions

Comparing version 3.7.0 to 3.7.1

lib/codecov.js

@@ -7,2 +7,3 @@ var fs = require('fs')
 var walk = require('ignore-walk')
+var execFileSync = require('child_process').execFileSync
 var execSync = require('child_process').execSync
@@ -14,4 +15,5 @@
 
-var patterns,
-  more_patterns = ''
+var patterns = ''
+var more_patterns = ''
+var winPatterns = ''
 
@@ -22,4 +24,4 @@ var isWindows =
 if (!isWindows) {
-  patterns =
-    "-type f \\( -name '*coverage.*' " +
+  patterns = (
+    "-type f -name '*coverage.*' " +
     "-or -name 'nosetests.xml' " +
@@ -35,3 +37,3 @@ "-or -name 'jacoco*.xml' " +
     "-or -name '*.gcov' " +
-    "-or -name '*.lst' \\) " +
+    "-or -name '*.lst' " +
     "-not -name '*.sh' " +
@@ -83,5 +85,6 @@ "-not -name '*.data' " +
     "-not -path '*/conftest_*.c.gcov'"
+  ).split(' ')
 } else {
-  patterns =
-    '/a-d /b /s *coverage.* ' +
+  winPatterns = (
+    '/a:-d /b /s *coverage.* ' +
     '/s nosetests.xml ' +
@@ -144,2 +147,3 @@ '/s jacoco*.xml ' +
     '| findstr /i /v \\conftest_.*\\.c\\.gcov '
+  ).split(' ')
 }
@@ -364,3 +368,3 @@
     upload +=
-      execSync('git ls-files || hg locate', { cwd: root })
+      execFileSync('git', ['ls-files', '||', 'hg', 'locate'], { cwd: root })
         .toString()
@@ -424,3 +428,3 @@ .trim() + '\n<<<<<< network\n'
       console.log('    $ ' + gcov)
-      execSync(gcov)
+      execFileSync(gcov)
     } catch (e) {
@@ -442,5 +446,3 @@ console.log('    Failed to run gcov command.')
   } else {
-    bowerrc = execSync('if exist .bowerrc type .bowerrc', { cwd: root })
-      .toString()
-      .trim()
+    bowerrc = fs.existsSync('.bowerrc')
   }
@@ -451,7 +453,13 @@ if (bowerrc) {
       if (!isWindows) {
-        more_patterns =
-          " -not -path '*/" + bowerrc.toString().replace(/\/$/, '') + "/*'"
+        more_patterns = (
+          " -not -path '*/" +
+          bowerrc.toString().replace(/\/$/, '') +
+          "/*'"
+        ).split(' ')
       } else {
-        more_patterns =
-          '| findstr /i /v \\' + bowerrc.toString().replace(/\/$/, '') + '\\'
+        more_patterns = (
+          '| findstr /i /v \\' +
+          bowerrc.toString().replace(/\/$/, '') +
+          '\\'
+        ).split(' ')
       }
@@ -487,4 +495,11 @@ }
     var _files
+    var _findArgs
     if (!isWindows) {
-      _files = execSync('find ' + root + ' ' + patterns + more_patterns)
+      // @TODO support for a root directory
+      // It's not straightforward due to the nature of the find command
+      _findArgs = [root].concat(patterns)
+      if (more_patterns) {
+        _findArgs.concat(more_patterns)
+      }
+      _files = execFileSync('find', _findArgs)
         .toString()
@@ -496,3 +511,7 @@ .trim()
       // It's not straightforward due to the nature of the dir command
-      _files = execSync('dir ' + patterns + more_patterns)
+      _findArgs = [root].concat(winPatterns)
+      if (more_patterns) {
+        _findArgs.concat(more_patterns)
+      }
+      _files = execSync('dir ' + winPatterns.join(' ') + more_patterns)
         .toString()
@@ -499,0 +518,0 @@ .trim()

package.json

 {
   "name": "codecov",
-  "version": "3.7.0",
+  "version": "3.7.1",
   "description": "Uploading report to Codecov: https://codecov.io",
@@ -5,0 +5,0 @@ "main": "index.js",

README.md

@@ -78,5 +78,5 @@ # Codecov NodeJS Uploader
 [depstat-url]: https://david-dm.org/codecov/codecov-node
-[depstat-image]: https://img.shields.io/david/codecov/codecov-node/master.svg
-[devdepstat-url]: https://david-dm.org/codecov/codecov-node#info=devDependencies
-[devdepstat-image]: https://img.shields.io/david/dev/codecov/codecov-node/master.svg
+[depstat-image]: https://david-dm.org/codecov/codecov-node/status.svg
+[devdepstat-url]: https://david-dm.org/codecov/codecov-node?type=dev
+[devdepstat-image]: https://david-dm.org/codecov/codecov-node/dev-status.svg
 
@@ -91,2 +91,7 @@ **With NYC**
 
+## Troubleshooting
+
+If you're seeing an **HTTP 400 error when uploading reports to S3**, make sure you've updated to at least version 3.7.0. 
+
+
 ## Change Log
@@ -116,1 +121,3 @@
 - v3.7.0 Remove the X-Amz-Acl: public-read header
+
+.

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Telemetry

Supply chain risk

This package contains telemetry which tracks how it is used.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

80991

increased by5.88%

Number of package files

70

increased by12.9%

Lines of code

2034

increased by0.94%

Number of lines in readme file

121

increased by6.14%

Number of high supply chain risk alerts

0

decreased by-100%

Worsened metrics

Number of medium supply chain risk alerts

6

increased by20%

No dependency changes