comlink - npm Package Compare versions

Comparing version 0.1.2 to 0.1.3

client.js

@@ -17,3 +17,3 @@ var cuid = require('cuid');
     socket.emit('comlink_hello', {session_id: my_id}, function(err, session_id){
-      if(my_id !== session_id){
+      if(my_id !== session_id){//looks like we've been assigned a new session_id
         my_id = session_id;
@@ -20,0 +20,0 @@ if(has_localstorage){

package.json

 {
   "name": "comlink",
-  "version": "0.1.2",
+  "version": "0.1.3",
   "description": "Sessions and RPC for socket.io",
@@ -24,4 +24,5 @@ "main": "server.js",
     "deep-freeze": "0.0.1",
-    "has-localstorage": "1.0.1"
+    "has-localstorage": "1.0.1",
+    "is-cuid": "1.0.0"
   }
 }

server.js

@@ -0,1 +1,3 @@
+var cuid = require('cuid');
+var isCuid = require('is-cuid');
 var deepFreeze = require('deep-freeze');
@@ -31,6 +33,10 @@
         fn = function(_, params, callback){
-          loadDataForSessionID(params.session_id, function(err, data){
-            client.session_id = params.session_id;
+          var session_id = params.session_id;
+          if(!isCuid(session_id)){
+            session_id = cuid();//doesn't look like they have valid cuid, so assign them one
+          }
+          loadDataForSessionID(session_id, function(err, data){
+            client.session_id = session_id;
             client.setState(data);
-            callback(err, client.session_id);
+            callback(err, session_id);
           });
@@ -37,0 +43,0 @@ };

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

4964

increased by6.41%

Lines of code

113

increased by5.61%

Worsened metrics

Dependency count

4

increased by33.33%

Dependency changes

• + Addedis-cuid@1.0.0

• + Addedis-cuid@1.0.0(transitive)

• + Addedx-is-string@0.1.0(transitive)