compatfactory - npm Package Compare versions

Comparing version 0.0.6 to 0.0.7

CHANGELOG.md

@@ -0,1 +1,7 @@
+## [0.0.7](https://github.com/wessberg/compatfactory/compare/v0.0.6...v0.0.7) (2021-05-29)
+
+### Bug Fixes
+
+- use provided modifiers when creating/updating MethodSignatures ([cfac75f](https://github.com/wessberg/compatfactory/commit/cfac75fcd593384d5d3b1c1a4066f5f769f50eaf))
+
 ## [0.0.6](https://github.com/wessberg/compatfactory/compare/v0.0.5...v0.0.6) (2021-05-29)
@@ -2,0 +8,0 @@

dist/cjs/index.js

@@ -506,6 +506,19 @@ "use strict";
         createMethodSignature(modifiers, name, questionToken, typeParameters, parameters, type) {
-            return typescript.createMethodSignature(typeParameters, parameters, type, name, questionToken);
+            const methodSignature = typescript.createMethodSignature(typeParameters, parameters, type, name, questionToken);
+            // Also set the modifiers
+            // Workaround for: https://github.com/microsoft/TypeScript/issues/35959
+            if (modifiers != null) {
+                methodSignature.modifiers = typescript.createNodeArray(modifiers);
+            }
+            return methodSignature;
+            return methodSignature;
         },
         updateMethodSignature(node, modifiers, name, questionToken, typeParameters, parameters, type) {
-            return typescript.updateMethodSignature(node, typeParameters, parameters, type, name, questionToken);
+            const methodSignature = typescript.updateMethodSignature(node, typeParameters, parameters, type, name, questionToken);
+            // Also set the modifiers
+            // Workaround for: https://github.com/microsoft/TypeScript/issues/35959
+            if (modifiers !== methodSignature.modifiers) {
+                methodSignature.modifiers = modifiers == null ? modifiers : typescript.createNodeArray(modifiers);
+            }
+            return methodSignature;
         },
@@ -980,2 +993,8 @@ updatePropertySignature(node, modifiers, name, questionToken, type) {
         },
+        updateVariableDeclaration(node, name, exclamationToken, type, initializer) {
+            if (typescript.updateVariableDeclaration.length === 4) {
+                return typescript.updateVariableDeclaration(node, name, type, initializer);
+            }
+            return typescript.updateVariableDeclaration(node, name, exclamationToken, type, initializer);
+        },
         createImportEqualsDeclaration(decorators, modifiers, isTypeOnly, name, moduleReference) {
@@ -982,0 +1001,0 @@ // For TypeScript < 4.0

dist/esm/index.js

@@ -502,6 +502,19 @@ export function ensureNodeFactory(factoryLike) {
         createMethodSignature(modifiers, name, questionToken, typeParameters, parameters, type) {
-            return typescript.createMethodSignature(typeParameters, parameters, type, name, questionToken);
+            const methodSignature = typescript.createMethodSignature(typeParameters, parameters, type, name, questionToken);
+            // Also set the modifiers
+            // Workaround for: https://github.com/microsoft/TypeScript/issues/35959
+            if (modifiers != null) {
+                methodSignature.modifiers = typescript.createNodeArray(modifiers);
+            }
+            return methodSignature;
+            return methodSignature;
         },
         updateMethodSignature(node, modifiers, name, questionToken, typeParameters, parameters, type) {
-            return typescript.updateMethodSignature(node, typeParameters, parameters, type, name, questionToken);
+            const methodSignature = typescript.updateMethodSignature(node, typeParameters, parameters, type, name, questionToken);
+            // Also set the modifiers
+            // Workaround for: https://github.com/microsoft/TypeScript/issues/35959
+            if (modifiers !== methodSignature.modifiers) {
+                methodSignature.modifiers = modifiers == null ? modifiers : typescript.createNodeArray(modifiers);
+            }
+            return methodSignature;
         },
@@ -976,2 +989,8 @@ updatePropertySignature(node, modifiers, name, questionToken, type) {
         },
+        updateVariableDeclaration(node, name, exclamationToken, type, initializer) {
+            if (typescript.updateVariableDeclaration.length === 4) {
+                return typescript.updateVariableDeclaration(node, name, type, initializer);
+            }
+            return typescript.updateVariableDeclaration(node, name, exclamationToken, type, initializer);
+        },
         createImportEqualsDeclaration(decorators, modifiers, isTypeOnly, name, moduleReference) {
@@ -978,0 +997,0 @@ // For TypeScript < 4.0

package.json

 {
 	"name": "compatfactory",
-	"version": "0.0.6",
+	"version": "0.0.7",
 	"description": "A library that unifies the TypeScript Compiler API factory functions across all versions of TypeScript and makes them conform with the Node Factory API",
@@ -5,0 +5,0 @@ "scripts": {

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

202216

increased by1.94%

Lines of code

2036

increased by1.9%

No dependency changes