conventional-recommended-bump - npm Package Compare versions

Comparing version 0.1.1 to 0.1.2

CHANGELOG.md

@@ -0,1 +1,11 @@
+<a name="0.1.2"></a>
+## [0.1.2](https://github.com/stevemao/conventional-recommended-bump/compare/v0.1.1...v0.1.2) (2016-03-10)
+
+
+### Bug Fixes
+
+* **angular:** handle breaking changes after a feature ([6c40400](https://github.com/stevemao/conventional-recommended-bump/commit/6c40400)), closes [#8](https://github.com/stevemao/conventional-recommended-bump/issues/8)
+
+
+
 <a name="0.1.1"></a>
@@ -2,0 +12,0 @@ ## [0.1.1](https://github.com/stevemao/conventional-recommended-bump/compare/v0.1.0...v0.1.1) (2016-02-23)

package.json

 {
   "name": "conventional-recommended-bump",
-  "version": "0.1.1",
+  "version": "0.1.2",
   "description": "Get a recommended version bump based on conventional commits",
@@ -5,0 +5,0 @@ "homepage": "https://github.com/stevemao/conventional-recommended-bump",

presets/angular.js

@@ -11,3 +11,2 @@ var presetOpts = {
         level = 1;
-        return true;
       }
@@ -14,0 +13,0 @@ });

README.md

@@ -21,8 +21,6 @@ #  [![NPM version][npm-image]][npm-url] [![Build Status][travis-image]][travis-url] [![Dependency Status][daviddm-image]][daviddm-url] [![Coverage Status][coverall-image]][coverall-url]
 conventionalRecommendedBump({
-  conventionalRecommendedBump({
-    preset: 'angular'
-  }, function(err, releaseAs) {
-    console.log(releaseAs);
-    //=> 'major'
-  });
+  preset: 'angular'
+}, function(err, releaseAs) {
+  console.log(releaseAs);
+  //=> 'major'
 });
@@ -29,0 +27,0 @@ ```

test/angular.js

@@ -18,7 +18,7 @@ 'use strict';
       writeFileSync('test1', '');
-      shell.exec('git add --all && git commit -m"chore: first commit"');
+      shell.exec('git add --all && git commit -m "chore: first commit"');
       writeFileSync('test2', '');
-      shell.exec('git add --all && git commit -m"feat($compile): new feature"');
+      shell.exec('git add --all && git commit -m "feat($compile): new feature"');
       writeFileSync('test3', '');
-      shell.exec('git add --all && git commit -m"perf(ngOptions): make it faster"');
+      shell.exec('git add --all && git commit -m "perf(ngOptions): make it faster"');
     });
@@ -49,3 +49,3 @@
       // fix this until https://github.com/arturadib/shelljs/issues/175 is solved
-      child.exec('git add --all && git commit -m"feat(): amazing new module\n\nBREAKING CHANGE: Not backward compatible."', function() {
+      child.exec('git add --all && git commit -m "feat(): amazing new module" -m "BREAKING CHANGE: Not backward compatible."', function() {
         conventionalRecommendedBump(opts, function(err, releaseAs) {
@@ -58,7 +58,18 @@ equal(releaseAs, 'major');
 
+    it('should release as major even after a feature', function(done) {
+      writeFileSync('test5', '');
+      // fix this until https://github.com/arturadib/shelljs/issues/175 is solved
+      child.exec('git add --all && git commit -m "feat(): another amazing new module" -m "Super backward compatible."', function() {
+        conventionalRecommendedBump(opts, function(err, releaseAs) {
+          equal(releaseAs, 'major');
+          done();
+        });
+      });
+    });
+
     it('should ignore a reverted commit', function(done) {
-      writeFileSync('test5', '');
-      child.exec('git rev-parse HEAD', function(err, hash) {
+      writeFileSync('test6', '');
+      child.exec('git rev-parse HEAD~1', function(err, hash) {
         // fix this until https://github.com/arturadib/shelljs/issues/175 is solved
-        child.exec('git add --all && git commit -m"revert: feat(): amazing new module\n\nThis reverts commit ' + hash.trim() + '."', function() {
+        child.exec('git add --all && git commit -m "revert: feat(): amazing new module" -m "This reverts commit ' + hash.trim() + '."', function() {
           conventionalRecommendedBump(opts, function(err, releaseAs) {
@@ -65,0 +76,0 @@ equal(releaseAs, 'minor');

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

16157

increased by5.14%

Lines of code

280

increased by3.32%

Worsened metrics

Number of lines in readme file

124

decreased by-1.59%

No dependency changes