cordova-plugin-facebook4 - npm Package Compare versions

Comparing version 1.7.4 to 1.8.0

CONTRIBUTING.md

@@ -13,3 +13,3 @@ # Contributing to PhoneGap Facebook Plugin
 
-- Check the [Troubleshooting Guide](TROUBLESHOOTING.md) for well known issues.
+- Check the [Troubleshooting Guide](./docs/TROUBLESHOOTING.md) for well known issues.
 - Search the [issues list](https://github.com/Wizcorp/phonegap-facebook-plugin/issues) for existing closed or still open issues
@@ -16,0 +16,0 @@ - Create a Github issue

docs/TROUBLESHOOTING.md

@@ -28,2 +28,3 @@ # Troubleshooting
 	- [Login Always Opens Web Dialog Even Though Native App is Installed](#login-always-opens-web-dialog-even-though-native-app-is-installed)
+    - [Login fails with devices running iOS 10+](#login-fails-with-devices-running-ios-10)
 
@@ -210,1 +211,8 @@ ## General
 	- Switch "deep linking" to ON in the Facebook developer website settings for your application
+
+### Login fails with devices running iOS 10
+- problem:
+    - even if login works properly with older iOS versions, on iOS 10+, error callback is always called
+- Solution:
+    - Give the iOS application access to the Keychain Sharing capability before building it as instructed in
+    [http://stackoverflow.com/questions/38689631/how-to-use-facebook-ios-sdk-on-ios-10](http://stackoverflow.com/questions/38689631/how-to-use-facebook-ios-sdk-on-ios-10).  

package.json

 {
   "name": "cordova-plugin-facebook4",
-  "version": "1.7.4",
+  "version": "1.8.0",
   "description": "Cordova Facebook SDK 4 Plugin",
@@ -5,0 +5,0 @@ "cordova": {

README.md

@@ -67,2 +67,10 @@ # cordova-plugin-facebook4
 
+### Check permissions (iOS only)
+
+`facebookConnectPlugin.checkHasCorrectPermissions(Array strings of permissions, Function success, Function failure)`
+
+Success function returns a success string if all passed permissions are granted.
+
+Failure function returns an error String if any passed permissions are not granted.
+
 ### Get Status
@@ -100,3 +108,4 @@
 		description: "Much description",
-		picture: 'http://example.com/image.png'
+		picture: 'http://example.com/image.png',
+		hashtag: '#myHashtag',
 		share_feedWeb: true, // iOS only
@@ -103,0 +112,0 @@ }

www/facebook-browser.js

@@ -78,9 +78,23 @@ /* globals */
 exports.logEvent = function logEvent (eventName, params, valueToSum, s, f) {
-  // AppEvents are not avaliable in JS.
-  s()
+  if (!__fbSdkReady) {
+    return __fbCallbacks.push(function() {
+      logEvent(eventName, params, valueToSum, s, f);
+    });
+  }
+
+  FB.AppEvents.logEvent(eventName, valueToSum, params);
+
+  if(s) s();
 }
 
 exports.logPurchase = function logPurchase (value, currency, s, f) {
-  // AppEvents are not avaliable in JS.
-  s()
+  if (!__fbSdkReady) {
+    return __fbCallbacks.push(function() {
+      logPurchase(value, currency, s, f);
+    });
+  }
+  
+  FB.AppEvents.logPurchase(value, currency);
+
+  if(s) s();
 }
@@ -90,3 +104,3 @@
   // App Invites are not avaliable in JS.
-  s()
+  if(s) s()
 }
@@ -93,0 +107,0 @@

www/facebook-native.js

@@ -15,2 +15,6 @@ var exec = require('cordova/exec')
 
+exports.checkHasCorrectPermissions = function checkHasCorrectPermissions (permissions, s, f) {
+  exec(s, f, 'FacebookConnectPlugin', 'checkHasCorrectPermissions', permissions)
+}
+
 exports.logEvent = function logEvent (name, params, valueToSum, s, f) {
@@ -58,1 +62,5 @@ // Prevent NSNulls getting into iOS, messes up our [command.argument count]
 }
+
+exports.getDeferredApplink = function (s, f) {
+	  exec(s, f, 'FacebookConnectPlugin', 'getDeferredApplink', [])
+}

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

48597386

increased by0.01%

Lines of code

579

increased by2.84%

Number of lines in readme file

348

increased by2.65%

No dependency changes