cpr-select - npm Package Compare versions

Comparing version 1.4.1 to 1.4.2

lib/select.js

@@ -55,8 +55,2 @@ 'use strict';
 
-		var selectedIndex = null;
-
-		if (this.props.selected) {
-			selectedIndex = this.getIndex(this.props.selected);
-		}
-
 		return {
@@ -102,6 +96,12 @@ dialogDisplayed: false,
 
-			this.setState({
-				dialogDisplayed: true,
-				selectedIndex: selectedIndex === undefined ? 0 : selectedIndex - 1
-			});
+			if (selectedIndex <= 0) {
+				this.setState({
+					dialogDisplayed: true
+				});
+			} else {
+				this.setState({
+					dialogDisplayed: true,
+					selectedIndex: selectedIndex === undefined ? 0 : selectedIndex - 1
+				});
+			}
 
@@ -108,0 +108,0 @@ //positionDialog(scope.collection[scope.selectedIndex]);

lib/select.spec.js

@@ -105,2 +105,33 @@ 'use strict';
 	});
+
+	it('Should not allow up arrow to go out of bounds', function (run) {
+		var items = [{
+			"value": "Alabama",
+			"key": "AL"
+		}, {
+			"value": "Alaska",
+			"key": "AK"
+		}, {
+			"value": "American Samoa",
+			"key": "AS"
+		}];
+
+		function callback(key, item, index) {
+			expect(key).toBe('AL');
+			expect(item.key).toBe('AL');
+			expect(index).toBe(0);
+			run();
+		}
+
+		var multiSelect = _reactLibReactTestUtils2['default'].renderIntoDocument(_react2['default'].createElement(_selectJs2['default'], { options: items, onChange: callback }));
+
+		var select = _reactLibReactTestUtils2['default'].findRenderedDOMComponentWithClass(multiSelect, 'cp-select');
+		_reactLibReactTestUtils2['default'].Simulate.click(select);
+		var input = _reactLibReactTestUtils2['default'].findRenderedDOMComponentWithClass(multiSelect, 'cp-select__hidden-input');
+		_reactLibReactTestUtils2['default'].Simulate.keyDown(input, { which: 38 });
+		_reactLibReactTestUtils2['default'].Simulate.keyDown(input, { which: 38 });
+		_reactLibReactTestUtils2['default'].Simulate.keyDown(input, { which: 38 });
+		_reactLibReactTestUtils2['default'].Simulate.keyDown(input, { which: 38 });
+		_reactLibReactTestUtils2['default'].Simulate.keyDown(input, { which: 13 });
+	});
 });

package.json

 {
   "name": "cpr-select",
-  "version": "1.4.1",
+  "version": "1.4.2",
   "description": "A consistently styled cross-browser and keyboard friendly select component",
@@ -5,0 +5,0 @@ "main": "lib/select.js",

src/select.js

@@ -23,8 +23,2 @@ import React from 'react';
 	getInitialState: function() {
-		let selectedIndex = null;
-
-		if (this.props.selected) {
-			selectedIndex = this.getIndex(this.props.selected);
-		}
-
 		return {
@@ -67,6 +61,12 @@ dialogDisplayed: false,
 
-			this.setState({
-				dialogDisplayed: true,
-				selectedIndex: selectedIndex === undefined ? 0 : selectedIndex - 1
-			});
+			if (selectedIndex <= 0) {
+				this.setState({
+					dialogDisplayed: true,
+				});
+			} else {
+				this.setState({
+					dialogDisplayed: true,
+					selectedIndex: selectedIndex === undefined ? 0 : selectedIndex - 1
+				});
+			}
 
@@ -73,0 +73,0 @@ //positionDialog(scope.collection[scope.selectedIndex]);

src/select.spec.js

@@ -110,2 +110,37 @@ import CanopySelect from './select.js';
 	});
+
+	it('Should not allow up arrow to go out of bounds', function(run) {
+		let items = [
+			{
+				"value": "Alabama",
+				"key": "AL"
+			}, {
+				"value": "Alaska",
+				"key": "AK"
+			}, {
+				"value": "American Samoa",
+				"key": "AS"
+			}
+		];
+
+		function callback(key, item, index) {
+			expect(key).toBe('AL');
+			expect(item.key).toBe('AL');
+			expect(index).toBe(0);
+			run();
+		}
+
+		let multiSelect = TestUtils.renderIntoDocument(
+			<CanopySelect options={items} onChange={callback}></CanopySelect>
+		);
+
+		let select = TestUtils.findRenderedDOMComponentWithClass(multiSelect, 'cp-select');
+		TestUtils.Simulate.click(select);
+		let input = TestUtils.findRenderedDOMComponentWithClass(multiSelect, 'cp-select__hidden-input');
+		TestUtils.Simulate.keyDown(input, {which: 38});
+		TestUtils.Simulate.keyDown(input, {which: 38});
+		TestUtils.Simulate.keyDown(input, {which: 38});
+		TestUtils.Simulate.keyDown(input, {which: 38});
+		TestUtils.Simulate.keyDown(input, {which: 13});
+	});
 });

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Major refactor

Supply chain risk

Package has recently undergone a major refactor. It may be unstable or indicate significant internal changes. Use caution when updating to versions that include significant changes.

Found 1 instance in 1 package

New author

Supply chain risk

A new npm collaborator published a version of the package for the first time. New collaborators are usually benign additions to a project, but do indicate a change to the security surface area of a package.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Install scripts

Supply chain risk

Install scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts.

Found 1 instance in 1 package

Shell access

Supply chain risk

This module accesses the system shell. Accessing the system shell increases the risk of executing arbitrary code.

Found 1 instance in 1 package

Environment variable access

Supply chain risk

Package accesses environment variables, which may be a sign of credential stuffing or data theft.

Found 1 instance in 1 package

Filesystem access

Supply chain risk

Accesses the file system, and could potentially read sensitive data.

Found 1 instance in 1 package

Improved metrics

Number of high supply chain risk alerts

0

decreased by-100%

Number of low supply chain risk alerts

0

decreased by-100%

Worsened metrics

Total package byte prevSize

29314

decreased by-88.52%

Number of package files

9

decreased by-86.76%

Lines of code

833

decreased by-83.24%

Number of medium supply chain risk alerts

2

increased by100%

No dependency changes