cumulocity-hellowidget-plugin - npm Package Compare versions

Comparing version 1.3.3 to 1.4.0

karma.conf.js

@@ -6,4 +6,3 @@ const _ = require('lodash');
   join,
-  dirname,
-  basename
+  dirname
 } = require('path');
@@ -64,3 +63,3 @@
     ngHtml2JsPreprocessor: {
-      cacheIdFromPath: filepath => join(computePluginPath(filepath), basename(filepath)),
+      cacheIdFromPath: filepath => filepath.replace(/^plugins\//i, ''),
       moduleName: 'c8yHtml.test'
@@ -67,0 +66,0 @@ },

package.json

 {
   "name": "cumulocity-hellowidget-plugin",
-  "version": "1.3.3",
+  "version": "1.4.0",
   "description": "A demo app for showcasing creation of a custom Cumulocity UI widget plugin",
@@ -36,3 +36,3 @@ "keywords": [
   "dependencies": {
-    "cumulocity-ui-build": "http://resources.cumulocity.com/webapps/ui/7.43.2.tar.gz"
+    "cumulocity-ui-build": "http://resources.cumulocity.com/webapps/ui/8.0.0.tar.gz"
   },
@@ -39,0 +39,0 @@ "devDependencies": {

plugins/hello-widget/text-input.component.spec.js

@@ -31,8 +31,5 @@ /**
   describe('configuring text', function () {
-    var $scope;
-    var element;
-
     beforeEach(function () {
+      //////////// stubbing dependencies
 
-      //////////// stubbing dependencies
     });
@@ -56,22 +53,25 @@
       // when
-      var template = '<c8y-hello-text-input hello-text="config.helloText"></c8y-hello-text-input>';
-      initComponent(template);
+      var template = '<c8y-hello-text-input hello-text="config.helloText" />';
 
+      var element = createComponent(template);
+
       if (_.isString(helloText)) {
         element.controller('c8yHelloTextInput').helloText = helloText;
-        $scope.$digest();
+        $rootScope.$apply();
       }
 
       // then
-      expect($scope.config.helloText)
+      expect(element.scope().config.helloText)
         .toEqual(expectedConfiguredText);
     }
 
-    function initComponent(template, bindings) {
-      $scope = _.assign($rootScope.$new(), bindings);
+    function createComponent(template, bindings) {
+      var $scope = _.assign($rootScope.$new(), bindings);
 
-      element = $compile(template)($scope);
-      $scope.$digest();
+      var element = $compile(template)($scope);
+      $scope.$apply();
+
+      return element;
     }
   });
 });

plugins/hello-widget/widget.component.spec.js

@@ -29,4 +29,4 @@ /**
     beforeEach(function () {
+      //////////// stubbing dependencies
 
-      //////////// stubbing dependencies
     });
@@ -33,0 +33,0 @@

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

HTTP dependency

Supply chain risk

Contains a dependency which resolves to a remote HTTP URL which could be used to inject untrusted code and reduce overall package reliability.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

HTTP dependency

Supply chain risk

Contains a dependency which resolves to a remote HTTP URL which could be used to inject untrusted code and reduce overall package reliability.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

4533683

increased by0.09%

Worsened metrics

Lines of code

426

decreased by-0.47%

Dependency changes

• Updatedcumulocity-ui-build@http://resources.cumulocity.com/webapps/ui/8.0.0.tar.gz