db-migrate-base - npm Package Compare versions

Comparing version 1.3.3 to 1.4.0

index.js

@@ -28,3 +28,3 @@ var util = require('util');
   close: function() {
-    throw new Error('not yet implemented');
+    throw new Error('not implemented');
   },
@@ -87,2 +87,6 @@
 
+  showDatabase: function () {
+    throw new Error('not implemented');
+  },
+
   switchDatabase: function() {
@@ -201,3 +205,3 @@ throw new Error('not implemented');
     var columnDefs = [];
-    var foreignKeys = [];
+    var callbacks = [];
     var extensions = '';
@@ -211,4 +215,10 @@ var tableOptions = '';
       columnDefs.push(constraint.constraints);
+
+      // check foreignKey for backward compatiable
       if (constraint.foreignKey)
-        foreignKeys.push(constraint.foreignKey);
+        callbacks.push(constraint.foreignKey);
+      if (constraint.callbacks) {
+        // support multiple callbacks
+        callbacks = callbacks.concat(constraint.callbacks)
+      }
     }
@@ -230,3 +240,3 @@
     {
-        return this.recurseCallbackArray(foreignKeys);
+        return this.recurseCallbackArray(callbacks);
     }.bind(this)).nodeify(callback);
@@ -257,3 +267,3 @@ },
   renameTable: function(tableName, newTableName, callback) {
-    throw new Error('not yet implemented');
+    throw new Error('not implemented');
   },
@@ -266,2 +276,3 @@
     var extensions = '';
+    var self = this;
 
@@ -278,6 +289,6 @@ if(typeof(this._applyAddColumnExtension) === 'function') {
     {
+      var callbacks = def.callbacks || [];
       if(def.foreignKey)
-        return def.foreignKey();
-      else
-        return Promise.resolve();
+        callbacks.push(def.foreignKey)
+      return self.recurseCallbackArray(callbacks);
     }).nodeify(callback);
@@ -287,11 +298,11 @@ },
   removeColumn: function(tableName, columnName, callback) {
-    throw new Error('not yet implemented');
+    throw new Error('not implemented');
   },
 
   renameColumn: function(tableName, oldColumnName, newColumnName, callback) {
-    throw new Error('not yet implemented');
+    throw new Error('not implemented');
   },
 
   changeColumn: function(tableName, columnName, columnSpec, callback) {
-    throw new Error('not yet implemented');
+    throw new Error('not implemented');
   },
@@ -298,0 +309,0 @@

package.json

 {
   "name": "db-migrate-base",
-  "version": "1.3.3",
+  "version": "1.4.0",
   "description": "db-migrate base driver",
@@ -5,0 +5,0 @@ "main": "index.js",

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

24303

increased by1.32%

Lines of code

623

increased by1.47%

No dependency changes