ddp - npm Package Compare versions

Comparing version 0.9.2 to 0.9.3

CHANGELOG.md

@@ -0,1 +1,5 @@
+0.9.3 - 2014-12-20
+
+  - Remove event listeners on close
+
 0.9.2 - 2014-11-17
@@ -2,0 +6,0 @@

lib/ddp-client.js

@@ -313,2 +313,4 @@ "use strict";
   self.socket.close();
+  self.removeAllListeners("connected");
+  self.removeAllListeners("failed");
 };
@@ -315,0 +317,0 @@

package.json

 {
   "name": "ddp",
-  "version": "0.9.2",
+  "version": "0.9.3",
   "description": "Node.js module to connect to servers using DDP protocol.",
@@ -5,0 +5,0 @@ "author": "Tom Coleman <[e-mail]> (http://tom.thesnail.org)",

test/ddp-client.js

@@ -14,2 +14,3 @@ var assert = require('assert'),
   wsMock = new events.EventEmitter();
+  wsMock.close = sinon.stub();
 
@@ -94,2 +95,17 @@ wsConstructor = sinon.stub();
   });
+
+  it('should clear event listeners on close', function(done) {
+    var ddpclient = new DDPClient();
+    var callback = sinon.stub();
+
+    ddpclient.connect(callback);
+    ddpclient.close();
+    ddpclient.connect(callback);
+
+    setTimeout(function() {
+      assert.equal(ddpclient.listeners('connected').length, 1);
+      assert.equal(ddpclient.listeners('failed').length, 1);
+      done();
+    }, 15);
+  })
 });
@@ -96,0 +112,0 @@

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

35264

increased by1.65%

Lines of code

643

increased by2.39%

No dependency changes