director - npm Package Compare versions

Comparing version 1.2.7 to 1.2.8

lib/director/http/index.js

@@ -143,3 +143,3 @@ var events = require('events'),
   if (this._attach) {
-    for (var i in this._attach) {
+    for (var i = 0; i < this._attach.length; i++) {
       this._attach[i].call(thisArg);
@@ -146,0 +146,0 @@ }

lib/director/router.js

@@ -197,3 +197,3 @@ /*
 
-  this.recurse   = options.recurse   || this.recurse || false;
+  this.recurse   = typeof options.recurse === 'undefined' ? this.recurse || false : options.recurse;
   this.async     = options.async     || false;
@@ -609,3 +609,3 @@ this.delimiter = options.delimiter || '\/';
         if (this.recurse) {
-          fns.push([routes[r].before, routes[r].on].filter(Boolean));
+          fns.push([routes[r].before, routes[r][method]].filter(Boolean));
           next.after = next.after.concat([routes[r].after].filter(Boolean));
@@ -612,0 +612,0 @@

package.json

@@ -5,3 +5,3 @@ {
   "author": "Charlie Robbins <[e-mail]>",
-  "version": "1.2.7",
+  "version": "1.2.8",
   "maintainers": [
@@ -31,3 +31,3 @@ "hij1nx <[e-mail]>",
     "uglify-js": "2.4.x",
-    "vows": "0.7.x"
+    "vows": "0.8.0"
   },
@@ -34,0 +34,0 @@ "ender": "./build/ender.js",

README.md

@@ -277,2 +277,3 @@ ![Logo](https://github.com/flatiron/director/raw/master/img/director.png)
 * [URL Parameters](#url-parameters)
+* [Wildcard routes](#wildcard-routes)
 * [Route Recursion](#route-recursion)
@@ -283,4 +284,4 @@ * [Async Routing](#async-routing)
 * [Instance Methods](#instance-methods)
-* [Attach Properties to `this`](#attach-to-this)
-* [HTTP Streaming and Body Parsing](#http-streaming-body-parsing)
+* [Attach Properties to `this`](#attach-properties-to-this)
+* [HTTP Streaming and Body Parsing](#http-streaming-and-body-parsing)
 
@@ -538,2 +539,11 @@ ## Constructor
 
+## Wildcard routes
+
+It is possible to define wildcard routes, so that /foo and /foo/a/b/c routes to
+the same handler, and gets passed `""` and `"a/b/c"` respectively.
+
+``` js
+  router.on("/foo/?((\w|.)*)"), function (path) { });
+```
+
 ## Route Recursion
@@ -540,0 +550,0 @@

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

197622

increased by1.42%

Number of package files

47

increased by4.44%

Lines of code

4545

increased by1.66%

Number of lines in readme file

963

increased by1.05%

No dependency changes