directory-encoder - npm Package Compare versions

Comparing version 0.7.2 to 0.8.0

lib/png-uri-encoder.js

@@ -7,2 +7,3 @@ /*global require:true*/
 	var path = require( 'path' );
+	var url = require('url');
 	var DataURIEncoder = require( './data-uri-encoder' );
@@ -27,5 +28,17 @@
 			var output_path = options.pngpath || options.pngfolder;
-			return path.join(output_path, path.basename(this.path))
-				.split( path.sep )
-				.join( "/" );
+			
+			var pattern_url = /^(http:|https:|\/\/).*/;
+			var file_url = null;
+			
+			// check if output_path is a hostname
+			if (pattern_url.test(output_path)) {
+				file_url = url.resolve(output_path, path.basename(this.path));
+			}
+			else {
+				file_url = path.join(output_path, path.basename(this.path))
+						.split( path.sep )
+						.join( "/" );
+			}
+			
+			return file_url;
 		}
@@ -32,0 +45,0 @@

package.json

 {
   "name": "directory-encoder",
   "description": "Encode a directory of images to CSS",
-  "version": "0.7.2",
+  "version": "0.8.0",
   "homepage": "https://github.com/filamentgroup/directory-encoder",
@@ -6,0 +6,0 @@ "author": {

test/data-uri-encoder_test.js

@@ -177,2 +177,38 @@ /*global require:true*/
 	};
+	exports['PngURIEncoder4'] = {
+        setUp: function( done ) {
+        	this.encoder = new PngURIEncoder( "test/files/cat.png" );
+            	done();
+        },
+        tearDown: function( done ){
+        	done();
+        },
+        noencode_url_pngpath_http: function( test ){
+        	var options = {
+			noencodepng: true,
+			pngpath: "http://myhost.com/images/"
+		};
+
+		test.equal( this.encoder.encode(options), 'http://myhost.com/images/cat.png' );
+		test.done();
+        },
+        noencode_url_pngpath_https: function( test ){
+		var options = {
+			noencodepng: true,
+			pngpath: "https://myhost.com/images/"
+		};
+
+		test.equal( this.encoder.encode(options), 'https://myhost.com/images/cat.png' );
+		test.done();
+        },
+        noencode_url_pngpath_schemaless: function( test ){
+		var options = {
+			noencodepng: true,
+			pngpath: "//mycdn.com/images/"
+		};
+
+		test.equal( this.encoder.encode(options), '//mycdn.com/images/cat.png' );
+		test.done();
+        }
+    };
 }());

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

41297

increased by3.21%

Lines of code

763

increased by5.97%

No dependency changes