dnode - npm Package Compare versions

Comparing version 0.9.6 to 0.9.8

examples/simple/client.js

@@ -5,5 +5,5 @@ var dnode = require('dnode');
     remote.zing(33, function (n) {
-        console.log('n = ' + n);
+        console.log('n=' + n);
         conn.end();
     });
 });

examples/simple/server.js

 var dnode = require('dnode');
 
-var server = dnode({
-    zing : function (n, cb) { cb(n * 100) }
+var server = dnode(function (remote, conn) {
+    this.zing = function (n, cb) { cb(n * 100) };
 });
 server.listen(7070);

index.js

@@ -190,3 +190,3 @@ var net = require('net');
             server || params.webserver,
-            params.mount || '/dnode.js',
+            params.mount === undefined ? '/dnode.js' : params.mount,
             params.io || {}
@@ -274,5 +274,16 @@ );
 dnode.prototype.close = function () {
-    this.server.close();
+    var self = this
+    try {
+        self.server.close();
+    }
+    catch (e) {
+        if (e.message === 'Not running') {
+            self.server.emit('close');
+        }
+        else {
+          self.server.emit('error', e);
+        }
+    }
 };
- 
+
 dnode.connect = function () {
@@ -279,0 +290,0 @@ var d = dnode();

lib/stream_socketio.js

@@ -12,5 +12,7 @@ var EventEmitter = require('events').EventEmitter;
         if (cache) {
-            res.setHeader('content-type', 'text/javascript');
-            res.setHeader('last-modified', cache.modified.toGMTString());
-            res.setHeader('date', new Date().toGMTString());
+            var headers = {
+                'content-type' : 'text/javascript',
+                'last-modified' : cache.modified.toGMTString(),
+                'date' : new Date().toGMTString(),
+            };
             
@@ -21,3 +23,3 @@ var ims = req.headers['if-modified-since'];
                 if (m >= cache.modified) {
-                    res.statusCode = 304;
+                    res.writeHead(304, headers);
                     res.end();
@@ -28,3 +30,3 @@ return;
             
-            res.statusCode = 200;
+            res.writeHead(200, headers);
             res.end(cache.source);
@@ -37,4 +39,3 @@ }
                     console.error(e.message || e);
-                    res.statusCode = 500;
-                    res.setHeader('content-type', 'text/plain');
+                    res.writeHead(500, { 'content-type' : 'text/plain' });
                     res.end('an error occured loading the bundle');
@@ -41,0 +42,0 @@ }

package.json

 {
     "name" : "dnode",
-    "version" : "0.9.6",
+    "version" : "0.9.8",
     "description" : "freestyle RPC",
@@ -28,10 +28,10 @@ "main" : "./index.js",
         "lazy" : ">=1.0.5 <1.1",
-        "traverse" : "0.4.x",
-        "dnode-protocol" : "0.1.x",
+        "dnode-protocol" : "~0.1.2",
         "jsonify" : "0.0.x"
     },
     "devDependencies" : {
-        "tap" : "0.0.x",
-        "browserify" : "1.4.x",
-        "uglify-js" : "1.0.6"
+        "tap" : "~0.2.4",
+        "browserify" : "~1.10.7",
+        "uglify-js" : "~1.2.5",
+        "express" : "~2.5.9"
     },
@@ -38,0 +38,0 @@ "scripts" : {

test/bundle.js

@@ -6,5 +6,10 @@ var test = require('tap').test;
 
+var path = require('path');
+if (!path.existsSync(__dirname + '/../browser/bundle.js')) {
+    require('../bin/bundle.js');
+}
+
 test('checkCookieHTTP', function (t) {
     t.plan(3);
-    var port = Math.floor(10000 + (Math.random() * Math.pow(2,16) - 10000));
+    var port = Math.floor(1e4 + (Math.random() * 5e4 - 1e4));
     
@@ -41,3 +46,3 @@ var web = http.createServer(function (req, res) {
     t.plan(3);
-    var port = Math.floor(10000 + (Math.random() * Math.pow(2,16) - 10000));
+    var port = Math.floor(1e4 + (Math.random() * 5e4 - 1e4));
     
@@ -44,0 +49,0 @@ var app = express.createServer();

test/emit.js

@@ -7,3 +7,3 @@ var test = require('tap').test;
     t.plan(2);
-    var port = Math.floor(Math.random() * ((1<<16)-1e4)) + 1e4;
+    var port = Math.floor(1e4 + (Math.random() * 5e4 - 1e4));
     
@@ -10,0 +10,0 @@ var subs = [];

test/error.js

@@ -88,1 +88,16 @@ var dnode = require('../');
 });
+
+test('close same server twice shouldn\'t throw errors', function(t) {
+    var port = Math.floor(Math.random() * 40000 + 10000);
+    var server = dnode();
+    server.on('ready', function() {
+        server.once('close', function() {
+            server.once('close', function() {
+                t.end();
+            })
+            server.close();
+        })
+        server.close();
+    });
+    server.listen(port);
+})

test/self-referential.js

 var dnode = require('../')
 var test = require('tap').test;
+var util = require('util');
 
-test('simple', function (t) {
+test('self-referential', function (t) {
     t.plan(6);
@@ -29,3 +30,3 @@ var port = Math.floor(Math.random() * 40000 + 10000);
             remote.print(args, function (m) {
-                t.deepEqual(m, args);
+                t.equal(util.inspect(m), util.inspect(args));
                 
@@ -32,0 +33,0 @@ conn.end();

testling/test.js

@@ -8,4 +8,3 @@ var test = require('testling');
     t.log(typeof DNode);
-    t.end();
-    /*
+    
     DNode.connect(host, port, function (remote) {
@@ -21,3 +20,2 @@ remote.cat(function (theCatSays, dog) {
     });
-    */
 });

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Environment variable access

Supply chain risk

Package accesses environment variables, which may be a sign of credential stuffing or data theft.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Dynamic require

Supply chain risk

Dynamic require can indicate the package is performing dangerous or unsafe dynamic code execution.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

146957

increased by0.15%

Dependency count

5

decreased by-16.67%

Lines of code

1790

increased by1.59%

Number of lines in readme file

319

increased by1.59%

Worsened metrics

Dev dependency count

4

increased by33.33%

Number of low supply chain risk alerts

14

increased by27.27%

Dependency changes

• - Removedtraverse@0.4.x

• - Removedtraverse@0.4.6(transitive)

• Updateddnode-protocol@~0.1.2