documentdb - npm Package Compare versions

Comparing version 1.5.4 to 1.5.5

changelog.md

@@ -0,1 +1,5 @@
+## Changes in 1.5.5 : ##
+
+- Fixed hashParitionResolver resolveForRead(): When no partition key supplied was throwing exception, instead of returning a list of all registered links.
+
 ## Changes in 1.5.4 : ##
@@ -2,0 +6,0 @@

lib/constants.js

@@ -149,3 +149,3 @@ /*
     
-    UserAgent: "documentdb-nodejs-sdk-1.5.4",
+    UserAgent: "documentdb-nodejs-sdk-1.5.5",
     
@@ -152,0 +152,0 @@ DefaultPrecisions: {

lib/hash/hashPartitionResolver.js

@@ -43,2 +43,3 @@ /*
         this.consistentHashRing = new ConsistentHashRing(collectionLinks, options);
+        this.collectionLinks = collectionLinks;
     }, {
@@ -60,3 +61,7 @@ /**
         resolveForRead: function (partitionKey) {
-            return [this._resolve(partitionKey)];
+            if (partitionKey === undefined || partitionKey === null) {
+                return this.collectionLinks;
+            }
+
+            return [this._resolve(partitionKey)];            
         },
@@ -63,0 +68,0 @@ /**

package.json

@@ -12,3 +12,3 @@ {
   ],
-  "version": "1.5.4",
+  "version": "1.5.5",
   "author": "Microsoft Corporation",
@@ -15,0 +15,0 @@ "main": "./index.js",

test/hashPartitionResolverTests.js

@@ -78,10 +78,13 @@ /*
 
-    it("invalid key", function () {
+    it("null key", function () {
         var resolver = new HashPartitionResolver("ignored", ["dbs/foo/colls/A", "dbs/foo/colls/B", "dbs/foo/colls/C"]);
-        assert.throws(
-            function () {
-                resolver.resolveForRead(null);
-            },
-            /partitionKey must be a 'string'/);
+        var links = resolver.resolveForRead(null);
+        assert.deepEqual(links, ["dbs/foo/colls/A", "dbs/foo/colls/B", "dbs/foo/colls/C"]);
     });
+
+    it("undefined key", function () {
+        var resolver = new HashPartitionResolver("ignored", ["dbs/foo/colls/A", "dbs/foo/colls/B", "dbs/foo/colls/C"]);
+        var links = resolver.resolveForRead();
+        assert.deepEqual(links, ["dbs/foo/colls/A", "dbs/foo/colls/B", "dbs/foo/colls/C"]);
+    });
 });
@@ -88,0 +91,0 @@

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Native code

Supply chain risk

Contains native code (e.g., compiled binaries or shared libraries). Including native code can obscure malicious behavior.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

3749649

increased by2.54%

Lines of code

7535

increased by0.08%

Number of medium supply chain risk alerts

1

decreased by-50%

Worsened metrics

Number of package files

30

decreased by-3.23%

No dependency changes