domv - npm Package Compare versions

Comparing version 2.0.0 to 3.0.0

lib/domv.js

@@ -29,5 +29,9 @@ 'use strict';
 var slice = Array.prototype.slice;
-var nameOverridesBuiltin = require('./name-overrides-builtin');
 
+var Symbol = require('es6-symbol');
+/* jshint -W064 */
+var SHORTHAND_CACHE = Symbol('domv element shorthand cache');
+/* jshint +W064 */
 
+
 /** All of the valid node types in DOM (excluding the ones that are deprecated).
@@ -451,6 +455,6 @@ * @enum {number}
         if (arguments.length === 2 &&
-            document.__domvShorthandCache__ &&
-            document.__domvShorthandCache__[tagName])
+            document[SHORTHAND_CACHE] &&
+            document[SHORTHAND_CACHE][tagName])
         {
-                return document.__domvShorthandCache__[tagName];
+                return document[SHORTHAND_CACHE][tagName];
         }
@@ -487,8 +491,8 @@
         {
-                if (!document.__domvShorthandCache__)
+                if (!document[SHORTHAND_CACHE])
                 {
-                        document.__domvShorthandCache__ = Object.create(null);
+                        document[SHORTHAND_CACHE] = Object.create(null);
                 }
 
-                document.__domvShorthandCache__[tagName] = shorthandInstance;
+                document[SHORTHAND_CACHE][tagName] = shorthandInstance;
         }
@@ -816,14 +820,2 @@
 /**
- * Does the given name potentially override a builtin property of `document` or `HTMLFormElement`?
- * This list of invalid properties used by this method might not be exhaustive, this method is not intended
- * to validate arbitrary user input.
- * @param name Value of `name` or `id` attribute
- * @return {Boolean} True if this name overrides a builtin property
- */
-module.exports.nameOverridesBuiltin = function(name)
-{
-        return nameOverridesBuiltin(name);
-};
-
-/**
  * <p>The Node interface is the primary datatype for the entire Document Object Model.
@@ -830,0 +822,0 @@ * It represents a single node in the document tree. While all objects implementing

package.json

 {
   "name": "domv",
-  "version": "2.0.0",
+  "version": "3.0.0",
   "author": "Joris van der Wel <[e-mail]>",
@@ -38,2 +38,3 @@ "description": "Create views as components using DOM. Run the same code on the browser and on the server.",
   "dependencies": {
+    "es6-symbol": "^2.0.1",
     "inherits": "^2.0.1",
@@ -40,0 +41,0 @@ "throwable": "^1.0.3"

test/domv.js

@@ -5,24 +5,2 @@ 'use strict';
 
-function getAllPropertyNames()
-{
-        var names = [];
-
-        for (var i = 0; i < arguments.length; ++i)
-        {
-                var obj = arguments[i];
-
-                while (obj)
-                {
-                        names = names.concat(Object.getOwnPropertyNames(obj));
-                        obj = Object.getPrototypeOf(obj);
-                }
-        }
-
-        names.sort();
-        return names.filter(function(name, index, names)
-        {
-                return index === 0 || names[index - 1] !== name;
-        });
-}
-
 function testParseHTMLDocumentResult(test, doc)
@@ -510,37 +488,3 @@ {
                 test.done();
-        },
-        'nameOverridesBuiltin': function(test)
-        {
-                getAllPropertyNames(this.document).forEach(function(name)
-                {
-                        if (require('jsdom').jsdom && name[0] === '_')
-                        {
-                                // skip jsdom interal property
-                                // (also, jsdom does not support [OverrideBuiltins] yet)
-                                return;
-                        }
-
-                        test.ok(domv.nameOverridesBuiltin(name), name);
-                });
-
-                getAllPropertyNames(this.document.createElement('form')).forEach(function(name)
-                {
-                        if (require('jsdom').jsdom && name[0] === '_')
-                        {
-                                // skip jsdom interal property
-                                // (also, jsdom does not support [OverrideBuiltins] yet)
-                                return;
-                        }
-
-                        test.ok(domv.nameOverridesBuiltin(name), name);
-                });
-
-                // a few random ones it should return false for
-                test.ok(!domv.nameOverridesBuiltin('foo'));
-                test.ok(!domv.nameOverridesBuiltin('firstchild')); // (wrong case)
-                test.ok(!domv.nameOverridesBuiltin('bar'));
-                test.ok(!domv.nameOverridesBuiltin(''));
-
-                test.done();
         }
 };

No alert changes

Worsened metrics

Total package byte prevSize

401868

decreased by-2.81%

Dependency count

4

increased by33.33%

Number of package files

18

decreased by-5.26%

Lines of code

5517

decreased by-7.49%

Dependency changes

• + Addedes6-symbol@^2.0.1

• + Addedd@0.1.11.0.2(transitive)

• + Addedes5-ext@0.10.64(transitive)

• + Addedes6-iterator@2.0.3(transitive)

• + Addedes6-symbol@2.0.13.1.4(transitive)

• + Addedesniff@2.0.1(transitive)

• + Addedevent-emitter@0.3.5(transitive)

• + Addedext@1.7.0(transitive)

• + Addednext-tick@1.1.0(transitive)

• + Addedtype@2.7.3(transitive)