download - npm Package Compare versions

Comparing version 0.2.3 to 0.2.4

index.js

@@ -102,2 +102,4 @@ 'use strict';
         request.get(obj.url, opts)
+            .on('error', done)
+
             .on('data', function (data) {
@@ -109,13 +111,19 @@ ret.push(data);
                 if (res.statusCode < 200 || res.statusCode >= 300) {
-                    return done(res.statusCode);
+                    return cb(res.statusCode);
                 }
 
                 self._run(res);
-            })
 
-            .on('error', done)
+                res.on('end', function () {
+                    if (opts.extract) {
+                        return self._extract(Buffer.concat(ret), obj.dest, opts, function (err) {
+                            if (err) {
+                                return done(err);
+                            }
 
-            .on('end', function () {
-                if (opts.extract) {
-                    return self._extract(Buffer.concat(ret), obj.dest, opts, function (err) {
+                            done(err);
+                        });
+                    }
+
+                    fs.outputFile(path.join(obj.dest, name), Buffer.concat(ret), function (err) {
                         if (err) {
@@ -125,22 +133,14 @@ return done(err);
 
-                        done(err);
-                    });
-                }
+                        if (opts.mode) {
+                            return fs.chmod(path.join(obj.dest, name), opts.mode, function (err) {
+                                if (err) {
+                                    return done(err);
+                                }
 
-                fs.outputFile(path.join(obj.dest, name), Buffer.concat(ret), function (err) {
-                    if (err) {
-                        return done(err);
-                    }
+                                done();
+                            });
+                        }
 
-                    if (opts.mode) {
-                        return fs.chmod(path.join(obj.dest, name), opts.mode, function (err) {
-                            if (err) {
-                                return done(err);
-                            }
-
-                            done();
-                        });
-                    }
-
-                    done();
+                        done();
+                    });
                 });
@@ -147,0 +147,0 @@ });

package.json

 {
   "name": "download",
-  "version": "0.2.3",
+  "version": "0.2.4",
   "description": "Download and extract files effortlessly",
@@ -37,3 +37,3 @@ "license": "MIT",
   "devDependencies": {
-    "mocha": "^1.18.2",
+    "mocha": "^1.21.4",
     "nock": "^0.27.1",
@@ -40,0 +40,0 @@ "rimraf": "^2.2.5"

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

7434

increased by4.13%

No dependency changes