Comparing version 1.11.0 to 1.12.0
@@ -35,5 +35,7 @@ /** | ||
// gets all the items together in a merged array | ||
function itemsCallback(error, items) { | ||
function itemsCallback(error, itemsResponse) { | ||
if (error) throw error; | ||
var items = itemsResponse.searchResult.item; | ||
console.log('Found', items.length, 'items'); | ||
@@ -40,0 +42,0 @@ |
@@ -7,3 +7,2 @@ // eBay API client for Node.js | ||
require('./lib/xml-request'), | ||
require('./lib/pagination'), | ||
require('./lib/xml-converter'), | ||
@@ -10,0 +9,0 @@ require('./lib/json-parser'), |
{ | ||
"name": "ebay-api", | ||
"description": "eBay API Client", | ||
"version": "1.11.0", | ||
"version": "1.12.0", | ||
"homepage": "https://github.com/benbuckman/nodejs-ebay-api", | ||
@@ -6,0 +6,0 @@ "author": "Ben Buckman", |
@@ -95,20 +95,2 @@ eBay API client for Node.js | ||
### `paginateGetRequest(options, callback)` | ||
Make a multi-page request to a GET service, running them in parallel and combining the results. | ||
_Note: this is currently broken in 1.x. Fixes/refactors are welcome._ | ||
`options` contains the same parameters as `ebayApiGetRequest`, plus: | ||
- pages: # of pages to query | ||
- perPage: items per page | ||
`parser` here needs to return an array, so the results can be concatenated and passed to `callback`. | ||
Note: Because the pages all run in parallel, they can cause spikes on CPU and network activity. In the future, I might switch this to using an [async](https://github.com/caolan/async) `queue` (instead of `forEach`) with a variable concurrency. (A `forEachSeries` can also be used, but negates the purpose of running the requests asynchronously.) | ||
`callback` gets `(error, items)` | ||
## Helpers | ||
@@ -163,5 +145,2 @@ | ||
See the [examples][examples] directory. | ||
There are two examples, one with a single-page `findItemsByKeywords` request, | ||
the other a paginated `findItemsAdvanced` request. It should be reasonably apparent from the examples | ||
how these functions are used. | ||
To run the examples, you need to add your own app key (I don't want my keys to be disabled for abuse!) - | ||
@@ -182,2 +161,2 @@ you can get one [here](https://publisher.ebaypartnernetwork.com/PublisherToolsAPI). | ||
[examples]: https://github.com/benbuckman/nodejs-ebay-api/tree/master/examples | ||
[request]: https://github.com/request/request | ||
[request]: https://github.com/request/request |
License Policy Violation
LicenseThis package is not allowed per your license policy. Review the package's license to ensure compliance.
Found 1 instance in 1 package
License Policy Violation
LicenseThis package is not allowed per your license policy. Review the package's license to ensure compliance.
Found 1 instance in 1 package
94868
30
1594
160