ebay-api - npm Package Compare versions

Comparing version 1.12.1 to 1.13.0

lib/xml-request.js

		@@ -108,2 +108,27 @@ var
		body: buildXmlInput(options),
		// As of 3/22/2016, the eBay API has several servers that can only
		// negotiate TLS v1.0 sessions, and several servers that can negotiate TLS
		// v1.0, v1.1 and v1.2. Node/OpenSSL get confused by this, and occasionally
		// attempt to parse a v1.2 response using TLS v1.0 and vice versa. The
		// error you get back from the request looks something like this:
		//
		// { [Error: write EPROTO 140113357338496:error:1408F10B:SSL
		// routines:SSL3_GET_RECORD:wrong version number:../deps/openssl/openssl/ssl/s3_pkt.c:362:
		// ] code: 'EPROTO',
		// errno: 'EPROTO',
		// syscall: 'write' }
		//
		// As far as I can tell, this isn't patched yet, in Node or OpenSSL. But
		// setting the following options forces all connections to be negotiated
		// with TLS v1.0, effectively fixing the issue.
		//
		// More reading:
		//
		// https://github.com/aws/aws-sdk-js/issues/862
		// https://github.com/nodejs/node/issues/3692
		// https://www.ssllabs.com/ssltest/analyze.html?d=api.ebay.com
		agentOptions: {
		ciphers: 'ALL',
		secureProtocol: 'TLSv1_method',
		},
		}, options.reqOptions);
		@@ -110,0 +135,0 @@

package.json

		{
		"name": "ebay-api",
		"description": "eBay API Client",
		"version": "1.12.1",
		"version": "1.13.0",
		"homepage": "https://github.com/benbuckman/nodejs-ebay-api",
		@@ -6,0 +6,0 @@ "author": "Ben Buckman",

test/xml-request.test.js

		@@ -5,3 +5,3 @@ require('./helpers');
		request = require('request'),
		ebay = require('../index')
		ebay = require('../index'),
		xmlRequest = ebay.xmlRequest;
		@@ -57,5 +57,9 @@
		' <ItemID>123456</ItemID>\n' +
		'</GetSingleItemRequest>'
		'</GetSingleItemRequest>',
		agentOptions: {
		ciphers: 'ALL',
		secureProtocol: 'TLSv1_method',
		},
		});
		})
		});
		});
		@@ -89,3 +93,3 @@
		);
		})
		});
		});
		@@ -183,3 +187,7 @@
		' </paginationInput>\n' +
		'</findItemsByKeywordsRequest>'
		'</findItemsByKeywordsRequest>',
		agentOptions: {
		ciphers: 'ALL',
		secureProtocol: 'TLSv1_method',
		},
		});
		@@ -222,3 +230,3 @@ });
		);
		})
		});
		});
		@@ -299,3 +307,3 @@
		expect(data).to.have.property('Orders').that.is.instanceof(Array);
		})
		});
		});
		@@ -344,3 +352,3 @@
		expect(data).to.have.property('Orders').that.is.instanceof(Array);
		})
		});
		});
		@@ -389,3 +397,3 @@
		expect(err).to.be.an.instanceOf(ebay.EbayClientError);
		})
		});
		});
		@@ -415,3 +423,3 @@
		expect(err.message).to.match(/503/);
		})
		});
		});
		@@ -444,6 +452,6 @@
		expect(err.message).to.match(/Boo/);
		})
		});

		});
		})
		});
		});

New alerts