egg-core - npm Package Compare versions

Comparing version 4.28.0 to 4.28.1

History.md

 
+4.28.1 / 2022-11-28
+==================
+
+**fixes**
+  * [[`1d7d19b`](http://github.com/eggjs/egg-core/commit/1d7d19bc6c1fabdb8cea51dcd680fd608f5cc4fe)] - fix: fix call legacyReadyCallback with options (#250) (killa <<[e-mail]>>)
+
 4.28.0 / 2022-11-28
@@ -3,0 +9,0 @@ ==================

lib/lifecycle.js

@@ -74,19 +74,11 @@ 'use strict';
   legacyReadyCallback(name, opt) {
-    const timingKeyPrefix = 'Did Load';
-    if (!opt) {
-      const timing = this.timing;
-      const cb = this.loadReady.readyCallback(name);
-      const timingkey = `${timingKeyPrefix} in ` + utils.getResolvedFilename(name, this.app.baseDir);
-      this.timing.start(timingkey);
-      return function legacyReadyCallback(...args) {
-        timing.end(timingkey);
-        cb(...args);
-      };
-    }
-    this[REGISTER_READY_CALLBACK]({
-      scope: opt,
-      ready: this.loadReady,
-      timingKeyPrefix,
-      scopeFullName: name,
-    });
+    const timingKeyPrefix = 'readyCallback';
+    const timing = this.timing;
+    const cb = this.loadReady.readyCallback(name, opt);
+    const timingkey = `${timingKeyPrefix} in ` + utils.getResolvedFilename(name, this.app.baseDir);
+    this.timing.start(timingkey);
+    return function legacyReadyCallback(...args) {
+      timing.end(timingkey);
+      cb(...args);
+    };
   }
@@ -93,0 +85,0 @@

package.json

 {
   "name": "egg-core",
-  "version": "4.28.0",
+  "version": "4.28.1",
   "description": "A core Pluggable framework based on koa",
@@ -5,0 +5,0 @@ "main": "index.js",

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

137319

increased by0.05%

Worsened metrics

Lines of code

3011

decreased by-0.26%

No dependency changes