eh-api-client - npm Package Compare versions

Comparing version 0.13.0 to 0.14.0

index.js

@@ -99,32 +99,10 @@ var
   if(options.filter) {
-    var filterFields = [];
-    for(var i = 0; i != options.filter.length; i++) {
-      var filter = options.filter[i];
-      if(!filter.field) {
-        var key = Object.keys(filter)[0];
-        if(!key) {
-          continue;
-        }
-        filter.field = key;
-        var type = "eq";
-        var value = filter[key];
-        if(value instanceof Array) {
-          type = "in";
-        }
-        else if(typeof value === "object") {
-          type = Object.keys(value)[0];
-          value = value[type];
-        }
-        filter.value = value;
-        filter.type = type;
-      }
-      filterFields.push(filter.field);
-      reqParams.qs["filterValue_" + filter.field] = filter.value;
-      reqParams.qs["filterType_" + filter.field] = filter.type;
-    }
-    reqParams.qs["filterFields"] = filterFields;
+    reqParams.qs.filter = (JSON.stringify(options.filter));
   }
   if(options.range) {
-    reqParams.headers.Range = options.range;
+    reqParams.qs.range = (JSON.stringify(options.range));
   }
+  if(options.order) {
+    reqParams.qs.order = (JSON.stringify(options.order));
+  }
   if(options.headers) {
@@ -131,0 +109,0 @@ _.assign(reqParams.headers, options.headers);

package.json

 {
   "name": "eh-api-client",
-  "version": "0.13.0",
+  "version": "0.14.0",
   "description": "Node.js rest client",
@@ -5,0 +5,0 @@ "main": "index.js",

test/main.js

@@ -66,3 +66,3 @@ var
   });
-
+/*
   it("get notes list", function(done) {
@@ -103,22 +103,17 @@ client.get("/notes/", function(err, data) {
   });
-
+*/
   it("should make correct filter request", function(done) {
+    var filter = {
+      key: 1,
+      "id": {
+        "gt": 500
+      }
+    };
     client.get({
       test: true,
       url: "test",
-      filter: [
-        {key: 1},
-        {
-          field: "id",
-          type: "gt",
-          value: 500
-        }
-      ]
+      filter: filter
     }, function(err, req) {
       should.not.exists(err);
-      req.qs.filterFields.should.eql(["key", "id"]);
-      req.qs.filterType_key.should.equal("eq");
-      req.qs.filterValue_key.should.equal(1);
-      req.qs.filterType_id.should.equal("gt");
-      req.qs.filterValue_id.should.equal(500);
+      req.qs.filter.should.eql(JSON.stringify(filter));
       done();
@@ -128,5 +123,22 @@ });
 
+  it("should make a order request", function(done) {
+    var order = ['date_updated', 'asc'];
+    client.get("/test", {
+      order: order,
+      test: true
+    }, function(err, req) {
+      should.not.exists(err);
+      req.url.should.equal("http://localhost:3000/test");
+      req.qs.order.should.eql(JSON.stringify(order));
+      done();
+    });
+  });
+
   it("should make a range request", function(done) {
+    var range =  {
+      limit: 10,
+      offset: 0
+    };
     client.get("/test", {
-      range: "items 0-4",
+      range: range,
       test: true
@@ -136,3 +148,3 @@ }, function(err, req) {
       req.url.should.equal("http://localhost:3000/test");
-      req.headers.Range.should.equal("items 0-4");
+      req.qs.range.should.eql(JSON.stringify(range));
       done();
@@ -143,8 +155,12 @@ });
   it("should make a range request(promise)", function(done) {
+    var range =  {
+      limit: 10,
+      offset: 0
+    };
     client.get("/test", {
-      range: "items 0-4",
+      range: range,
       test: true
     }).then(function(req) {
       req.url.should.equal("http://localhost:3000/test");
-      req.headers.Range.should.equal("items 0-4");
+      req.qs.range.should.eql(JSON.stringify(range));
       done();
@@ -151,0 +167,0 @@ });

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Worsened metrics

Total package byte prevSize

16756

decreased by-2.28%

Lines of code

615

decreased by-0.81%

No dependency changes