eh-api-client - npm Package Compare versions

Comparing version 0.18.0 to 0.19.0

index.js

@@ -18,2 +18,5 @@ var
   });
+  this.requestOptions = {
+    timeout: 300000
+  };
   this.Client = getClientClass();
@@ -32,5 +35,9 @@ };
 
+Factory.prototype.setRequestOptions = function(options) {
+  _.extend(this.requestOptions, options);
+};
+
 Factory.prototype.setAgentOptions = function(options) {
   _.defaults(options, {keepAlive: true});
-  self.agent = new Agent(options);
+  this.agent = new Agent(options);
 };
@@ -37,0 +44,0 @@

lib/client.js

@@ -43,5 +43,16 @@ var
   }
+  if(error.httpStatus >= 500 && error.httpStatus < 600 && !error.hasOwnProperty("name")) {
+    error.name = "ServerError";
+  }
   return error;
 }
 
+function buildNetworkError(res, origErr, url, method) {
+  var error = new Error();
+  error.httpURL = url;
+  error.name = "NetworkError";
+  error.message = origErr.code;
+  return error;
+}
+
 module.exports = function() {
@@ -145,3 +156,3 @@ var Client = function(apiURL, options) {
       if(err) {
-        return deferred.reject(err);
+        return deferred.reject(buildNetworkError(res, err, reqParams.url, method));
       }
@@ -168,2 +179,3 @@ if(res.statusCode < 200 || res.statusCode >= 300) {
     _.extend(params, this._factory.retryOptions);
+    _.extend(params, this._factory.requestOptions);
     return request(params, cb);
@@ -170,0 +182,0 @@ };

package.json

 {
   "name": "eh-api-client",
-  "version": "0.18.0",
+  "version": "0.19.0",
   "description": "Node.js rest client",
@@ -5,0 +5,0 @@ "main": "index.js",

test/keep_alive.js

@@ -53,3 +53,4 @@ var
           }
-          err.code.should.equal("ECONNRESET");
+          err.name.should.equal("NetworkError");
+          err.message.should.equal("ECONNRESET");
           done();
@@ -56,0 +57,0 @@ });

test/main.js

@@ -91,3 +91,3 @@ var
 
-  it("create client with userId = undefined should create guest client", function(done) {
+  it("create client with userId = undefined should create guest client", function() {
     var c = f.getClient(undefined, "web");
@@ -97,3 +97,3 @@ c.internalAuth.should.equal("0:web");
 
-  it("create client with userId = null should create guest client", function(done) {
+  it("create client with userId = null should create guest client", function() {
     var c = f.getClient(null, "web");
@@ -100,0 +100,0 @@ c.internalAuth.should.equal("0:web");

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

No README

Quality

Package does not have a README. This may indicate a failed publish or a low quality package.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

21577

increased by18.84%

Number of package files

9

increased by28.57%

Lines of code

743

increased by17.19%

Number of medium quality alerts

1

decreased by-50%

Number of lines in readme file

18

increased byInfinity%

Worsened metrics

Number of medium supply chain risk alerts

4

increased by33.33%

No dependency changes