electron-installer-common - npm Package Compare versions

Comparing version 0.2.0 to 0.3.0

NEWS.md

@@ -5,4 +5,12 @@ # `electron-installer-common` - Changes by Version
 
-[Unreleased]: https://github.com/electron-userland/electron-installer-common/compare/v0.2.0...master
+[Unreleased]: https://github.com/electron-userland/electron-installer-common/compare/v0.3.0...master
 
+## [0.3.0] - 2018-12-26
+
+[0.3.0]: https://github.com/electron-userland/electron-installer-common/compare/v0.2.0...v0.3.0
+
+## Changed
+
+* Don't require an `options` object to use `readElectronVersion` (#3)
+
 ## [0.2.0] - 2018-12-26
@@ -9,0 +17,0 @@

package.json

 {
   "name": "electron-installer-common",
-  "version": "0.2.0",
+  "version": "0.3.0",
   "description": "Common functionality for creating distributable Electron apps",
@@ -5,0 +5,0 @@ "author": "Mark Lee",

src/readelectronversion.js

@@ -13,5 +13,5 @@ 'use strict'
  */
-module.exports = function readElectronVersion (options) {
-  return fs.readFile(path.resolve(options.src, 'version'))
+module.exports = function readElectronVersion (appDir) {
+  return fs.readFile(path.resolve(appDir, 'version'))
     .then(tag => tag.toString().trim())
 }

test/readelectronversion.js

 'use strict'
 
+const path = require('path')
 const readElectronVersion = require('../src/readelectronversion')
@@ -7,4 +8,4 @@ const test = require('ava')
 test('readElectronVersion', t => {
-  return readElectronVersion({ src: 'test/fixtures' })
+  return readElectronVersion(path.resolve(__dirname, 'fixtures'))
     .then(version => t.is(version, 'v3.0.11'))
 })

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

37318

increased by0.64%

Lines of code

486

increased by0.21%

No dependency changes