electron-installer-common - npm Package Compare versions

Comparing version 0.3.0 to 0.4.0

NEWS.md

		@@ -5,4 +5,13 @@ # `electron-installer-common` - Changes by Version

		[Unreleased]: https://github.com/electron-userland/electron-installer-common/compare/v0.3.0...master
		[Unreleased]: https://github.com/electron-userland/electron-installer-common/compare/v0.4.0...master

		## [0.4.0] - 2018-12-26

		[0.4.0]: https://github.com/electron-userland/electron-installer-common/compare/v0.3.0...v0.4.0

		## Changed

		* `getDepends` no longer uses `getTrashDepends` (#4)
		* `getTrashDepends` returns a list of dependencies instead of a Debian-style dependency string (#4)

		## [0.3.0] - 2018-12-26
		@@ -9,0 +18,0 @@

package.json

		{
		"name": "electron-installer-common",
		"version": "0.3.0",
		"version": "0.4.0",
		"description": "Common functionality for creating distributable Electron apps",
		@@ -5,0 +5,0 @@ "author": "Mark Lee",

src/dependencies.js

		@@ -21,12 +21,14 @@ 'use strict'
		/**
		* Determine the dependencies for the `shell.moveItemToTrash` API, based on the
		* Determine the dependencies for the `shell.moveItemToTrash` Electron API, based on the
		* Electron version in use.
		*
		* @return {string[]} an ordered list of dependencies that are OR'd together by the installer module.
		*/
		function getTrashDepends (version, dependencyMap) {
		if (semver.lt(version, '1.4.1')) {
		return dependencyMap.gvfs
		return [dependencyMap.gvfs]
		} else if (semver.lt(version, '1.7.2')) {
		return `${dependencyMap.kdeCliTools} \| ${dependencyMap.kdeRuntime} \| ${dependencyMap.trashCli} \| ${dependencyMap.gvfs}`
		return [dependencyMap.kdeCliTools, dependencyMap.kdeRuntime, dependencyMap.trashCli, dependencyMap.gvfs]
		} else {
		return `${dependencyMap.kdeCliTools} \| ${dependencyMap.kdeRuntime} \| ${dependencyMap.trashCli} \| ${dependencyMap.glib2} \| ${dependencyMap.gvfs}`
		return [dependencyMap.kdeCliTools, dependencyMap.kdeRuntime, dependencyMap.trashCli, dependencyMap.glib2, dependencyMap.gvfs]
		}
		@@ -48,3 +50,2 @@ }
		return [
		getTrashDepends(version, dependencyMap),
		getGTKDepends(version, dependencyMap),
		@@ -51,0 +52,0 @@ dependencyMap.notify,

test/dependencies.js

		@@ -46,5 +46,5 @@ 'use strict'
		const trashDepends = dependencies.getTrashDepends('v1.3.0', dependencyMap)
		t.regex(trashDepends, new RegExp(dependencyMap.gvfs))
		t.notRegex(trashDepends, new RegExp(dependencyMap.kdeCliTools))
		t.notRegex(trashDepends, new RegExp(dependencyMap.glib2))
		t.true(trashDepends.includes(dependencyMap.gvfs))
		t.false(trashDepends.includes(dependencyMap.kdeCliTools))
		t.false(trashDepends.includes(dependencyMap.glib2))
		})
		@@ -54,5 +54,5 @@
		const trashDepends = dependencies.getTrashDepends('v1.6.0', dependencyMap)
		t.regex(trashDepends, new RegExp(dependencyMap.gvfs))
		t.regex(trashDepends, new RegExp(dependencyMap.kdeCliTools))
		t.notRegex(trashDepends, new RegExp(dependencyMap.glib2))
		t.true(trashDepends.includes(dependencyMap.gvfs))
		t.true(trashDepends.includes(dependencyMap.kdeCliTools))
		t.false(trashDepends.includes(dependencyMap.glib2))
		})
		@@ -62,5 +62,5 @@
		const trashDepends = dependencies.getTrashDepends('v1.8.2', dependencyMap)
		t.regex(trashDepends, new RegExp(dependencyMap.gvfs))
		t.regex(trashDepends, new RegExp(dependencyMap.kdeCliTools))
		t.regex(trashDepends, new RegExp(dependencyMap.glib2))
		t.true(trashDepends.includes(dependencyMap.gvfs))
		t.true(trashDepends.includes(dependencyMap.kdeCliTools))
		t.true(trashDepends.includes(dependencyMap.glib2))
		})
		@@ -67,0 +67,0 @@

New alerts