electron-installer-common - npm Package Compare versions

Comparing version 0.4.0 to 0.4.1

NEWS.md

@@ -5,4 +5,12 @@ # `electron-installer-common` - Changes by Version
 
-[Unreleased]: https://github.com/electron-userland/electron-installer-common/compare/v0.4.0...master
+[Unreleased]: https://github.com/electron-userland/electron-installer-common/compare/v0.4.1...master
 
+## [0.4.1] - 2019-01-02
+
+[0.4.1]: https://github.com/electron-userland/electron-installer-common/compare/v0.4.0...v0.4.1
+
+### Fixed
+
+* Check that `createBinary` symlinks to an existing Electron app binary (#6)
+
 ## [0.4.0] - 2018-12-26
@@ -12,3 +20,3 @@
 
-## Changed
+### Changed
 
@@ -22,3 +30,3 @@ * `getDepends` no longer uses `getTrashDepends` (#4)
 
-## Changed
+### Changed
 
@@ -31,3 +39,3 @@ * Don't require an `options` object to use `readElectronVersion` (#3)
 
-## Added
+### Added
 
@@ -34,0 +42,0 @@ * scoped package name replacer (#1)

package.json

 {
   "name": "electron-installer-common",
-  "version": "0.4.0",
+  "version": "0.4.1",
   "description": "Common functionality for creating distributable Electron apps",
@@ -5,0 +5,0 @@ "author": "Mark Lee",

src/index.js

@@ -104,6 +104,12 @@ 'use strict'
 
-    return fs.ensureDir(binDir, '0755')
-      .catch(wrapError('creating binary path'))
-      .then(() => fs.symlink(binSrc, binDest, 'file'))
-      .catch(wrapError('creating binary file'))
+    const bundledBin = path.join(options.src, options.bin)
+
+    return fs.pathExists(bundledBin)
+      .then(exists => {
+        if (!exists) {
+          throw new Error(`could not find the Electron app binary at "${bundledBin}". You may need to re-bundle the app using Electron Packager's "executableName" option.`)
+        }
+        return fs.ensureDir(binDir, '0755')
+      }).then(() => fs.symlink(binSrc, binDest, 'file'))
+      .catch(wrapError('creating binary symlink'))
   },
@@ -110,0 +116,0 @@ createContents: function createContents (options, dir, functions) {

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

39245

increased by4.38%

Number of package files

21

increased by10.53%

Lines of code

524

increased by7.6%

Worsened metrics

Number of low supply chain risk alerts

4

increased by33.33%

No dependency changes