electron-installer-common - npm Package Compare versions

Comparing version 0.6.2 to 0.6.3

NEWS.md

@@ -5,4 +5,12 @@ # `electron-installer-common` - Changes by Version
 
-[Unreleased]: https://github.com/electron-userland/electron-installer-common/compare/v0.6.2...master
+[Unreleased]: https://github.com/electron-userland/electron-installer-common/compare/v0.6.3...master
 
+## [0.6.3] - 2019-05-02
+
+[0.6.3]: https://github.com/electron-userland/electron-installer-common/compare/v0.6.2...v0.6.3
+
+### Added
+
+* `updateSandboxHelperPermissions` function outside of `ElectronInstaller` (#23)
+
 ## [0.6.2] - 2019-03-07
@@ -9,0 +17,0 @@

package.json

 {
   "name": "electron-installer-common",
-  "version": "0.6.2",
+  "version": "0.6.3",
   "description": "Common functionality for creating distributable Electron apps",
@@ -29,3 +29,3 @@ "author": "Mark Lee",
     "eslint-config-standard": "^12.0.0",
-    "eslint-plugin-ava": "^5.1.1",
+    "eslint-plugin-ava": "^6.0.0",
     "eslint-plugin-import": "^2.14.0",
@@ -35,3 +35,3 @@ "eslint-plugin-node": "^8.0.0",
     "eslint-plugin-standard": "^4.0.0",
-    "nyc": "^13.1.0",
+    "nyc": "^14.0.0",
     "sinon": "^7.2.2"
@@ -48,3 +48,3 @@ },
     "parse-author": "^2.0.0",
-    "semver": "^5.6.0",
+    "semver": "^6.0.0",
     "tmp-promise": "^1.0.5"
@@ -51,0 +51,0 @@ },

src/index.js

@@ -15,2 +15,3 @@ 'use strict'
 const template = require('./template')
+const updateSandboxHelperPermissions = require('./sandboxhelper')
 
@@ -36,3 +37,4 @@ module.exports = {
   spawn,
+  updateSandboxHelperPermissions,
   wrapError: error.wrapError
 }

src/installer.js

@@ -7,7 +7,8 @@ 'use strict'
 const error = require('./error')
+const fs = require('fs-extra')
 const glob = require('glob-promise')
-const fs = require('fs-extra')
 const path = require('path')
 const template = require('./template')
 const tmp = require('tmp-promise')
+const updateSandboxHelperPermissions = require('./sandboxhelper')
 
@@ -230,19 +231,5 @@ class ElectronInstaller {
    * the `chrome-sandbox` executable as appropriate.
-   *
-   * The sandbox helper executable must have the setuid (`+s` / `0o4000`) bit set.
-   *
-   * This doesn't work on Windows because you can't set that bit there.
-   *
-   * See: https://github.com/electron/electron/pull/17269#issuecomment-470671914
    */
   updateSandboxHelperPermissions () {
-    const sandboxHelperPath = path.join(this.stagingAppDir, 'chrome-sandbox')
-    return fs.pathExists(sandboxHelperPath)
-      .then(exists => {
-        if (exists) {
-          return fs.chmod(sandboxHelperPath, 0o4755)
-        } else {
-          return Promise.resolve()
-        }
-      })
+    return updateSandboxHelperPermissions(this.stagingAppDir)
   }
@@ -249,0 +236,0 @@ }

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

35603

increased by2%

Number of package files

18

increased by5.88%

Lines of code

535

increased by2.49%

Worsened metrics

Number of low supply chain risk alerts

6

increased by20%

Dependency changes

• + Addedsemver@6.3.1(transitive)

• - Removedsemver@5.7.2(transitive)

• Updatedsemver@^6.0.0