electron-installer-redhat - npm Package Compare versions

Comparing version 3.0.0 to 3.1.0

NEWS.md

@@ -7,2 +7,16 @@ # `electron-installer-redhat` - Changes by Version
 
+## [3.1.0] - 2020-06-28
+
+[3.1.0]: https://github.com/electron-userland/electron-installer-redhat/compare/v3.0.0...v3.1.0
+
+### Added
+
+* Dependencies for Electron >= 9 (#156)
+
+### Fixed
+
+* Stop overwriting `~/.rpmmacros` (#160)
+* Handle parsing versions from RPM >= 4.15 (#162)
+* Define array options for CLI (#166)
+
 ## [3.0.0] - 2020-01-22
@@ -9,0 +23,0 @@

package.json

 {
   "name": "electron-installer-redhat",
   "description": "Create a Red Hat package for your Electron app.",
-  "version": "3.0.0",
+  "version": "3.1.0",
   "license": "MIT",
@@ -36,5 +36,6 @@ "author": {
   "dependencies": {
+    "@malept/cross-spawn-promise": "^1.0.0",
     "debug": "^4.1.1",
-    "electron-installer-common": "^0.10.0",
-    "fs-extra": "^8.1.0",
+    "electron-installer-common": "^0.10.2",
+    "fs-extra": "^9.0.0",
     "lodash": "^4.17.15",
@@ -47,3 +48,3 @@ "word-wrap": "^1.2.3",
     "chai-as-promised": "^7.1.1",
-    "eslint": "^6.8.0",
+    "eslint": "^7.2.0",
     "eslint-config-standard": "^14.1.0",
@@ -54,7 +55,16 @@ "eslint-plugin-import": "^2.20.0",
     "eslint-plugin-standard": "^4.0.1",
-    "mocha": "^7.0.0",
-    "promise-retry": "^1.1.1",
-    "sinon": "^8.1.0",
-    "tmp-promise": "^2.0.2"
+    "husky": "^4.2.5",
+    "lint-staged": "^10.2.7",
+    "mocha": "^8.0.1",
+    "promise-retry": "^2.0.1",
+    "proxyquire": "^2.1.3",
+    "sinon": "^9.0.0",
+    "tmp-promise": "^3.0.2"
+  },
+  "husky": {
+    "pre-commit": "lint-staged"
+  },
+  "lint-staged": {
+    "*.js": "eslint --fix"
   }
 }

src/cli.js

@@ -28,2 +28,6 @@ #!/usr/bin/env node
   })
+  .options('options.requires', { array: true, hidden: true })
+  .options('options.execArguments', { array: true, hidden: true })
+  .options('options.categories', { array: true, hidden: true })
+  .options('options.mimeType', { array: true, hidden: true })
   .example('$0 --src dist/app/ --dest dist/installer/ --arch i386', 'use metadata from `dist/app/`')
@@ -30,0 +34,0 @@ .example('$0 --src dist/app/ --dest dist/installer/ --config config.json', 'use metadata from `config.json`')

src/dependencies.js

 'use strict'
 
 const common = require('electron-installer-common')
+const _ = require('lodash')
 const spawn = require('./spawn')
@@ -8,2 +9,4 @@
   atspi: 'at-spi2-core',
+  drm: 'libdrm',
+  gbm: 'mesa-libgbm',
   gconf: 'GConf2',
@@ -20,2 +23,3 @@ glib2: 'glib2',
   uuid: '(libuuid or libuuid1)',
+  xcbDri3: 'libxcb',
   xdgUtils: 'xdg-utils',
@@ -31,6 +35,10 @@ xss: 'libXScrnSaver',
 async function rpmSupportsBooleanDependencies (logger) {
-  const output = await spawn('rpmbuild', ['--version'], logger)
-  return rpmVersionSupportsBooleanDependencies(output.trim().split(' ')[2])
+  return rpmVersionSupportsBooleanDependencies(await getRpmVersion(logger))
 }
 
+async function getRpmVersion (logger) {
+  const versionOutput = await spawn('rpmbuild', ['--version'], logger)
+  return _.last(versionOutput.trim().split(' '))
+}
+
 /**
@@ -72,2 +80,3 @@ * Determine whether the RPM version string has support for boolean dependencies (>= 4.13.0).
   },
+  getRpmVersion,
   rpmSupportsBooleanDependencies,
@@ -74,0 +83,0 @@ rpmVersionSupportsBooleanDependencies,

src/installer.js

@@ -57,13 +57,2 @@ 'use strict'
   /**
-   * Creates macros file used by `rpmbuild`.
-   */
-  createMacros () {
-    const src = path.resolve(__dirname, '../resources/macros.ejs')
-    const dest = path.join(process.env.HOME, '.rpmmacros')
-    this.options.logger(`Creating macros file at ${dest}`)
-
-    return common.wrapError('creating macros file', async () => common.createTemplatedFile(src, dest, { dir: this.stagingDir, ...this.options }))
-  }
-
-  /**
    * Package everything using `rpmbuild`.
@@ -74,3 +63,3 @@ */
 
-    const output = await spawn('rpmbuild', ['-bb', this.specPath, '--target', this.options.arch], this.options.logger)
+    const output = await spawn('rpmbuild', ['-bb', this.specPath, '--target', this.options.arch, '--define', `_topdir ${this.stagingDir}`], this.options.logger)
     this.options.logger(`rpmbuild output: ${output}`)
@@ -181,3 +170,2 @@ }
   await installer.createStagingDir()
-  await installer.createMacros()
   await installer.createContents()
@@ -184,0 +172,0 @@ await installer.createPackage()

src/spawn.js

 'use strict'
 
-const { spawn } = require('electron-installer-common')
+const { spawn } = require('@malept/cross-spawn-promise')
 const which = require('which')
@@ -5,0 +5,0 @@

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

New author

Supply chain risk

A new npm collaborator published a version of the package for the first time. New collaborators are usually benign additions to a project, but do indicate a change to the security surface area of a package.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Environment variable access

Supply chain risk

Package accesses environment variables, which may be a sign of credential stuffing or data theft.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

442669

increased by0.13%

Lines of code

293

increased by0.69%

Number of low supply chain risk alerts

1

decreased by-50%

Worsened metrics

Dependency count

7

increased by16.67%

Dev dependency count

15

increased by25%

Number of package files

13

decreased by-7.14%

Number of medium supply chain risk alerts

1

increased byInfinity%

Dependency changes

• + Added@malept/cross-spawn-promise@^1.0.0

• - Removedfs-extra@8.1.0(transitive)

• - Removedjsonfile@4.0.0(transitive)

• - Removeduniversalify@0.1.2(transitive)

• Updatedelectron-installer-common@^0.10.2

• Updatedfs-extra@^9.0.0