electron-osx-sign - npm Package Compare versions

Comparing version 0.4.0-beta2 to 0.4.0-beta3

index.d.ts

@@ -6,2 +6,3 @@ interface BaseSignOptions {
   keychain?: string;
+  version?: string;
 }
@@ -16,2 +17,3 @@
 export function sign(opts: SignOptions, callback: (error: Error) => void): void;
+export function signAsync(opts: SignOptions): Promise<any>;
 
@@ -24,1 +26,2 @@ interface FlatOptions extends BaseSignOptions {
 export function flat(opts: FlatOptions, callback: (error: Error) => void): void;
+export function flatAsync(opts: FlatOptions): Promise<any>;

index.js

@@ -69,3 +69,3 @@ 'use strict'
           location = line.indexOf(identity)
-          if (location > -1) {
+          if (location >= 0) {
             opts.identity = line.substring(line.indexOf('"') + 1, line.lastIndexOf('"'))
@@ -158,3 +158,3 @@ break
         // Only automate when app sandbox enabled
-        return Promise.resolve()
+        return
       }
@@ -173,3 +173,2 @@
             debuglog('`ElectronTeamID` found in `Info.plist`: ' + appInfo.ElectronTeamID)
-            return Promise.resolve()
           }
@@ -191,3 +190,2 @@ })
             debuglog('`com.apple.security.application-groups` found in entitlements file: ' + appGroup)
-            return Promise.resolve()
           }
@@ -328,3 +326,3 @@ })
                   default:
-                    if (path.extname(filePath).indexOf(' ') > -1) {
+                    if (path.extname(filePath).indexOf(' ') >= 0) {
                       // Still consider the file as binary if extension seems invalid
@@ -434,3 +432,2 @@ return getFilePathIfBinaryAsync(filePath)
                 debuglog('Entitlements:\n' + result)
-                return null
               })
@@ -508,4 +505,3 @@ }
       // Pre-sign operations
-      var promise = Promise.resolve()
-      if (opts.version ? compareVersion(opts.version, '1.1.1') >= 0 : true) {
+      if (opts.entitlements && (!opts.version || compareVersion(opts.version, '1.1.1') >= 0)) {
         // Enable Mac App Store sandboxing without using temporary-exception, introduced in Electron v1.1.1. Relates to electron#5601
@@ -516,9 +512,6 @@ if (opts['pre-auto-entitlements'] === false) {
           debuglog('Pre-sign operation enabled for entitlements automation with versions >= `1.1.1`; disable by setting `pre-auto-entitlements` to `false`.')
-          promise = promise.then(function () {
-            debuglog('Automating entitlement app group...')
-            return preAutoEntitlementAppGroupAsync(opts)
-          })
+          debuglog('Automating entitlement app group...')
+          return preAutoEntitlementAppGroupAsync(opts)
         }
       }
-      return promise
     })
@@ -538,3 +531,2 @@ .then(function () {
       debuglog('Application signed.')
-      return null
     })
@@ -578,3 +570,2 @@ }
       // Pre-flat operations
-      return null
     })
@@ -592,3 +583,2 @@ .then(function () {
       debuglog('Application flattened.')
-      return null
     })
@@ -595,0 +585,0 @@ }

package.json

 {
   "name": "electron-osx-sign",
-  "version": "0.4.0-beta2",
+  "version": "0.4.0-beta3",
   "description": "Code-signing for Electron-packed OS X apps.",
@@ -5,0 +5,0 @@ "main": "index.js",

README.md

@@ -301,6 +301,6 @@ # electron-osx-sign [![npm][npm_img]][npm_url] [![Build Status][travis_img]][travis_url]
 
-> electron-osx-sign@0.4.0-beta2 pretest electron-osx-sign
+> electron-osx-sign@0.4.0-beta3 pretest electron-osx-sign
 > rimraf test/work
 
-> electron-osx-sign@0.4.0-beta2 test electron-osx-sign
+> electron-osx-sign@0.4.0-beta3 test electron-osx-sign
 > standard && tape test
@@ -307,0 +307,0 @@

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Worsened metrics

Total package byte prevSize

51685

decreased by-0.27%

Lines of code

1075

decreased by-0.65%

No dependency changes