electron-osx-sign - npm Package Compare versions

Comparing version 0.4.12 to 0.4.13

package.json

 {
   "name": "electron-osx-sign",
-  "version": "0.4.12",
+  "version": "0.4.13",
   "description": "Codesign Electron macOS apps",
@@ -5,0 +5,0 @@ "main": "index.js",

README.md

@@ -1,2 +0,2 @@
-# electron-osx-sign [![npm][npm_img]][npm_url] [![Build Status][travis_img]][travis_url]
+# electron-osx-sign [![npm][npm_img]][npm_url] [![Build Status][circleci_img]][circleci_url]
 
@@ -377,12 +377,8 @@ Codesign Electron macOS apps
 
-As developer certificates are required for `codesign` on macOS, this module is difficult to be tested via online build services. If you wish to test out this module, enter:
+The project's configured to run automated tests on CircleCI.
 
-```
-npm test
-```
+If you wish to manually test the module, first comment out `opts.identity` in `test/basic.js` to enable auto discovery. Then run the command `npm test` from the dev directory.
 
-from the dev directory, and tell us if all tests should pass.
+When this command is run for the first time: `electron-download` will download macOS Electron releases defined in `test/config.json`, and save to `~/.electron/`, which might take up less than 1GB of disk space.
 
-When this command is fun for the first time: `electron-download` will download all major releases of Electron available for macOS from 0.24.0, and save to `~/.electron/`, which might take up less than 1GB of disk space.
-
 A successful testing should look something like:
@@ -393,6 +389,6 @@
 
-> electron-osx-sign@0.4.12 pretest electron-osx-sign
+> electron-osx-sign@0.4.13 pretest electron-osx-sign
 > rimraf test/work
 
-> electron-osx-sign@0.4.12 test electron-osx-sign
+> electron-osx-sign@0.4.13 test electron-osx-sign
 > standard && tape test
@@ -404,65 +400,27 @@
 # setup
-# defaults-test:v0.29.2-darwin-x64
+# defaults-test:v7.0.0-beta.3-darwin-x64
 ok 1 app signed
-# defaults-test:v0.30.8-darwin-x64
+# defaults-test:v7.0.0-beta.3-mas-x64
 ok 2 app signed
-# defaults-test:v0.31.2-darwin-x64
+# defaults-test:v6.0.3-darwin-x64
 ok 3 app signed
-# defaults-test:v0.32.3-darwin-x64
+# defaults-test:v6.0.3-mas-x64
 ok 4 app signed
-# defaults-test:v0.33.9-darwin-x64
+# defaults-test:v5.0.10-darwin-x64
 ok 5 app signed
-# defaults-test:v0.34.5-darwin-x64
+# defaults-test:v5.0.10-mas-x64
 ok 6 app signed
-# defaults-test:v0.34.5-mas-x64
+# defaults-test:v4.2.9-darwin-x64
 ok 7 app signed
-# defaults-test:v0.35.6-darwin-x64
+# defaults-test:v4.2.9-mas-x64
 ok 8 app signed
-# defaults-test:v0.35.6-mas-x64
+# defaults-test:v3.1.2-darwin-x64
 ok 9 app signed
-# defaults-test:v0.36.12-darwin-x64
+# defaults-test:v3.1.2-mas-x64
 ok 10 app signed
-# defaults-test:v0.36.12-mas-x64
-ok 11 app signed
-# defaults-test:v0.37.8-darwin-x64
-ok 12 app signed
-# defaults-test:v0.37.8-mas-x64
-ok 13 app signed
-# defaults-test:v1.0.2-darwin-x64
-ok 14 app signed
-# defaults-test:v1.0.2-mas-x64
-ok 15 app signed
-# defaults-test:v1.1.3-darwin-x64
-ok 16 app signed
-# defaults-test:v1.1.3-mas-x64
-ok 17 app signed
-# defaults-test:v1.2.8-darwin-x64
-ok 18 app signed
-# defaults-test:v1.2.8-mas-x64
-ok 19 app signed
-# defaults-test:v1.3.7-darwin-x64
-ok 20 app signed
-# defaults-test:v1.3.7-mas-x64
-ok 21 app signed
-# defaults-test:v1.4.15-darwin-x64
-ok 22 app signed
-# defaults-test:v1.4.15-mas-x64
-ok 23 app signed
-# defaults-test:v1.6.17-darwin-x64
-ok 24 app signed
-# defaults-test:v1.6.17-mas-x64
-ok 25 app signed
-# defaults-test:v1.7.12-darwin-x64
-ok 26 app signed
-# defaults-test:v1.7.12-mas-x64
-ok 27 app signed
-# defaults-test:v1.8.3-darwin-x64
-ok 28 app signed
-# defaults-test:v1.8.3-mas-x64
-ok 29 app signed
 # teardown
 
-1..29
-# tests 29
-# pass  29
+1..10
+# tests 10
+# pass  10
 
@@ -484,3 +442,3 @@ # ok
 [npm_url]: https://npmjs.org/package/electron-osx-sign
-[travis_img]: https://travis-ci.org/electron-userland/electron-osx-sign.svg?branch=master
-[travis_url]: https://travis-ci.org/electron-userland/electron-osx-sign
+[circleci_img]: https://img.shields.io/circleci/build/github/electron/electron-osx-sign
+[circleci_url]: https://circleci.com/gh/electron/electron-osx-sign

sign.js

@@ -95,3 +95,3 @@ /**
       opts['strict-verify'] !== false &&
-      compareVersion(osRelease, '15.0.0') >= 0 // Only pass strict flag in El Capitan and later
+      compareVersion(osRelease, '15.0.0') >= 0 // Strict flag since darwin 15.0.0 --> OS X 10.11.0 El Capitan
         ? ['--strict' +
@@ -159,2 +159,4 @@ (opts['strict-verify']
         args.push('--timestamp=' + opts.timestamp)
+      } else {
+        args.push('--timestamp')
       }
@@ -164,3 +166,3 @@ const optionsArguments = []
       if (opts.hardenedRuntime || opts['hardened-runtime']) {
-        // 17.7.0 === 10.13.6
+        // Hardened runtime since darwin 17.7.0 --> macOS 10.13.6
         if (compareVersion(osRelease, '17.7.0') >= 0) {
@@ -167,0 +169,0 @@ optionsArguments.push('runtime')

test/basic.js

@@ -13,3 +13,5 @@ var sign = require('..')
     var opts = {
-      app: util.generateAppPath(release)
+      app: util.generateAppPath(release),
+      identity: 'codesign.electronjs.org',
+      'gatekeeper-assess': false
     } // test with no other options for self discovery
@@ -16,0 +18,0 @@

test/config.json

@@ -5,20 +5,8 @@ {
   "versions": [
-    "0.29.2",
-    "0.30.8",
-    "0.31.2",
-    "0.32.3",
-    "0.33.9",
-    "0.34.5",
-    "0.35.6",
-    "0.36.12",
-    "0.37.8",
-    "1.0.2",
-    "1.1.3",
-    "1.2.8",
-    "1.3.7",
-    "1.4.15",
-    "1.6.17",
-    "1.7.12",
-    "1.8.3"
+    "7.0.0-beta.3",
+    "6.0.3",
+    "5.0.10",
+    "4.2.9",
+    "3.1.2"
   ]
 }

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

New author

Supply chain risk

A new npm collaborator published a version of the package for the first time. New collaborators are usually benign additions to a project, but do indicate a change to the security surface area of a package.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

179724

increased by127.06%

Number of package files

29

increased by11.54%

Number of medium supply chain risk alerts

2

decreased by-33.33%

Worsened metrics

Lines of code

1572

decreased by-0.51%

Number of lines in readme file

441

decreased by-8.7%

No dependency changes