electron-osx-sign - npm Package Compare versions

Comparing version 0.4.14 to 0.4.15

bin/electron-osx-sign-usage.txt

@@ -73,2 +73,5 @@
 
+  --signature-size=size
+    Signature size. Default to none.
+
   --strict-verify, --strict-verify=options, --no-strict-verify
@@ -75,0 +78,0 @@ Flag to enable/disable ``--strict'' flag when verifying the signed application bundle.

bin/electron-osx-sign.js

@@ -9,2 +9,5 @@ #!/usr/bin/env node
   ],
+  'number': [
+    'signature-size'
+  ],
   'boolean': [
@@ -11,0 +14,0 @@ 'help',

index.d.ts

@@ -14,2 +14,4 @@ declare module "electron-osx-sign" {
     'gatekeeper-assess'?: boolean;
+    hardenedRuntime?: boolean;
+    'identity-validation'?: boolean;
     ignore?: string;
@@ -20,5 +22,5 @@ 'pre-auto-entitlements'?: boolean;
     'requirements'?: string;
+    'signature-size'?: number;
     'type'?: string;
     version?: string;
-    'identity-validation'?: boolean;
   }
@@ -31,2 +33,3 @@
   interface FlatOptions extends BaseSignOptions {
+    'identity-validation'?: boolean;
     install?: string;
@@ -33,0 +36,0 @@ pkg?: string;

package.json

 {
   "name": "electron-osx-sign",
-  "version": "0.4.14",
+  "version": "0.4.15",
   "description": "Codesign Electron macOS apps",
@@ -5,0 +5,0 @@ "main": "index.js",

README.md

@@ -227,3 +227,3 @@ # electron-osx-sign [![npm][npm_img]][npm_url] [![Build Status][circleci_img]][circleci_url]
 
-**To be deprecated, see `signature-flags`.** 
+**To be deprecated, see `signature-flags`.**
 Restrict dyld loading. See doc about this [code signature flag](https://developer.apple.com/documentation/security/seccodesignatureflags/kseccodesignaturerestrict?language=objc) for more details. Disabled by default.
@@ -234,2 +234,5 @@
 
+`signature-size` - *Number*
+Provide a value to be passed to `codesign` along with the `--signature-size` flag, to work around the *signature too large to embed* issue. A value of `12000` should do it - see the [FAQ](https://github.com/electron/electron-osx-sign/wiki/FAQ) for details. Default to `undefined`.
+
 `strict-verify` - *Boolean|String|Array.<String>*
@@ -394,6 +397,6 @@
 
-> electron-osx-sign@0.4.14 pretest electron-osx-sign
+> electron-osx-sign@0.4.15 pretest electron-osx-sign
 > rimraf test/work
 
-> electron-osx-sign@0.4.14 test electron-osx-sign
+> electron-osx-sign@0.4.15 test electron-osx-sign
 > standard && tape test
@@ -400,0 +403,0 @@

sign.js

@@ -161,2 +161,9 @@ /**
       }
+      if (opts['signature-size']) {
+        if (Number.isInteger(opts['signature-size']) && opts['signature-size'] > 0) {
+          args.push('--signature-size', opts['signature-size'])
+        } else {
+          debugwarn(`Invalid value provided for --signature-size (${opts['signature-size']}). Must be a positive integer.`)
+        }
+      }
 
@@ -163,0 +170,0 @@ let optionsArguments = []

util-provisioning-profiles.js

@@ -57,10 +57,17 @@ /**
  * @param {string} filePath - Path to provisioning profile.
+ * @param {string} keychain - Keychain to use when unlocking provisioning profile.
  * @returns {Promise} Promise.
  */
-var getProvisioningProfileAsync = module.exports.getProvisioningProfileAsync = function (filePath) {
-  return execFileAsync('security', [
+var getProvisioningProfileAsync = module.exports.getProvisioningProfileAsync = function (filePath, keychain = null) {
+  var securityArgs = [
     'cms',
     '-D', // Decode a CMS message
     '-i', filePath // Use infile as source of data
-  ])
+  ]
+
+  if (keychain) {
+    securityArgs.push('-k', keychain)
+  }
+
+  return execFileAsync('security', securityArgs)
     .then(function (result) {
@@ -148,3 +155,3 @@ var provisioningProfile = new ProvisioningProfile(filePath, plist.parse(result))
     } else {
-      return getProvisioningProfileAsync(opts['provisioning-profile'])
+      return getProvisioningProfileAsync(opts['provisioning-profile'], opts['keychain'])
         .then(function (provisioningProfile) {
@@ -151,0 +158,0 @@ opts['provisioning-profile'] = provisioningProfile

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Number of lines in readme file

448

increased by0.67%

Number of medium supply chain risk alerts

1

decreased by-50%

Worsened metrics

Total package byte prevSize

150717

decreased by-16.64%

Number of package files

20

decreased by-31.03%

Lines of code

1223

decreased by-22.89%

No dependency changes