electron-osx-sign - npm Package Compare versions

Comparing version 0.4.15 to 0.4.16

package.json

 {
   "name": "electron-osx-sign",
-  "version": "0.4.15",
+  "version": "0.4.16",
   "description": "Codesign Electron macOS apps",
@@ -5,0 +5,0 @@ "main": "index.js",

sign.js

@@ -201,2 +201,12 @@ /**
       var promise
+      /**
+       * Sort the child paths by how deep they are in the file tree.  Some arcane apple
+       * logic expects the deeper files to be signed first otherwise strange errors get
+       * thrown our way
+       */
+      childPaths = childPaths.sort((a, b) => {
+        const aDepth = a.split(path.sep).length
+        const bDepth = b.split(path.sep).length
+        return bDepth - aDepth
+      })
       if (opts.entitlements) {
@@ -203,0 +213,0 @@ // Sign with entitlements

util.js

@@ -224,10 +224,2 @@ /**
                 switch (path.extname(filePath)) {
-                  case '': // Binary
-                    if (path.basename(filePath)[0] !== '.') {
-                      return getFilePathIfBinaryAsync(filePath)
-                    } // Else reject hidden file
-                    break
-                  case '.dylib': // Dynamic library
-                  case '.node': // Native node addon
-                    return filePath
                   case '.cstemp': // Temporary file generated from past codesign
@@ -238,6 +230,3 @@ debuglog('Removing... ' + filePath)
                   default:
-                    if (path.extname(filePath).indexOf(' ') >= 0) {
-                      // Still consider the file as binary if extension seems invalid
-                      return getFilePathIfBinaryAsync(filePath)
-                    }
+                    return getFilePathIfBinaryAsync(filePath)
                 }
@@ -244,0 +233,0 @@ } else if (stat.isDirectory() && !stat.isSymbolicLink()) {

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Worsened metrics

Total package byte prevSize

70957

decreased by-52.92%

Number of package files

19

decreased by-5%

Lines of code

1222

decreased by-0.08%

No dependency changes