electron-panel - npm Package Compare versions

Comparing version 1.2.0 to 1.2.1

CHANGELOG.md

 ## CHANGELOG
 
+### v1.2.1
+
+  - Prevent load the panel frame more than once when its src changed.
+
 ### v1.2.0
@@ -4,0 +8,0 @@

lib/renderer/panel-frame.js

@@ -192,2 +192,3 @@ 'use strict';
     this._inited = false;
+    this._loaded = false;
   }
@@ -242,9 +243,16 @@
     let src = this.getAttribute('src');
-    if ( src !== null ) {
-      console.warn('Can not change the src if panel is loaded');
-      return;
-    }
 
     if ( src !== val ) {
+      if ( this._loaded ) {
+        console.warn('Can not change the src if panel is loaded');
+        return;
+      }
+
       this.setAttribute('src', val);
+
+      // skip load the panel if it is not inited.
+      if ( !this._inited ) {
+        return;
+      }
+
       this._load(val);
@@ -463,2 +471,3 @@ }
       this._apply(panelProto);
+      this._loaded = true;
 
@@ -465,0 +474,0 @@ // add it to panel list

package.json

 {
   "name": "electron-panel",
-  "version": "1.2.0",
+  "version": "1.2.1",
   "description": "Manipulate panels in window for Electron",
@@ -5,0 +5,0 @@ "main": "index.js",

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

54545

increased by0.46%

Lines of code

1541

increased by0.39%

No dependency changes