embeds - npm Package Compare versions

Comparing version 2.11.5 to 2.11.6

dist/types/facebook.js

@@ -56,3 +56,3 @@ 'use strict';
   var blockquoteElm = elm.getElementsByTagName('blockquote')[0];
-  var date = blockquoteElm ? (0, _lodash2.default)(blockquoteElm.childNodes).data.replace(' on ', '') : '';
+  var date = blockquoteElm ? (((0, _lodash2.default)(blockquoteElm.childNodes) || {}).data || '').replace(' on ', '') : '';
   var user = {
@@ -59,0 +59,0 @@ url: aElms[1] && aElms[1].getAttribute('href') || '',

lib/types/facebook.js

@@ -31,3 +31,3 @@ const type = 'facebook';
   const blockquoteElm = elm.getElementsByTagName('blockquote')[0];
-  const date = blockquoteElm ? last(blockquoteElm.childNodes).data.replace(' on ', '') : '';
+  const date = blockquoteElm ? ((last(blockquoteElm.childNodes) || {}).data || '').replace(' on ', '') : '';
   const user = {
@@ -34,0 +34,0 @@ url: aElms[1] && aElms[1].getAttribute('href') || '',

package.json

 {
   "name": "embeds",
-  "version": "2.11.5",
+  "version": "2.11.6",
   "description": "Parse & render embeds",
@@ -5,0 +5,0 @@ "main": "dist/index.js",

test/fixtures/index.js

@@ -10,2 +10,4 @@ const fs = require('fs');
   facebookVideo: fs.readFileSync(`${__dirname}/facebook-video.html`, 'utf8').trim(),
+  facebookVideoInvalid: fs.readFileSync(`${__dirname}/facebook-video-invalid.html`, 'utf8').trim(),
+  facebookVideoInvalid2: fs.readFileSync(`${__dirname}/facebook-video-invalid-2.html`, 'utf8').trim(),
   facebookPhoto: fs.readFileSync(`${__dirname}/facebook-photo.html`, 'utf8').trim(),
@@ -12,0 +14,0 @@ facebookEmbedCode: fs.readFileSync(`${__dirname}/facebook-embed-code.html`, 'utf8').trim(),

test/html-parse-test.js

@@ -509,2 +509,38 @@ import test from './tape-wrapper';
 
+test('parse() facebook - video invalid', t => {
+  const input = fixtures.facebookVideoInvalid;
+  const actual = parse(input);
+  const expected = {
+    embedAs: 'video',
+    type: 'facebook',
+    url: 'https://www.facebook.com/MicMedia/videos/1060315987324524/',
+    headline: '',
+    date: '',
+    user: {
+      url: '',
+      name: ''
+    },
+    text: []
+  };
+  t.deepEqual(actual, expected);
+});
+
+test('parse() facebook - video invalid 2', t => {
+  const input = fixtures.facebookVideoInvalid2;
+  const actual = parse(input);
+  const expected = {
+    embedAs: 'video',
+    type: 'facebook',
+    url: 'https://www.facebook.com/MicMedia/videos/1060315987324524/',
+    headline: '',
+    date: '1',
+    user: {
+      url: '',
+      name: ''
+    },
+    text: []
+  };
+  t.deepEqual(actual, expected);
+});
+
 test('parse() vine', t => {
@@ -511,0 +547,0 @@ const input = '<iframe src="https://vine.co/v/bjHh0zHdgZT/embed/simple" width="600" height="600" frameborder="0"></iframe><script src="https://platform.vine.co/static/scripts/embed.js"></script>';

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

138159

increased by1.11%

Number of package files

68

increased by1.49%

Lines of code

3377

increased by1.08%

No dependency changes