ember-cli-babel - npm Package Compare versions

Comparing version 7.4.2 to 7.4.3

CHANGELOG.md

 # Changelog
 
+## v7.4.3 (2019-02-19)
+
+#### :bug: Bug Fix
+* [#265](https://github.com/babel/ember-cli-babel/pull/265) Fix `@ember/string` detection ([@locks](https://github.com/locks))
+
+#### :house: Internal
+* [#268](https://github.com/babel/ember-cli-babel/pull/268) Update babel-plugin-debug-macros ([@jrjohnson](https://github.com/jrjohnson))
+
+#### Committers: 2
+- Jonathan Johnson ([@jrjohnson](https://github.com/jrjohnson))
+- Ricardo Mendes ([@locks](https://github.com/locks))
+
 ## v7.4.2 (2019-02-12)
@@ -4,0 +16,0 @@

index.js

@@ -432,3 +432,3 @@ 'use strict';
 
-    if (this._emberStringDependencyPresent()) {
+    if (this._shouldBlacklistEmberString()) {
       blacklist['@ember/string'] = [
@@ -449,9 +449,20 @@ 'fmt', 'loc', 'w',
 
-  _emberStringDependencyPresent() {
-    if (this.project.name && this.project.name() === '@ember/string') {
-      return true;
-    }
+  _isProjectName(dependency) {
+    return this.project.name && this.project.name() === dependency;
+  },
 
-    let checker = new VersionChecker(this.parent).for('@ember/string', 'npm');
+  _isTransitiveDependency(dependency) {
+    return (
+      !(dependency in this.parent.dependencies()) &&
+      !(dependency in this.project.dependencies())
+    )
+  },
 
+  _shouldBlacklistEmberString() {
+    let packageName = '@ember/string';
+    if (this._isProjectName(packageName)) { return true; }
+    if (this._isTransitiveDependency(packageName)) { return false; }
+
+    let checker = new VersionChecker(this.parent).for(packageName, 'npm');
+
     return checker.exists();
@@ -461,15 +472,8 @@ },
   _shouldBlacklistJQuery() {
-    if (this.project.name && this.project.name() === '@ember/jquery') {
-      return true;
-    }
+    let packageName = '@ember/jquery';
+    if (this._isProjectName(packageName)) { return true; }
+    if (this._isTransitiveDependency(packageName)) { return false; }
 
-    if (
-      !('@ember/jquery' in this.parent.dependencies()) &&
-      !('@ember/jquery' in this.project.dependencies())
-    ) {
-      return false;
-    }
+    let checker = new VersionChecker(this.parent).for(packageName, 'npm');
 
-    let checker = new VersionChecker(this.parent).for('@ember/jquery', 'npm');
-
     return checker.gte('0.6.0');
@@ -476,0 +480,0 @@ },

package.json

 {
   "name": "ember-cli-babel",
-  "version": "7.4.2",
+  "version": "7.4.3",
   "description": "Ember CLI addon for Babel",
@@ -48,3 +48,3 @@ "keywords": [
     "amd-name-resolver": "^1.2.1",
-    "babel-plugin-debug-macros": "^0.2.0-beta.6",
+    "babel-plugin-debug-macros": "^0.3.0",
     "babel-plugin-ember-modules-api-polyfill": "^2.6.0",
@@ -51,0 +51,0 @@ "babel-plugin-module-resolver": "^3.1.1",

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

60926

increased by1.17%

Lines of code

434

increased by0.7%

Dependency changes

• + Addedbabel-plugin-debug-macros@0.3.4(transitive)

• - Removedbabel-plugin-debug-macros@0.2.0(transitive)

• Updatedbabel-plugin-debug-macros@^0.3.0