ember-test-helpers - npm Package Compare versions

Comparing version 0.7.0-beta.7 to 0.7.0-beta.8

addon-test-support/index.js

@@ -13,4 +13,1 @@ // TODO: deprecate these once new API is rolled out
 export { default as settled } from './settled';
-
-import Ember from 'ember';
-Ember.testing = true;

addon-test-support/legacy-0-6-x/abstract-test-module.js

@@ -26,2 +26,3 @@ import { run } from '@ember/runloop';
   setup(assert) {
+    Ember.testing = true;
     return this.invokeSteps(this.setupSteps, this, assert).then(() => {
@@ -41,2 +42,5 @@ this.contextualizeCallbacks();
         this.cachedCalls = null;
+      })
+      .finally(function() {
+        Ember.testing = false;
       });
@@ -105,2 +109,9 @@ }
   setupTestElements() {
+    let testElementContainer = document.querySelector('#ember-testing-container');
+    if (!testElementContainer) {
+      testElementContainer = document.createElement('div');
+      testElementContainer.setAttribute('id', 'ember-testing-container');
+      document.body.appendChild(testElementContainer);
+    }
+
     let testEl = document.querySelector('#ember-testing');
@@ -111,6 +122,6 @@ if (!testEl) {
 
-      document.body.appendChild(element);
+      testElementContainer.appendChild(element);
       this.fixtureResetValue = '';
     } else {
-      this.fixtureResetValue = testEl.innerHTML;
+      this.fixtureResetValue = testElementContainer.innerHTML;
     }
@@ -174,3 +185,3 @@ }
   teardownTestElements() {
-    document.getElementById('ember-testing').innerHTML = this.fixtureResetValue;
+    document.getElementById('ember-testing-container').innerHTML = this.fixtureResetValue;
 
@@ -177,0 +188,0 @@ // Ember 2.0.0 removed Ember.View as public API, so only do this when

addon-test-support/setup-context.js

@@ -6,2 +6,3 @@ import { run } from '@ember/runloop';
 import { _setupAJAXHooks } from './settled';
+import Ember from 'ember';
 
@@ -32,2 +33,3 @@ let __test_context__;
 export default function(context, options = {}) {
+  Ember.testing = true;
   setContext(context);
@@ -34,0 +36,0 @@

addon-test-support/setup-rendering-context.js

@@ -43,3 +43,3 @@ import { guidFor } from '@ember/object/internals';
   let testElementContainer = document.getElementById('ember-testing-container');
-  let fixtureResetValue = testElementContainer.outerHTML;
+  let fixtureResetValue = testElementContainer.innerHTML;
 
@@ -46,0 +46,0 @@ RENDERING_CLEANUP[guid] = [

addon-test-support/teardown-context.js

 import { run } from '@ember/runloop';
 import { _teardownPromiseListeners } from './ext/rsvp';
 import { _teardownAJAXHooks } from './settled';
+import Ember from 'ember';
 
@@ -12,2 +13,3 @@ export default function(context) {
   run(owner, 'destroy');
+  Ember.testing = false;
 }

CHANGELOG.md

 # Change Log
 
+## [v0.7.0-beta.8](https://github.com/emberjs/ember-test-helpers/tree/v0.7.0-beta.8) (2017-10-20)
+[Full Changelog](https://github.com/emberjs/ember-test-helpers/compare/v0.7.0-beta.7...v0.7.0-beta.8)
+
+**Fixed bugs:**
+
+- New `setupRenderingTest` seems to recreate the `\#ember-testing-container` for every test [\#228](https://github.com/emberjs/ember-test-helpers/issues/228)
+- Ensure ember-testing-container is reset properly. [\#229](https://github.com/emberjs/ember-test-helpers/pull/229) ([rwjblue](https://github.com/rwjblue))
+- Set Ember.testing only while actually running a test. [\#227](https://github.com/emberjs/ember-test-helpers/pull/227) ([rwjblue](https://github.com/rwjblue))
+
+**Closed issues:**
+
+- TypeError: Cannot read property 'resolveRegistration' of undefined [\#230](https://github.com/emberjs/ember-test-helpers/issues/230)
+
 ## [v0.7.0-beta.7](https://github.com/emberjs/ember-test-helpers/tree/v0.7.0-beta.7) (2017-10-17)
 [Full Changelog](https://github.com/emberjs/ember-test-helpers/compare/v0.7.0-beta.6...v0.7.0-beta.7)
 
-**Merged pull requests:**
+**Fixed bugs:**
 
@@ -8,0 +21,0 @@ - Ensure testing elements are properly reset/cleared. [\#226](https://github.com/emberjs/ember-test-helpers/pull/226) ([rwjblue](https://github.com/rwjblue))

package.json

 {
   "name": "ember-test-helpers",
-  "version": "0.7.0-beta.7",
+  "version": "0.7.0-beta.8",
   "description": "Helpers for testing Ember.js applications",
@@ -5,0 +5,0 @@ "keywords": [

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

327292

increased by0.41%

Lines of code

1478

increased by0.82%

No dependency changes