ember-welcome-page - npm Package Compare versions

Comparing version 1.0.1 to 1.0.2

index.js

@@ -7,5 +7,6 @@ /* jshint node: true */
 var path = require('path');
+var VersionChecker = require('ember-cli-version-checker');
 var walkSync = require('walk-sync');
 
-function getWelcomePageHTML(baseURL) {
+function getWelcomePageHTML(baseURL, version) {
   var lodash = require('lodash');
@@ -16,3 +17,3 @@ var fileName = path.join(__dirname, 'vendor', 'welcome.html');
 
-  return compiled({ baseURL: baseURL });
+  return compiled({ baseURL: baseURL, version: version });
 }
@@ -28,2 +29,5 @@
 
+    var checker = new VersionChecker(this);
+    this.guidesVersion = this.massageVersionNumber(checker.for('ember', 'bower').version);
+
     this.jsExt = this.app.registry.extensionsForType('js');
@@ -40,3 +44,3 @@ this.templateExt = this.app.registry.extensionsForType('template');
 
-    var welcomePageHTML = getWelcomePageHTML(options.baseURL);
+    var welcomePageHTML = getWelcomePageHTML(options.baseURL, this.guidesVersion);
 
@@ -107,3 +111,7 @@ app.get('/ember-getting-started-image.png', function (req, res, next) {
     return !hasTemplates && !hasRoutes && !hasRouterMapContents;
+  },
+
+  massageVersionNumber: function(version) {
+    return version.replace(/(\d).(\d).\d/, '$1.$2.0');
   }
 };

node-tests/unit/welcome-checks-test.js

@@ -38,1 +38,15 @@ 'use strict';
 });
+
+describe('appropriate version number is used', function() {
+
+  it('when we find a 2.x.0 version, we leave it unchanged', function() {
+    var result = WelcomeCheck.massageVersionNumber('2.5.0');
+    assert.equal('2.5.0', result, 'version number was changed');
+  });
+
+  it('when we find a 2.x.1 version, we change it to 2.x.0', function() {
+    var result = WelcomeCheck.massageVersionNumber('2.5.1');
+    assert.equal('2.5.0', result, 'version number was changed');
+  });
+
+});

package.json

 {
   "name": "ember-welcome-page",
-  "version": "1.0.1",
+  "version": "1.0.2",
   "description": "Welcome page for Ember-CLI",
@@ -15,3 +15,3 @@ "directories": {
   },
-  "repository": "",
+  "repository": "https://github.com/ember-cli/ember-welcome-page",
   "engines": {
@@ -54,2 +54,3 @@ "node": ">= 0.10.0"
     "ember-cli-htmlbars": "^1.0.1",
+    "ember-cli-version-checker": "1.1.6",
     "exists-sync": "0.0.3",
@@ -56,0 +57,0 @@ "lodash": "^4.7.0",

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

No repository

Supply chain risk

Package does not have a linked source code repository. Without this field, a package will have no reference to the location of the source code use to generate the package.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

New author

Supply chain risk

A new npm collaborator published a version of the package for the first time. New collaborators are usually benign additions to a project, but do indicate a change to the security surface area of a package.

Found 1 instance in 1 package

No repository

Supply chain risk

Package does not have a linked source code repository. Without this field, a package will have no reference to the location of the source code use to generate the package.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

134723

increased by59.47%

Number of package files

31

increased by82.35%

Lines of code

219

increased by7.88%

Number of medium supply chain risk alerts

0

decreased by-100%

Worsened metrics

Dependency count

8

increased by14.29%

Dependency changes

• + Addedember-cli-version-checker@1.1.6

• + Addedember-cli-version-checker@1.1.6(transitive)

• + Addedsemver@4.3.6(transitive)

• - Removedember-cli-version-checker@1.3.1(transitive)

• - Removedsemver@5.7.2(transitive)