engine.io-client - npm Package Compare versions

Comparing version 0.2.1 to 0.2.2

dist/engine.io-dev.js

@@ -130,3 +130,3 @@ (function(){var global = this;
 
-exports.version = '0.2.1';
+exports.version = '0.2.2';
 
@@ -1374,3 +1374,3 @@ /**
 var Polling = require('./polling')
-  , util = require('../util')
+  , util = require('../util');
 
@@ -1387,3 +1387,3 @@ /**
 
-var rNewline = /\n/g
+var rNewline = /\n/g;
 
@@ -1394,3 +1394,3 @@ /**
 
-var callbacks = global.___eio = [];
+var callbacks;
 
@@ -1419,4 +1419,12 @@ /**
 
+  // define global callbacks array if not present
+  // we do this here (lazily) to avoid unneeded global pollution
+  if (!callbacks) {
+    // we need to consider multiple engines in the same page
+    if (!global.___eio) global.___eio = [];
+    callbacks = global.___eio;
+  }
+
   // callback identifier
-  this.index = index++;
+  this.index = callbacks.length;
 
@@ -1430,3 +1438,3 @@ // add callback to jsonp global
   // append to query string
-  this.query.j = callbacks.length - 1;
+  this.query.j = this.index;
 };
@@ -1490,3 +1498,3 @@
 
-  var insertAt = document.getElementsByTagName('script')[0]
+  var insertAt = document.getElementsByTagName('script')[0];
   insertAt.parentNode.insertBefore(script, insertAt);
@@ -1513,3 +1521,3 @@ this.script = script;
 JSONPPolling.prototype.doWrite = function (data, fn) {
-  var self = this
+  var self = this;
 
@@ -1573,3 +1581,3 @@ if (!this.form) {
   if (this.iframe.attachEvent) {
-    iframe.onreadystatechange = function () {
+    this.iframe.onreadystatechange = function(){
       if (self.iframe.readyState == 'complete') {
@@ -2471,3 +2479,3 @@ complete();
 
-});if ("undefined" != typeof module) { module.exports = require('engine.io-client'); } else { eio = require('engine.io-client'); }
+});eio = require('engine.io-client');
 })();

dist/engine.io.js

@@ -9,3 +9,3 @@ (function(){var global = this;function debug(){return debug};function require(p, parent){ var path = require.resolve(p) , mod = require.modules[path]; if (!mod) throw new Error('failed to require "' + p + '" from ' + parent); if (!mod.exports) { mod.exports = {}; mod.call(mod.exports, mod, mod.exports, require.relative(path), global); } return mod.exports;}require.modules = {};require.resolve = function(path){ var orig = path , reg = path + '.js' , index = path + '/index.js'; return require.modules[reg] && reg || require.modules[index] && index || orig;};require.register = function(path, fn){ require.modules[path] = fn;};require.relative = function(parent) { return function(p){ if ('debug' == p) return debug; if ('.' != p.charAt(0)) return require(p); var path = parent.split('/') , segs = p.split('/'); path.pop(); for (var i = 0; i < segs.length; i++) { var seg = segs[i]; if ('..' == seg) path.pop(); else if ('.' != seg) path.push(seg); } return require(path.join('/'), parent); };};require.register("engine.io-client.js", function(module, exports, require, global){
 
-exports.version = '0.2.1';
+exports.version = '0.2.2';
 
@@ -1253,3 +1253,3 @@ /**
 var Polling = require('./polling')
-  , util = require('../util')
+  , util = require('../util');
 
@@ -1266,3 +1266,3 @@ /**
 
-var rNewline = /\n/g
+var rNewline = /\n/g;
 
@@ -1273,3 +1273,3 @@ /**
 
-var callbacks = global.___eio = [];
+var callbacks;
 
@@ -1298,4 +1298,12 @@ /**
 
+  // define global callbacks array if not present
+  // we do this here (lazily) to avoid unneeded global pollution
+  if (!callbacks) {
+    // we need to consider multiple engines in the same page
+    if (!global.___eio) global.___eio = [];
+    callbacks = global.___eio;
+  }
+
   // callback identifier
-  this.index = index++;
+  this.index = callbacks.length;
 
@@ -1309,3 +1317,3 @@ // add callback to jsonp global
   // append to query string
-  this.query.j = callbacks.length - 1;
+  this.query.j = this.index;
 };
@@ -1369,3 +1377,3 @@
 
-  var insertAt = document.getElementsByTagName('script')[0]
+  var insertAt = document.getElementsByTagName('script')[0];
   insertAt.parentNode.insertBefore(script, insertAt);
@@ -1392,3 +1400,3 @@ this.script = script;
 JSONPPolling.prototype.doWrite = function (data, fn) {
-  var self = this
+  var self = this;
 
@@ -1452,3 +1460,3 @@ if (!this.form) {
   if (this.iframe.attachEvent) {
-    iframe.onreadystatechange = function () {
+    this.iframe.onreadystatechange = function(){
       if (self.iframe.readyState == 'complete') {
@@ -2350,3 +2358,3 @@ complete();
 
-});if ("undefined" != typeof module) { module.exports = require('engine.io-client'); } else { eio = require('engine.io-client'); }
+});eio = require('engine.io-client');
 })();

History.md

 
+0.2.2 / 2012-08-26
+==================
+
+  * polling-jsonp: allow unneeded global leak (fixes #41)
+  * polling-jsonp: allow for multiple eio's in the same page
+
 0.2.1 / 2012-08-13
@@ -3,0 +9,0 @@ ==================

lib/engine.io-client.js

@@ -8,3 +8,3 @@
 
-exports.version = '0.2.1';
+exports.version = '0.2.2';
 
@@ -11,0 +11,0 @@ /**

lib/transports/polling-jsonp.js

@@ -7,3 +7,3 @@
 var Polling = require('./polling')
-  , util = require('../util')
+  , util = require('../util');
 
@@ -20,3 +20,3 @@ /**
 
-var rNewline = /\n/g
+var rNewline = /\n/g;
 
@@ -27,3 +27,3 @@ /**
 
-var callbacks = global.___eio = [];
+var callbacks;
 
@@ -52,4 +52,12 @@ /**
 
+  // define global callbacks array if not present
+  // we do this here (lazily) to avoid unneeded global pollution
+  if (!callbacks) {
+    // we need to consider multiple engines in the same page
+    if (!global.___eio) global.___eio = [];
+    callbacks = global.___eio;
+  }
+
   // callback identifier
-  this.index = index++;
+  this.index = callbacks.length;
 
@@ -63,3 +71,3 @@ // add callback to jsonp global
   // append to query string
-  this.query.j = callbacks.length - 1;
+  this.query.j = this.index;
 };
@@ -123,3 +131,3 @@
 
-  var insertAt = document.getElementsByTagName('script')[0]
+  var insertAt = document.getElementsByTagName('script')[0];
   insertAt.parentNode.insertBefore(script, insertAt);
@@ -146,3 +154,3 @@ this.script = script;
 JSONPPolling.prototype.doWrite = function (data, fn) {
-  var self = this
+  var self = this;
 
@@ -206,3 +214,3 @@ if (!this.form) {
   if (this.iframe.attachEvent) {
-    iframe.onreadystatechange = function () {
+    this.iframe.onreadystatechange = function(){
       if (self.iframe.readyState == 'complete') {
@@ -209,0 +217,0 @@ complete();

package.json

@@ -5,3 +5,3 @@ {
   , "main": "./lib/engine.io-client"
-  , "version": "0.2.1"
+  , "version": "0.2.2"
   , "contributors": [
@@ -8,0 +8,0 @@ { "name": "Guillermo Rauch", "email": "[e-mail]" }

No alert changes

Improved metrics

Total package byte prevSize

406396

increased by0.19%

Lines of code

13644

increased by0.15%

No dependency changes