engine.io - npm Package Compare versions

Comparing version 0.7.14 to 0.8.0

History.md

 
+0.8.0 / 2014-01-05
+==================
+
+ * package: bump `engine.io-client` to `0.8.0`
+ * test: fix syntax, remove globals
+
 0.7.14 / 2014-01-01
@@ -3,0 +9,0 @@ ===================

package.json

 {
     "name": "engine.io"
-  , "version": "0.7.14"
+  , "version": "0.8.0"
   , "description": "The realtime engine behind Socket.IO. Provides the foundation of a bidirectional connection between client and server"
@@ -27,3 +27,3 @@ , "main": "./lib/engine.io"
       , "superagent": "*"
-      , "engine.io-client": "0.7.14"
+      , "engine.io-client": "0.8.0"
       , "s": "*"
@@ -30,0 +30,0 @@ }

test/common.js

 
 /**
- * Expose `eio` global.
+ * Module dependencies.
  */
 
-global.eio = require('../index');
+var eio = require('..');
 
 /**
- * Expose client.
- */
-
-global.eioc = require('engine.io-client');
-
-/**
- * Expose `request` global.
- */
-
-global.request = require('superagent');
-
-/**
- * Expose `expect` global
- */
-
-global.expect = require('expect.js');
-
-/**
  * Listen shortcut that fires a callback on an epheemal port.
  */
 
-global.listen = function (opts, fn) {
+exports.listen = function (opts, fn) {
   if ('function' == typeof opts) {
@@ -36,3 +18,3 @@ fn = opts;
 
-  var e = global.eio.listen(null, opts, function () {
+  var e = eio.listen(null, opts, function () {
     fn(e.httpServer.address().port);
@@ -39,0 +21,0 @@ });

test/engine.io.js

@@ -1,2 +0,1 @@
-/*global eio,listen,request,expect*/
 
@@ -7,4 +6,8 @@ /**
 
-var net = require('net')
-  , http = require('http');
+var net = require('net');
+var eio = require('..');
+var listen = require('./common').listen;
+var expect = require('expect.js');
+var request = require('superagent');
+var http = require('http');
 
@@ -11,0 +14,0 @@ /**

test/jsonp.js

@@ -1,4 +0,11 @@
-/*global eio,eioc,listen,request,expect*/
 
+/**
+ * Module dependencies.
+ */
+
 var http = require('http');
+var eioc = require('engine.io-client');
+var listen = require('./common').listen;
+var expect = require('expect.js');
+var request = require('superagent');
 var WebSocket = require('ws');
@@ -11,6 +18,6 @@
       body: {
-        appendChild: function () {}
-        , removeChild: function () {}
+        appendChild: function(){},
+        removeChild: function(){}
       }
-    }
+    };
 
@@ -35,12 +42,16 @@ document.createElement = function (name) {
         var form = {
-          style: {}
-            , action: ''
-            , parentNode: { removeChild: function () {} }
-            , removeChild: function () {}
-            , setAttribute: function () {}
-            , appendChild: function (elem) { area: elem; }
-            , submit: function () {
-              request.post(this.action).type('form').send({ d: self.areaValue }).end(function (res) {});
-            }
-        }
+          style: {},
+          action: '',
+          parentNode: { removeChild: function(){} },
+          removeChild: function(){},
+          setAttribute: function(){},
+          appendChild: function(){},
+          submit: function(){
+            request
+            .post(this.action)
+            .type('form')
+            .send({ d: self.areaValue })
+            .end(function(){});
+          }
+        };
         return form;
@@ -139,5 +150,5 @@ } else if ('textarea' == name) {
       var engine = listen( { allowUpgrades: false, transports: ['polling'] }, function (port) {
-          var socket = new eioc.Socket('ws://localhost:' + port
-            , { transports: ['polling'], forceJSONP: true, upgrade: false })
-            , total = 2;
+        var socket = new eioc.Socket('ws://localhost:' + port
+          , { transports: ['polling'], forceJSONP: true, upgrade: false })
+          , total = 2;
 
@@ -144,0 +155,0 @@ engine.on('connection', function (conn) {

test/server.js

@@ -1,2 +0,1 @@
-/*global eio,eioc,listen,request,expect*/
 
@@ -8,2 +7,7 @@ /**
 var http = require('http');
+var eio = require('..');
+var eioc = require('engine.io-client');
+var listen = require('./common').listen;
+var expect = require('expect.js');
+var request = require('superagent');
 var WebSocket = require('ws');
@@ -687,3 +691,3 @@
             setTimeout(function() {
-              expect(clientCloseReason).to.be("ping timeout");
+              expect(clientCloseReason).to.be('ping timeout');
               done();
@@ -690,0 +694,0 @@ }, 500);

No alert changes

Improved metrics

Total package byte prevSize

124751

increased by1.2%

Number of package files

31

increased by3.33%

Lines of code

3161

increased by1.44%

Worsened metrics

Number of medium supply chain risk alerts

9

increased by12.5%

No dependency changes