eslint-plugin-ban - npm Package Compare versions

Comparing version 1.3.0 to 1.4.0

.eslintrc.json

@@ -0,0 +0,0 @@ {

docs/rules/ban.md

@@ -0,0 +0,0 @@ # Ban methods (ban)

lib/index.js

@@ -0,0 +0,0 @@ /**

lib/rules/ban.js

@@ -160,7 +160,5 @@ /**
 
-                if (node.callee.type !== MEMBER_EXPRESSION_TOKEN) {
-                    return;
-                }
-
-                if (node.callee.object && node.callee.object.type === IDENTIFIER_TOKEN){
+                if (node.callee.object &&
+                    (node.callee.type === MEMBER_EXPRESSION_TOKEN || node.callee.object.type === IDENTIFIER_TOKEN)
+                ){
                     const foundRule = findRuleByMethod(node.callee.property.name, node.callee.object.name);
@@ -167,0 +165,0 @@

package.json

 {
   "name": "eslint-plugin-ban",
-  "version": "1.3.0",
+  "version": "1.4.0",
   "description": "Allows you to bannish some methods or functions.",
@@ -30,6 +30,6 @@ "repository": {
   "devDependencies": {
-    "eslint": "^5.14.1",
+    "eslint": "^6.8.0",
     "growl": "^1.10.5",
-    "husky": "^1.3.1",
-    "mocha": "^6.2.0"
+    "husky": "^3.1.0",
+    "mocha": "^6.2.2"
   },
@@ -36,0 +36,0 @@ "husky": {

README.md

@@ -0,0 +0,0 @@ # eslint-plugin-ban [![Build Status](https://travis-ci.org/remithomas/eslint-plugin-ban.svg?branch=master)](https://travis-ci.org/remithomas/eslint-plugin-ban) [![npm version](https://img.shields.io/npm/v/eslint-plugin-ban.svg?style=flat-square)](https://www.npmjs.com/package/eslint-plugin-ban)

tests/lib/rules/ban.js

@@ -113,2 +113,9 @@ /**
             options: [{'name': ['animals', 'push'], 'message': 'Prefer use es6 spread'}]
+        },
+        {
+            code: 'this.target.removeEventListener()',
+            errors: [{
+                message: 'Use xx instead'
+            }],
+            options: [{'name': ['*', 'removeEventListener'], 'message': 'Use xx instead'}]
         }
@@ -115,0 +122,0 @@ ]

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

16278

increased by5.49%

Lines of code

364

increased by1.68%

No dependency changes