eslint-plugin-jest - npm Package Compare versions

Comparing version 21.7.1 to 21.8.0

index.js

@@ -10,2 +10,3 @@ 'use strict';
 const preferToHaveLength = require('./rules/prefer-to-have-length');
+const validDescribe = require('./rules/valid-describe');
 const validExpect = require('./rules/valid-expect');
@@ -67,2 +68,3 @@ const preferExpectAssertions = require('./rules/prefer-expect-assertions');
     'prefer-to-have-length': preferToHaveLength,
+    'valid-describe': validDescribe,
     'valid-expect': validExpect,
@@ -69,0 +71,0 @@ 'prefer-expect-assertions': preferExpectAssertions,

package.json

 {
   "name": "eslint-plugin-jest",
-  "version": "21.7.1",
+  "version": "21.8.0",
   "description": "Eslint rules for Jest",
@@ -5,0 +5,0 @@ "repository": "jest-community/eslint-plugin-jest",

README.md

@@ -91,2 +91,3 @@ [![Build Status](https://travis-ci.org/jest-community/eslint-plugin-jest.svg?branch=master)](https://travis-ci.org/jest-community/eslint-plugin-jest)
 | [prefer-expect-assertions](docs/rules/prefer-expect-assertions.md) | Suggest using `expect.assertions()` OR `expect.hasAssertions()` |                                                                         |                                                             |
+| [valid-describe](docs/rules/valid-describe.md)                     | Enforce valid `describe()` callback                             |                                                                         |                                                             |
 | [valid-expect](docs/rules/valid-expect.md)                         | Enforce valid `expect()` usage                                  | ![recommended](https://img.shields.io/badge/-recommended-lightgrey.svg) |                                                             |
@@ -93,0 +94,0 @@ | [valid-expect-in-promise](docs/rules/valid-expect-in-promise.md)   | Enforce having return statement when testing with promises      |                                                                         |                                                             |

rules/no-identical-title.js

 'use strict';
 
-const describeAliases = Object.assign(Object.create(null), {
-  describe: true,
-  'describe.only': true,
-  'describe.skip': true,
-  fdescribe: true,
-  xdescribe: true,
-});
+const isDescribe = require('./util').isDescribe;
 
@@ -30,7 +24,2 @@ const testCaseNames = Object.assign(Object.create(null), {
 
-const isDescribe = node =>
-  node &&
-  node.type === 'CallExpression' &&
-  describeAliases[getNodeName(node.callee)];
-
 const isTestCase = node =>
@@ -37,0 +26,0 @@ node &&

rules/util.js

@@ -83,2 +83,23 @@ 'use strict';
 
+const describeAliases = Object.assign(Object.create(null), {
+  describe: true,
+  'describe.only': true,
+  'describe.skip': true,
+  fdescribe: true,
+  xdescribe: true,
+});
+
+const getNodeName = node => {
+  if (node.type === 'MemberExpression') {
+    return node.object.name + '.' + node.property.name;
+  }
+  return node.name;
+};
+
+const isDescribe = node =>
+  node.type === 'CallExpression' && describeAliases[getNodeName(node.callee)];
+
+const isFunction = node =>
+  node.type === 'FunctionExpression' || node.type === 'ArrowFunctionExpression';
+
 module.exports = {
@@ -99,2 +120,4 @@ method: method,
   expectNotToBeUndefinedCase: expectNotToBeUndefinedCase,
+  isDescribe: isDescribe,
+  isFunction: isFunction,
 };

rules/valid-expect-in-promise.js

 'use strict';
 
+const isFunction = require('./util').isFunction;
+
 const reportMsg =
@@ -13,6 +15,2 @@ 'Promise should be returned to test its fulfillment or rejection';
 
-const isFunction = type => {
-  return type == 'FunctionExpression' || type == 'ArrowFunctionExpression';
-};
-
 const isExpectCallPresentInFunction = body => {
@@ -83,3 +81,3 @@ if (body.type === 'BlockStatement') {
   while (parent) {
-    if (isFunction(parent.type) && isTestFunc(parent.parent)) {
+    if (isFunction(parent) && isTestFunc(parent.parent)) {
       return parent;
@@ -107,3 +105,3 @@ }
   promiseCallbacks.some(promiseCallback => {
-    if (promiseCallback && isFunction(promiseCallback.type)) {
+    if (promiseCallback && isFunction(promiseCallback)) {
       if (
@@ -110,0 +108,0 @@ isExpectCallPresentInFunction(promiseCallback.body) &&

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Major refactor

Supply chain risk

Package has recently undergone a major refactor. It may be unstable or indicate significant internal changes. Use caution when updating to versions that include significant changes.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

85247

increased by10.87%

Number of package files

40

increased by8.11%

Lines of code

2373

increased by12.25%

Number of lines in readme file

99

increased by1.02%

Number of medium supply chain risk alerts

0

decreased by-100%

No dependency changes