eslint-plugin-jsx-a11y - npm Package Compare versions

Comparing version 1.2.2 to 1.2.3

CHANGELOG.md

@@ -0,1 +1,6 @@
+1.2.3 / 2016-06-02
+==================
+- [fix] Handle dynamic tabIndex expression values, but still retain validation logic for literal tabIndex values.
+
+
 1.2.2 / 2016-05-20
@@ -2,0 +7,0 @@ ==================

docs/rules/onclick-has-focus.md

@@ -32,3 +32,3 @@ # onclick-has-focus
 <!-- Good: buttons are inherently focusable -->
-<button onClick="doSomething();">Click the button :)</a>
+<button onClick="doSomething();">Click the button :)</button>
 ```
@@ -35,0 +35,0 @@

lib/rules/onclick-has-focus.js

@@ -23,5 +23,5 @@ /**
 
-var _getAttributeValue = require('../util/getAttributeValue');
+var _getTabIndex = require('../util/getTabIndex');
 
-var _getAttributeValue2 = _interopRequireDefault(_getAttributeValue);
+var _getTabIndex2 = _interopRequireDefault(_getTabIndex);
 
@@ -51,3 +51,3 @@ function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { default: obj }; }
         return;
-      } else if (!isNaN(Number((0, _getAttributeValue2.default)((0, _getAttribute2.default)(attributes, 'tabIndex'))))) {
+      } else if ((0, _getTabIndex2.default)((0, _getAttribute2.default)(attributes, 'tabIndex')) !== undefined) {
         return;
@@ -54,0 +54,0 @@ }

lib/util/isInteractiveElement.js

@@ -15,2 +15,6 @@ 'use strict';
 
+var _getTabIndex = require('./getTabIndex');
+
+var _getTabIndex2 = _interopRequireDefault(_getTabIndex);
+
 var _DOM = require('./attributes/DOM');
@@ -26,4 +30,4 @@
     var href = (0, _getAttributeValue2.default)((0, _getAttribute2.default)(attributes, 'href'));
-    var tabIndex = (0, _getAttributeValue2.default)((0, _getAttribute2.default)(attributes, 'tabIndex'));
-    return Boolean(href) || !isNaN(Number(tabIndex));
+    var tabIndex = (0, _getTabIndex2.default)((0, _getAttribute2.default)(attributes, 'tabIndex'));
+    return href !== undefined || tabIndex !== undefined;
   },
@@ -30,0 +34,0 @@ // This is same as `a` interactivity function

package.json

 {
   "name": "eslint-plugin-jsx-a11y",
-  "version": "1.2.2",
+  "version": "1.2.3",
   "description": "A static analysis linter of jsx and their accessibility with screen readers.",
@@ -5,0 +5,0 @@ "keywords": [

src/rules/onclick-has-focus.js

@@ -11,3 +11,3 @@ /**
 import getNodeType from '../util/getNodeType';
-import getAttributeValue from '../util/getAttributeValue';
+import getTabIndex from '../util/getTabIndex';
 
@@ -35,3 +35,3 @@ // ----------------------------------------------------------------------------
       return;
-    } else if (!isNaN(Number(getAttributeValue(getAttribute(attributes, 'tabIndex'))))) {
+    } else if (getTabIndex(getAttribute(attributes, 'tabIndex')) !== undefined) {
       return;
@@ -38,0 +38,0 @@ }

src/util/isInteractiveElement.js

@@ -5,2 +5,3 @@ 'use strict';
 import getAttributeValue, { getLiteralAttributeValue } from './getAttributeValue';
+import getTabIndex from './getTabIndex';
 import DOMElements from './attributes/DOM';
@@ -14,4 +15,4 @@
     const href = getAttributeValue(getAttribute(attributes, 'href'));
-    const tabIndex = getAttributeValue(getAttribute(attributes, 'tabIndex'));
-    return Boolean(href) || !isNaN(Number(tabIndex));
+    const tabIndex = getTabIndex(getAttribute(attributes, 'tabIndex'));
+    return href !== undefined || tabIndex !== undefined;
   },
@@ -18,0 +19,0 @@ // This is same as `a` interactivity function

tests/src/rules/onclick-has-focus.js

@@ -57,2 +57,3 @@ /**
     { code: '<a tabIndex="0" onClick={() => void 0} />', parserOptions },
+    { code: '<a tabIndex={dynamicTabIndex} onClick={() => void 0} />', parserOptions },
     { code: '<a tabIndex={0} onClick={() => void 0} />', parserOptions },
@@ -59,0 +60,0 @@ { code: '<a role="button" href="#" onClick={() => void 0} />', parserOptions },

No alert changes

Improved metrics

Total package byte prevSize

373463

increased by0.47%

Number of package files

204

increased by0.99%

Lines of code

11547

increased by0.34%

No dependency changes