eslint-plugin-n - npm Package Compare versions

Comparing version 15.2.4 to 15.2.5

lib/rules/exports-style.js

@@ -247,2 +247,10 @@ /**
         ],
+        messages: {
+            unexpectedExports:
+                "Unexpected access to 'exports'. Use 'module.exports' instead.",
+            unexpectedModuleExports:
+                "Unexpected access to 'module.exports'. Use 'exports' instead.",
+            unexpectedAssignment:
+                "Unexpected assignment to 'exports'. Don't modify 'exports' itself.",
+        },
     },
@@ -303,4 +311,3 @@
                     loc: getLocation(node),
-                    message:
-                        "Unexpected access to 'exports'. Use 'module.exports' instead.",
+                    messageId: "unexpectedExports",
                 })
@@ -340,4 +347,3 @@ }
                     loc: getLocation(node),
-                    message:
-                        "Unexpected access to 'module.exports'. Use 'exports' instead.",
+                    messageId: "unexpectedModuleExports",
                     fix(fixer) {
@@ -365,4 +371,3 @@ return fixModuleExports(node, sourceCode, fixer)
                     loc: getLocation(node),
-                    message:
-                        "Unexpected assignment to 'exports'. Don't modify 'exports' itself.",
+                    messageId: "unexpectedAssignment",
                 })
@@ -369,0 +374,0 @@ }

lib/rules/no-callback-literal.js

@@ -19,2 +19,5 @@ /**
         schema: [],
+        messages: {
+            unexpectedLiteral: "Unexpected literal in error position of callback."
+        }
     },
@@ -41,4 +44,3 @@
                         node,
-                        message:
-                            "Unexpected literal in error position of callback.",
+                        messageId: "unexpectedLiteral",
                     })
@@ -45,0 +47,0 @@ }

lib/rules/no-deprecated-api.js

@@ -722,2 +722,5 @@ /**
         ],
+        messages: {
+            "deprecated": "{{name}} was deprecated since v{{version}}{{replace}}."
+        }
     },
@@ -740,4 +743,3 @@ create(context) {
                 loc: node.loc,
-                message:
-                    "{{name}} was deprecated since v{{version}}{{replace}}.",
+                messageId: "deprecated",
                 data: {
@@ -744,0 +746,0 @@ name,

lib/rules/no-extraneous-import.js

@@ -7,3 +7,3 @@ /**
 
-const checkExtraneous = require("../util/check-extraneous")
+const { checkExtraneous, messages } = require("../util/check-extraneous")
 const getAllowModules = require("../util/get-allow-modules")
@@ -36,2 +36,3 @@ const getConvertPath = require("../util/get-convert-path")
         ],
+        messages,
     },
@@ -38,0 +39,0 @@ create(context) {

lib/rules/no-extraneous-require.js

@@ -7,3 +7,3 @@ /**
 
-const checkExtraneous = require("../util/check-extraneous")
+const { checkExtraneous, messages } = require("../util/check-extraneous")
 const getAllowModules = require("../util/get-allow-modules")
@@ -38,2 +38,3 @@ const getConvertPath = require("../util/get-convert-path")
         ],
+        messages,
     },
@@ -40,0 +41,0 @@ create(context) {

lib/rules/no-hide-core-modules.js

@@ -83,2 +83,5 @@ /**
         ],
+        messages: {
+            "unexpectedImport": "Unexpected import of third-party module '{{name}}'.",
+        }
     },
@@ -153,4 +156,3 @@ create(context) {
                             loc: target.node.loc,
-                            message:
-                                "Unexpected import of third-party module '{{name}}'.",
+                            messageId: "unexpectedImport",
                             data: {
@@ -157,0 +159,0 @@ name: path

lib/rules/no-missing-import.js

@@ -7,3 +7,3 @@ /**
 
-const checkExistence = require("../util/check-existence")
+const { checkExistence, messages } = require("../util/check-existence")
 const getAllowModules = require("../util/get-allow-modules")
@@ -34,2 +34,3 @@ const getResolvePaths = require("../util/get-resolve-paths")
         ],
+        messages,
     },
@@ -36,0 +37,0 @@ create(context) {

lib/rules/no-missing-require.js

@@ -7,3 +7,3 @@ /**
 
-const checkExistence = require("../util/check-existence")
+const { checkExistence, messages } = require("../util/check-existence")
 const getAllowModules = require("../util/get-allow-modules")
@@ -36,2 +36,3 @@ const getResolvePaths = require("../util/get-resolve-paths")
         ],
+        messages,
     },
@@ -38,0 +39,0 @@ create(context) {

lib/rules/no-restricted-import.js

@@ -7,3 +7,3 @@ /**
 
-const check = require("../util/check-restricted")
+const { checkForRestriction, messages } = require("../util/check-restricted")
 const visit = require("../util/visit-import")
@@ -51,6 +51,3 @@
         ],
-        messages: {
-            restricted:
-                "'{{name}}' module is restricted from being used.{{customMessage}}",
-        },
+        messages,
     },
@@ -60,4 +57,6 @@
         const opts = { includeCore: true }
-        return visit(context, opts, targets => check(context, targets))
+        return visit(context, opts, targets =>
+            checkForRestriction(context, targets)
+        )
     },
 }

lib/rules/no-restricted-require.js

@@ -8,3 +8,3 @@ /**
 
-const check = require("../util/check-restricted")
+const { checkForRestriction, messages } = require("../util/check-restricted")
 const visit = require("../util/visit-require")
@@ -51,6 +51,3 @@
         ],
-        messages: {
-            restricted:
-                "'{{name}}' module is restricted from being used.{{customMessage}}",
-        },
+        messages,
     },
@@ -60,4 +57,6 @@
         const opts = { includeCore: true }
-        return visit(context, opts, targets => check(context, targets))
+        return visit(context, opts, targets =>
+            checkForRestriction(context, targets)
+        )
     },
 }

lib/rules/no-unpublished-bin.js

@@ -51,2 +51,5 @@ /**
         ],
+        messages: {
+            invalidIgnored: "npm ignores '{{name}}'. Check 'files' field of 'package.json' or '.npmignore'."
+        }
     },
@@ -90,4 +93,3 @@ create(context) {
                     node,
-                    message:
-                        "npm ignores '{{name}}'. Check 'files' field of 'package.json' or '.npmignore'.",
+                    messageId: "invalidIgnored",
                     data: { name: relativePath },
@@ -94,0 +96,0 @@ })

lib/rules/no-unpublished-import.js

@@ -7,3 +7,3 @@ /**
 
-const checkPublish = require("../util/check-publish")
+const { checkPublish, messages } = require("../util/check-publish")
 const getAllowModules = require("../util/get-allow-modules")
@@ -36,2 +36,3 @@ const getConvertPath = require("../util/get-convert-path")
         ],
+        messages,
     },
@@ -38,0 +39,0 @@ create(context) {

lib/rules/no-unpublished-require.js

@@ -7,3 +7,3 @@ /**
 
-const checkPublish = require("../util/check-publish")
+const { checkPublish, messages } = require("../util/check-publish")
 const getAllowModules = require("../util/get-allow-modules")
@@ -38,2 +38,3 @@ const getConvertPath = require("../util/get-convert-path")
         ],
+        messages,
     },
@@ -40,0 +41,0 @@ create(context) {

lib/rules/no-unsupported-features.js

@@ -1079,2 +1079,6 @@ /**
         ],
+        messages: {
+            unsupported:
+                "{{feature}} {{be}} not supported yet on Node {{version}}.",
+        },
     },
@@ -1165,4 +1169,3 @@ create(context) {
                     node,
-                    message:
-                        "{{feature}} {{be}} not supported yet on Node {{version}}.",
+                    messageId: "unsupported",
                     data: {
@@ -1177,4 +1180,3 @@ feature: feature.name,
                     node,
-                    message:
-                        "{{feature}} {{be}} not supported yet on Node {{version}}.",
+                    messageId: "unsupported",
                     data: {
@@ -1181,0 +1183,0 @@ feature: `${feature.name} in non-strict mode`,

lib/rules/no-unsupported-features/es-builtins.js

@@ -8,3 +8,6 @@ /**
 const { READ } = require("eslint-utils")
-const checkUnsupportedBuiltins = require("../../util/check-unsupported-builtins")
+const {
+    checkUnsupportedBuiltins,
+    messages,
+} = require("../../util/check-unsupported-builtins")
 const enumeratePropertyNames = require("../../util/enumerate-property-names")
@@ -169,6 +172,3 @@
         ],
-        messages: {
-            unsupported:
-                "The '{{name}}' is not supported until Node.js {{supported}}. The configured version range is '{{version}}'.",
-        },
+        messages,
     },
@@ -175,0 +175,0 @@ create(context) {

lib/rules/no-unsupported-features/node-builtins.js

@@ -8,3 +8,6 @@ /**
 const { READ } = require("eslint-utils")
-const checkUnsupportedBuiltins = require("../../util/check-unsupported-builtins")
+const {
+    checkUnsupportedBuiltins,
+    messages,
+} = require("../../util/check-unsupported-builtins")
 const enumeratePropertyNames = require("../../util/enumerate-property-names")
@@ -404,6 +407,3 @@
         ],
-        messages: {
-            unsupported:
-                "The '{{name}}' is not supported until Node.js {{supported}}. The configured version range is '{{version}}'.",
-        },
+        messages,
     },
@@ -410,0 +410,0 @@ create(context) {

lib/rules/process-exit-as-throw.js

@@ -0,1 +1,2 @@
+/* eslint-disable eslint-plugin/prefer-message-ids */
 /**
@@ -2,0 +3,0 @@ * @author Toru Nagashima

lib/rules/shebang.js

@@ -89,2 +89,8 @@ /**
         ],
+        messages: {
+            unexpectedBOM: "This file must not have Unicode BOM.",
+            expectedLF: "This file must have Unix linebreaks (LF).",
+            expectedHashbangNode: 'This file needs shebang "#!/usr/bin/env node".',
+            expectedHashbang: "This file needs no shebang."
+        }
     },
@@ -127,3 +133,3 @@ create(context) {
                             node,
-                            message: "This file must not have Unicode BOM.",
+                            messageId: "unexpectedBOM",
                             fix(fixer) {
@@ -137,4 +143,3 @@ return fixer.removeRange([-1, 0])
                             node,
-                            message:
-                                "This file must have Unix linebreaks (LF).",
+                            messageId: "expectedLF",
                             fix(fixer) {
@@ -150,4 +155,3 @@ const index = sourceCode.text.indexOf("\r")
                         node,
-                        message:
-                            'This file needs shebang "#!/usr/bin/env node".',
+                        messageId: "expectedHashbangNode",
                         fix(fixer) {
@@ -164,3 +168,3 @@ return fixer.replaceTextRange(
                         node,
-                        message: "This file needs no shebang.",
+                        messageId: "expectedHashbang",
                         fix(fixer) {
@@ -167,0 +171,0 @@ return fixer.removeRange([0, info.length])

lib/util/check-existence.js

@@ -23,3 +23,3 @@ /**
  */
-module.exports = function checkExistence(context, targets) {
+exports.checkExistence = function checkExistence(context, targets) {
     const allowed = new Set(getAllowModules(context))
@@ -51,3 +51,3 @@
                 loc: target.node.loc,
-                message: '"{{name}}" is not found.',
+                messageId: "notFound",
                 data: target,
@@ -58,1 +58,5 @@ })
 }
+
+exports.messages = {
+    notFound: '"{{name}}" is not found.',
+}

lib/util/check-extraneous.js

@@ -20,3 +20,3 @@ /**
  */
-module.exports = function checkForExtraneous(context, filePath, targets) {
+exports.checkExtraneous = function checkExtraneous(context, filePath, targets) {
     const packageInfo = getPackageJson(filePath)
@@ -48,3 +48,3 @@ if (!packageInfo) {
                 loc: target.node.loc,
-                message: '"{{moduleName}}" is extraneous.',
+                messageId: "extraneous",
                 data: target,
@@ -55,1 +55,5 @@ })
 }
+
+exports.messages = {
+    extraneous: '"{{moduleName}}" is extraneous.',
+}

lib/util/check-publish.js

@@ -23,3 +23,3 @@ /**
  */
-module.exports = function checkForPublish(context, filePath, targets) {
+exports.checkPublish = function checkPublish(context, filePath, targets) {
     const packageInfo = getPackageJson(filePath)
@@ -53,6 +53,13 @@ if (!packageInfo) {
         for (const target of targets) {
-            const isPrivateFile =
-                target.moduleName == null &&
-                npmignore.match(toRelative(target.filePath))
-            const isDevPackage =
+            const isPrivateFile = () => {
+                if (target.moduleName != null) {
+                    return false
+                }
+                const relativeTargetPath = toRelative(target.filePath)
+                return (
+                    relativeTargetPath !== "" &&
+                    npmignore.match(relativeTargetPath)
+                )
+            }
+            const isDevPackage = () =>
                 target.moduleName != null &&
@@ -62,4 +69,3 @@ devDependencies.has(target.moduleName) &&
                 !allowed.has(target.moduleName)
-
-            if (isPrivateFile || isDevPackage) {
+            if (isPrivateFile() || isDevPackage()) {
                 context.report({
@@ -75,1 +81,5 @@ node: target.node,
 }
+
+exports.messages = {
+    notPublished: '"{{name}}" is not published.',
+}

lib/util/check-restricted.js

@@ -93,3 +93,3 @@ /**
  */
-module.exports = function checkForRestriction(context, targets) {
+exports.checkForRestriction = function checkForRestriction(context, targets) {
     const restrictions = createRestrictions(context.options[0])
@@ -111,1 +111,6 @@
 }
+
+exports.messages = {
+    restricted:
+        "'{{name}}' module is restricted from being used.{{customMessage}}",
+}

lib/util/check-unsupported-builtins.js

@@ -83,3 +83,6 @@ /**
  */
-module.exports = function checkUnsupportedBuiltins(context, trackMap) {
+module.exports.checkUnsupportedBuiltins = function checkUnsupportedBuiltins(
+    context,
+    trackMap
+) {
     const options = parseOptions(context)
@@ -110,1 +113,6 @@ const tracker = new ReferenceTracker(context.getScope(), { mode: "legacy" })
 }
+
+exports.messages = {
+    unsupported:
+        "The '{{name}}' is not supported until Node.js {{supported}}. The configured version range is '{{version}}'.",
+}

package.json

 {
     "name": "eslint-plugin-n",
-    "version": "15.2.4",
+    "version": "15.2.5",
     "description": "Additional ESLint's rules for Node.js",
@@ -20,5 +20,5 @@ "engines": {
         "ignore": "^5.1.1",
-        "is-core-module": "^2.9.0",
+        "is-core-module": "^2.10.0",
         "minimatch": "^3.1.2",
-        "resolve": "^1.10.1",
+        "resolve": "^1.22.1",
         "semver": "^7.3.7"
@@ -29,8 +29,8 @@ },
         "esbuild": "^0.14.39",
-        "eslint": "^8.15.0",
+        "eslint": "^8.21.0",
         "eslint-config-prettier": "^8.5.0",
-        "eslint-plugin-eslint-plugin": "^4.0.1",
+        "eslint-plugin-eslint-plugin": "^5.0.2",
         "eslint-plugin-n": "file:.",
         "fast-glob": "^3.2.11",
-        "globals": "^13.14.0",
+        "globals": "^13.17.0",
         "husky": "^8.0.1",
@@ -42,5 +42,5 @@ "import-meta-resolve": "^1.1.1",
         "opener": "^1.5.1",
-        "prettier": "^2.6.2",
+        "prettier": "^2.7.1",
         "punycode": "^2.1.1",
-        "release-it": "^15.0.0",
+        "release-it": "^15.2.0",
         "rimraf": "^3.0.2"
@@ -47,0 +47,0 @@ },

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

313713

increased by0.38%

Lines of code

8830

increased by0.58%

Dependency changes

• Updatedis-core-module@^2.10.0

• Updatedresolve@^1.22.1