eslint-plugin-storybook - npm Package Compare versions

Comparing version 0.4.1 to 0.4.2

CHANGELOG.md

@@ -0,1 +1,14 @@
+# v0.4.2 (Fri Nov 19 2021)
+
+#### 🐛 Bug Fix
+
+- Fix await interactions use cases [#51](https://github.com/storybookjs/eslint-plugin-storybook/pull/51) ([@yannbf](https://github.com/yannbf) [@shilman](https://github.com/shilman))
+
+#### Authors: 2
+
+- Michael Shilman ([@shilman](https://github.com/shilman))
+- Yann Braga ([@yannbf](https://github.com/yannbf))
+
+---
+
 # v0.4.1 (Sat Nov 13 2021)
@@ -2,0 +15,0 @@

dist/rules/await-interactions.js

@@ -39,2 +39,3 @@ "use strict";
             'userEvent',
+            'play',
         ];
@@ -45,2 +46,6 @@ const getMethodThatShouldBeAwaited = (expr) => {
             };
+            // When an expression is a return value it doesn't need to be awaited
+            if ((0, ast_1.isArrowFunctionExpression)(expr.parent) || (0, ast_1.isReturnStatement)(expr.parent)) {
+                return null;
+            }
             if ((0, ast_1.isMemberExpression)(expr.callee) &&
@@ -51,2 +56,8 @@ (0, ast_1.isIdentifier)(expr.callee.object) &&
             }
+            if ((0, ast_1.isTSNonNullExpression)(expr.callee) &&
+                (0, ast_1.isMemberExpression)(expr.callee.expression) &&
+                (0, ast_1.isIdentifier)(expr.callee.expression.property) &&
+                shouldAwait(expr.callee.expression.property.name)) {
+                return expr.callee.expression.property;
+            }
             if ((0, ast_1.isMemberExpression)(expr.callee) &&
@@ -53,0 +64,0 @@ (0, ast_1.isIdentifier)(expr.callee.property) &&

dist/utils/ast.js

 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.isTSAsExpression = exports.isTSInterfaceDeclaration = exports.isTSTypeAliasDeclaration = exports.isProgram = exports.isFunctionExpression = exports.isReturnStatement = exports.isProperty = exports.isObjectPattern = exports.isObjectExpression = exports.isNewExpression = exports.isMemberExpression = exports.isLiteral = exports.isJSXAttribute = exports.isImportSpecifier = exports.isImportNamespaceSpecifier = exports.isImportDefaultSpecifier = exports.isImportDeclaration = exports.isSequenceExpression = exports.isAssignmentExpression = exports.isVariableDeclaration = exports.isExpressionStatement = exports.isCallExpression = exports.isBlockStatement = exports.isArrowFunctionExpression = exports.isArrayExpression = exports.isVariableDeclarator = exports.isIdentifier = exports.isAwaitExpression = exports.ASTUtils = void 0;
+exports.isTSNonNullExpression = exports.isTSAsExpression = exports.isTSInterfaceDeclaration = exports.isTSTypeAliasDeclaration = exports.isProgram = exports.isFunctionExpression = exports.isReturnStatement = exports.isProperty = exports.isObjectPattern = exports.isObjectExpression = exports.isNewExpression = exports.isMemberExpression = exports.isLiteral = exports.isJSXAttribute = exports.isImportSpecifier = exports.isImportNamespaceSpecifier = exports.isImportDefaultSpecifier = exports.isImportDeclaration = exports.isSequenceExpression = exports.isAssignmentExpression = exports.isVariableDeclaration = exports.isExpressionStatement = exports.isCallExpression = exports.isBlockStatement = exports.isArrowFunctionExpression = exports.isArrayExpression = exports.isVariableDeclarator = exports.isIdentifier = exports.isAwaitExpression = exports.ASTUtils = void 0;
 const experimental_utils_1 = require("@typescript-eslint/experimental-utils");
@@ -36,1 +36,2 @@ var experimental_utils_2 = require("@typescript-eslint/experimental-utils");
 exports.isTSAsExpression = isNodeOfType(experimental_utils_1.AST_NODE_TYPES.TSAsExpression);
+exports.isTSNonNullExpression = isNodeOfType(experimental_utils_1.AST_NODE_TYPES.TSNonNullExpression);

package.json

 {
   "name": "eslint-plugin-storybook",
-  "version": "0.4.1",
+  "version": "0.4.2",
   "description": "Best practice rules for Storybook",
@@ -5,0 +5,0 @@ "keywords": [

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

72219

increased by1.56%

Lines of code

1246

increased by0.97%

No dependency changes