eslint-plugin-testing-library - npm Package Compare versions

Comparing version 5.7.0 to 5.7.1

create-testing-library-rule/detect-testing-library-utils.js

@@ -16,3 +16,3 @@ "use strict";
     return (context, optionsWithDefault) => {
-        let importedTestingLibraryNode = null;
+        const importedTestingLibraryNodes = [];
         let importedCustomModuleNode = null;
@@ -79,4 +79,7 @@ let importedUserEventLibraryNode = null;
         const getTestingLibraryImportNode = () => {
-            return importedTestingLibraryNode;
+            return importedTestingLibraryNodes[0];
         };
+        const getAllTestingLibraryImportNodes = () => {
+            return importedTestingLibraryNodes;
+        };
         const getCustomModuleImportNode = () => {
@@ -86,3 +89,3 @@ return importedCustomModuleNode;
         const getTestingLibraryImportName = () => {
-            return (0, node_utils_1.getImportModuleName)(importedTestingLibraryNode);
+            return (0, node_utils_1.getImportModuleName)(importedTestingLibraryNodes[0]);
         };
@@ -93,3 +96,3 @@ const getCustomModuleImportName = () => {
         const isTestingLibraryImported = (isStrict = false) => {
-            const isSomeModuleImported = !!importedTestingLibraryNode || !!importedCustomModuleNode;
+            const isSomeModuleImported = importedTestingLibraryNodes.length !== 0 || !!importedCustomModuleNode;
             return ((!isStrict && isAggressiveModuleReportingEnabled()) ||
@@ -428,2 +431,3 @@ isSomeModuleImported);
             getTestingLibraryImportNode,
+            getAllTestingLibraryImportNodes,
             getCustomModuleImportNode,
@@ -463,5 +467,4 @@ getTestingLibraryImportName,
                 }
-                if (!importedTestingLibraryNode &&
-                    /testing-library/g.test(node.source.value)) {
-                    importedTestingLibraryNode = node;
+                if (/testing-library/g.test(node.source.value)) {
+                    importedTestingLibraryNodes.push(node);
                 }
@@ -486,7 +489,6 @@ const customModule = getCustomModule();
                 const { arguments: args } = callExpression;
-                if (!importedTestingLibraryNode &&
-                    args.some((arg) => (0, node_utils_1.isLiteral)(arg) &&
-                        typeof arg.value === 'string' &&
-                        /testing-library/g.test(arg.value))) {
-                    importedTestingLibraryNode = callExpression;
+                if (args.some((arg) => (0, node_utils_1.isLiteral)(arg) &&
+                    typeof arg.value === 'string' &&
+                    /testing-library/g.test(arg.value))) {
+                    importedTestingLibraryNodes.push(callExpression);
                 }
@@ -493,0 +495,0 @@ const customModule = getCustomModule();

package.json

 {
 	"name": "eslint-plugin-testing-library",
-	"version": "5.7.0",
+	"version": "5.7.1",
 	"description": "ESLint rules for Testing Library",
@@ -66,3 +66,3 @@ "keywords": [
 		"eslint-remote-tester": "^3.0.0",
-		"eslint-remote-tester-repositories": "^0.0.6",
+		"eslint-remote-tester-repositories": "^0.0.7",
 		"husky": "^8.0.1",
@@ -69,0 +69,0 @@ "is-ci": "^3.0.1",

README.md

@@ -414,2 +414,3 @@ <div align="center">
       <td align="center"><a href="https://github.com/sjarva"><img src="https://avatars.githubusercontent.com/u/1133238?v=4?s=100" width="100px;" alt=""/><br /><sub><b>Senja</b></sub></a><br /><a href="https://github.com/testing-library/eslint-plugin-testing-library/commits?author=sjarva" title="Code">💻</a> <a href="https://github.com/testing-library/eslint-plugin-testing-library/commits?author=sjarva" title="Tests">⚠️</a> <a href="https://github.com/testing-library/eslint-plugin-testing-library/commits?author=sjarva" title="Documentation">📖</a></td>
+      <td align="center"><a href="https://dbrno.vercel.app"><img src="https://avatars.githubusercontent.com/u/106157862?v=4?s=100" width="100px;" alt=""/><br /><sub><b>Breno Cota</b></sub></a><br /><a href="https://github.com/testing-library/eslint-plugin-testing-library/commits?author=brenocota-hotmart" title="Code">💻</a> <a href="https://github.com/testing-library/eslint-plugin-testing-library/commits?author=brenocota-hotmart" title="Tests">⚠️</a></td>
     </tr>
@@ -416,0 +417,0 @@ </tbody>

rules/no-dom-import.js

@@ -66,12 +66,12 @@ "use strict";
             'Program:exit'() {
-                const importName = helpers.getTestingLibraryImportName();
-                const importNode = helpers.getTestingLibraryImportNode();
-                if (!importNode) {
-                    return;
-                }
-                const domModuleName = DOM_TESTING_LIBRARY_MODULES.find((module) => module === importName);
-                if (!domModuleName) {
-                    return;
-                }
-                report(importNode, domModuleName);
+                let importName;
+                const allImportNodes = helpers.getAllTestingLibraryImportNodes();
+                allImportNodes.forEach((importNode) => {
+                    importName = (0, node_utils_1.getImportModuleName)(importNode);
+                    const domModuleName = DOM_TESTING_LIBRARY_MODULES.find((module) => module === importName);
+                    if (!domModuleName) {
+                        return;
+                    }
+                    report(importNode, domModuleName);
+                });
             },
@@ -78,0 +78,0 @@ };

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

234501

increased by0.26%

Lines of code

4145

increased by0.05%

Number of lines in readme file

450

increased by0.22%

Worsened metrics

Published versions last week

0

decreased by-100%

Published versions last year

14

decreased by-12.5%

No dependency changes