exceljs - npm Package Compare versions

Comparing version 3.6.0 to 3.6.1

dist/es5/doc/workbook.js

@@ -51,3 +51,3 @@ 'use strict';
       if (this._worksheets.find(function (ws) {
-        return ws && ws.name === name;
+        return ws && ws.name.toLowerCase() === name.toLowerCase();
       })) {
@@ -54,0 +54,0 @@ throw new Error("Worksheet name already exists: ".concat(name));

dist/es5/xlsx/xform/sheet/cf-ext/cf-rule-ext-xform.js

@@ -95,3 +95,3 @@ "use strict";
         priority: model.priority,
-        id: "{".concat(uuid.v4(), "}")
+        id: model.x14Id || "{".concat(uuid.v4(), "}")
       });
@@ -98,0 +98,0 @@ this.iconSetXform.render(xmlStream, model);

dist/es5/xlsx/xform/sheet/worksheet-xform.js

@@ -354,6 +354,6 @@ "use strict";
       var printOptionsModel = {
-        showRowColHeaders: model.showRowColHeaders,
-        showGridLines: model.showGridLines,
-        horizontalCentered: model.horizontalCentered,
-        verticalCentered: model.verticalCentered
+        showRowColHeaders: model.pageSetup && model.pageSetup.showRowColHeaders,
+        showGridLines: model.pageSetup && model.pageSetup.showGridLines,
+        horizontalCentered: model.pageSetup && model.pageSetup.horizontalCentered,
+        verticalCentered: model.pageSetup && model.pageSetup.verticalCentered
       };
@@ -375,4 +375,5 @@ var sheetProtectionModel = model.sheetProtection;
       this.map.conditionalFormatting.render(xmlStream, model.conditionalFormattings);
+      this.map.printOptions.render(xmlStream, printOptionsModel); // Note: must be before pageMargins
+
       this.map.pageMargins.render(xmlStream, pageMarginsModel);
-      this.map.printOptions.render(xmlStream, printOptionsModel);
       this.map.pageSetup.render(xmlStream, model.pageSetup);
@@ -379,0 +380,0 @@ this.map.headerFooter.render(xmlStream, model.headerFooter);

lib/doc/workbook.js

@@ -54,3 +54,3 @@ 'use strict';
     name = (name || `sheet${id}`).substring(0, 31);
-    if (this._worksheets.find(ws => ws && ws.name === name)) {
+    if (this._worksheets.find(ws => ws && ws.name.toLowerCase() === name.toLowerCase())) {
       throw new Error(`Worksheet name already exists: ${name}`);
@@ -57,0 +57,0 @@ }

lib/xlsx/xform/sheet/cf-ext/cf-rule-ext-xform.js

@@ -77,3 +77,3 @@ const uuid = require('uuid');
       priority: model.priority,
-      id: `{${uuid.v4()}}`,
+      id: model.x14Id || `{${uuid.v4()}}`,
     });
@@ -80,0 +80,0 @@

lib/xlsx/xform/sheet/worksheet-xform.js

@@ -282,6 +282,6 @@ const _ = require('../../../utils/under-dash');
     const printOptionsModel = {
-      showRowColHeaders: model.showRowColHeaders,
-      showGridLines: model.showGridLines,
-      horizontalCentered: model.horizontalCentered,
-      verticalCentered: model.verticalCentered,
+      showRowColHeaders: model.pageSetup && model.pageSetup.showRowColHeaders,
+      showGridLines: model.pageSetup && model.pageSetup.showGridLines,
+      horizontalCentered: model.pageSetup && model.pageSetup.horizontalCentered,
+      verticalCentered: model.pageSetup && model.pageSetup.verticalCentered,
     };
@@ -305,4 +305,4 @@ const sheetProtectionModel = model.sheetProtection;
     this.map.conditionalFormatting.render(xmlStream, model.conditionalFormattings);
+    this.map.printOptions.render(xmlStream, printOptionsModel); // Note: must be before pageMargins
     this.map.pageMargins.render(xmlStream, pageMarginsModel);
-    this.map.printOptions.render(xmlStream, printOptionsModel);
     this.map.pageSetup.render(xmlStream, model.pageSetup);
@@ -309,0 +309,0 @@ this.map.headerFooter.render(xmlStream, model.headerFooter);

package.json

 {
   "name": "exceljs",
-  "version": "3.6.0",
+  "version": "3.6.1",
   "description": "Excel Workbook Manager - Read and Write xlsx and csv Files.",
@@ -42,2 +42,3 @@ "private": false,
     "test:end-to-end:es5": "export EXCEL_BUILD=es5 && npm run test:end-to-end",
+    "test:dist": "mocha --require spec/config/setup spec/dist --recursive",
     "test:manual": "node spec/manual/app.js",
@@ -51,3 +52,3 @@ "clean-build": "npm run clean && npm run build",
     "build": "npm run patch:fast-csv && grunt build",
-    "preversion": "npm run clean && npm run build && npm run test:all",
+    "preversion": "npm run clean && npm run build && npm run test:all && npm run test:dist",
     "postversion": "git push --no-verify && git push --tags --no-verify"
@@ -54,0 +55,0 @@ },

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

9601262

increased by0.03%

Number of lines in readme file

2599

increased by0.27%

No dependency changes