exo_browser - npm Package Compare versions

Comparing version 0.4.3 to 0.4.4

lib/api.js

@@ -408,2 +408,3 @@ /*
   //
+  var set_context_menu_handler; /* set_context_menu_handler(hdlr) */
   var load_url;                 /* load_url(url, [cb_]); */
@@ -426,3 +427,3 @@ var go_back_or_forward;       /* go_back_or_forward(offset, [cb_]); */
   var zoom;                     /* zoom(zoom, [cb_]); */
-  var set_context_menu_handler; /* set_context_menu_handler(hdlr) */
+  var get_dev_tools;            /* get_dev_tools(cb_); */
 
@@ -468,2 +469,21 @@ var kill;                     /* kill(); */
 
+  // ### set_context_menu_handler
+  //
+  // The handler must have the following signature and semantic:
+  // ```
+  // function(params, cb_) {
+  // return cb_(null, {
+  //   'Foo': function() { ... },
+  //   '': null,
+  //   'Bar': function() { ... }
+  // });
+  // ```
+  // Empty string can be used as separators and do not require a trigger.
+  // ```
+  // @hdlr {function(err, menu)} the handler
+  // ```
+  set_context_menu_handler = function(hdlr) {
+    my.context_menu_handler = hdlr || null;
+  };
+
   // ### load_url
@@ -822,20 +842,19 @@ //
 
-  // ### set_context_menu_handler
+  // ### get_dev_tools
   //
-  // TODO(spolu): Specification
-  // The handler must have the following signature and semantic:
+  // Start and retrieves the DevTools URL 
   // ```
-  // function(params, cb_) {
-  // return cb_(null, {
-  //   'Foo': function() { ... },
-  //   '': null,
-  //   'Bar': function() { ... }
-  // });
+  // @cb_ {function(url)} the async callback
   // ```
-  // Empty string can be used as separators and do not require a trigger.
-  // ```
-  // @hdlr {function(err, menu)} the handler
-  // ```
-  set_context_menu_handler = function(hdlr) {
-    my.context_menu_handler = hdlr || null;
+  get_dev_tools = function(cb_) {
+    pre(function(err) {
+      if(err) {
+        if(cb_) return cb_(err);
+      }
+      else {
+        my.internal._getDevTools(function(url) {
+          if(cb_) return cb_(url);
+        });
+      }
+    });
   };
@@ -958,2 +977,5 @@
 
+  common.method(that, 'set_context_menu_handler', 
+                       set_context_menu_handler, _super);
+
   common.method(that, 'load_url', load_url, _super);
@@ -978,4 +1000,3 @@ common.method(that, 'go_back_or_forward', go_back_or_forward, _super);
   common.method(that, 'zoom', zoom, _super);
-  common.method(that, 'set_context_menu_handler', 
-                       set_context_menu_handler, _super);
+  common.method(that, 'get_dev_tools', get_dev_tools, _super);
 
@@ -982,0 +1003,0 @@ common.getter(that, 'url', my, 'url');

package.json

@@ -9,3 +9,3 @@ {
   },
-  "version": "0.4.3",
+  "version": "0.4.4",
   "dependencies": {
@@ -12,0 +12,0 @@ "async": "0.2.x",

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

42577

increased by1.12%

Lines of code

1470

increased by1.31%

No dependency changes