expo-updates - npm Package Compare versions

Comparing version 0.2.6 to 0.2.7

.expo/tsconfig.jest.json

 {
-  "extends": "/Users/tomasz/Work/expo/packages/expo-updates/tsconfig.json",
+  "extends": "/Users/eric/expo/expo/packages/expo-updates/tsconfig.json",
   "compilerOptions": {
@@ -10,5 +10,5 @@ "module": "esnext",
       "../../../node_modules/@types",
-      "/Users/tomasz/Work/expo/packages/expo-module-scripts/ts-declarations"
+      "/Users/eric/expo/expo/packages/expo-module-scripts/ts-declarations"
     ]
   }
 }

CHANGELOG.md

@@ -11,5 +11,10 @@ # Changelog
 
+- Added a better error message to the `create-manifest-ios.sh` script in case the Xcode shell cannot find the node binary.
+- Added an optional `bundleIn${targetName}` field to Gradle build script config. ([#8464](https://github.com/expo/expo/pull/8464) by [@rickysullivan](https://github.com/rickysullivan))
+- Fixed a bug on iOS with bundling assets from outside the project root.
+
 ## 0.2.6 — 2020-05-27
 
 *This version does not introduce any user-facing changes.*
+
 ## 0.2.5
@@ -16,0 +21,0 @@

package.json

 {
   "name": "expo-updates",
-  "version": "0.2.6",
+  "version": "0.2.7",
   "description": "Fetches and manages remotely-hosted assets and updates to your app's JS bundle.",
@@ -47,3 +47,3 @@ "main": "build/index.js",
   },
-  "gitHead": "dfc7fdb9aee4ef6fa10a9693e3d0935a2d500ae2"
+  "gitHead": "8ac2f9e7301f50c68740d84fa2ae8a019ef61091"
 }

scripts/createManifest.js

@@ -76,3 +76,3 @@ const fs = require('fs');
       if (platform === 'ios') {
-        assetInfoForManifest.nsBundleDir = getBasePath(asset);
+        assetInfoForManifest.nsBundleDir = getIosDestinationDir(asset);
         assetInfoForManifest.nsBundleFilename =
@@ -111,2 +111,8 @@ scale === 1 ? asset.name : asset.name + '@' + scale + 'x';
 
+function getIosDestinationDir(asset) {
+  // react-native-cli replaces `..` with `_` when embedding assets in the iOS app bundle
+  // https://github.com/react-native-community/cli/blob/0a93be1a42ed1fb05bb0ebf3b82d58b2dd920614/packages/cli/src/commands/bundle/getAssetDestPathIOS.ts
+  return getBasePath(asset).replace(/\.\.\//g, '_');
+}
+
 // copied from react-native/Libraries/Image/assetPathUtils.js
@@ -113,0 +119,0 @@ function getBasePath(asset) {

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

331938

increased by0.34%

Lines of code

718

increased by0.7%

No dependency changes