express-redis-cache - npm Package Compare versions

Comparing version 0.5.0 to 0.5.1

lib/ExpressRedisCache.js

@@ -97,3 +97,3 @@ module.exports = (function () {
         this.emit('disconnected', { host: this.host, port: this.port });
-        this.emit('message', 'OK connected to redis://' + this.client.address);
+        this.emit('message', 'Disconnected from redis://' + this.client.host + ':' + this.client.port);
       }.bind(this));
@@ -100,0 +100,0 @@ }

lib/ExpressRedisCache/get.js

@@ -23,2 +23,3 @@ module.exports = (function () {
       callback(error);
+      domain.exit();
     });
@@ -39,3 +40,4 @@
         if ( ! keys.length ) {
-          return callback(null, []);
+          callback(null, []);
+          return domain.exit();
         }
@@ -56,2 +58,3 @@
           callback(null, results);
+          domain.exit();
         }));
@@ -58,0 +61,0 @@ }));

lib/ExpressRedisCache/route.js

@@ -85,2 +85,15 @@ module.exports = (function () {
 
+        // If the cache gets disconnected, call next()
+        /* NOTE: The disconnected event is emitted after any redis client completes it's configured max_attempts and delay throttling.
+
+        This will throw a nasty error regarding headers when this occurs along the lines of:
+            Error: Can't set headers after they are sent. 
+              at ServerResponse.OutgoingMessage.setHeader...
+
+           ...but it will allow the request to be completed without blocking.  Subsequent requests pass through as self.connected is false.
+        */
+        self.on('disconnected', function () {
+          return next();
+        });
+
         /** Cache entry name
@@ -87,0 +100,0 @@ *

lib/ExpressRedisCache/size.js

@@ -11,3 +11,2 @@ /**
 module.exports = function (
-/* RedisClient */ client,     // A Redis client
 /* Function */    callback    // Callback
@@ -28,3 +27,3 @@ ) {
     /** Tell Redis to fetch the keys name beginning by prefix **/
-    client.keys(self.prefix + '*', domain.intercept(function (keys) {
+    self.client.keys(self.prefix + '*', domain.intercept(function (keys) {
 
@@ -48,3 +47,3 @@ var size = 0;
           results.forEach(function (result) {
-            size += require('./sizeof')(result);
+            size += require('../sizeof')(result);
           });
@@ -57,5 +56,3 @@
 
-
-
   });
 };

package.json

 {
   "name": "express-redis-cache",
-  "version": "0.5.0",
+  "version": "0.5.1",
   "description": "A module to make Express interact with Redis (create, get, delete). You can automatically cache all your most popular routes in Redis.",
@@ -5,0 +5,0 @@ "main": "index.js",

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

103736

increased by36.64%

Number of package files

28

increased by7.69%

Lines of code

1722

increased by0.7%

No dependency changes