eyes.selenium - npm Package Compare versions

Comparing version 3.6.5 to 3.6.6

package.json

 {
   "name": "eyes.selenium",
-  "version": "3.6.5",
+  "version": "3.6.6",
   "description": "Applitools Eyes SDK For Selenium JavaScript WebDriver",
@@ -48,8 +48,8 @@ "keywords": [
   "dependencies": {
-    "eyes.sdk": "^3.6.4",
-    "eyes.utils": "^3.6.3"
+    "eyes.sdk": "^3.6.5",
+    "eyes.utils": "^3.6.4"
   },
   "devDependencies": {
     "@types/node": "*",
-    "chromedriver": "^74.0.0",
+    "chromedriver": "^75.0.0",
     "mocha": "^6.1.4",
@@ -76,3 +76,3 @@ "protractor": "^5.4.2",
   },
-  "gitHead": "f7a04134ae39b7546b33dea65d70aacf1a293097"
+  "gitHead": "3747372bae7f30dc76fd79b8dc4e07c184d34f32"
 }

src/capture/SafariScreenshotImageProvider.js

@@ -42,2 +42,3 @@ 'use strict';
       .then(() => {
+        that._logger.verbose(`Done creating MutableImage.`);
         if (that._eyes.getIsCutProviderExplicitlySet()) {
@@ -44,0 +45,0 @@ return image;

src/capture/TakesScreenshotImageProvider.js

@@ -30,3 +30,5 @@ 'use strict';
       that._logger.verbose('Done getting base64! Creating MutableImage...');
-      return MutableImage.fromBase64(screenshot64, that._tsInstance.getPromiseFactory());
+      const image = MutableImage.fromBase64(screenshot64, that._tsInstance.getPromiseFactory());
+      that._logger.verbose(`Done creating MutableImage.`);
+      return image;
     });
@@ -33,0 +35,0 @@ }

src/EyesTargetLocator.js

@@ -81,4 +81,4 @@ (function () {
             this._logger.verbose("Getting frames by name...");
-            return this._driver.findElementsByName(obj).then(function(elements) {
-                if (elements.length === 0) {
+            return this._driver.findElementsByName(obj).then(function(frames) {
+                if (frames.length === 0) {
                     that._logger.verbose("No frames Found! Trying by id...");
@@ -89,5 +89,5 @@ // If there are no frames by that name, we'll try the id
 
-                return elements;
-            }).then(function(elements) {
-                if (elements.length === 0) {
+                return frames;
+            }).then(function(frames) {
+                if (frames.length === 0) {
                     // No such frame, bummer
@@ -97,18 +97,8 @@ throw new Error("No frame with name or id '" + obj + "' exists!");
 
-                return elements;
-            }).then(function (frames) {
-                if (frames.length === 0) {
-                    that._logger.verbose("No frames Found! Trying by id...");
-                    // If there are no frames by that name, we'll try the id
-                    frames = that._driver.findElementsById(obj);
-                    if (frames.length === 0) {
-                        // No such frame, bummer
-                        throw new Error("No frame with name or id '" + obj + "' exists!");
-                    }
-                }
                 that._logger.verbose("Done! Making preparations..");
-                return that._onWillSwitch.willSwitchToFrame(EyesTargetLocator.TargetType.FRAME, frames[0]);
-            }).then(function () {
+                return that._onWillSwitch.willSwitchToFrame(EyesTargetLocator.TargetType.FRAME, frames[0])
+                  .then(function () {return frames[0];});
+            }).then(function (frame) {
                 that._logger.verbose("Done! Switching to frame...");
-                return that._targetLocator.frame(obj)
+                return that._targetLocator.frame(frame.getRemoteWebElement())
             }).then(function () {
@@ -115,0 +105,0 @@ that._logger.verbose("Done!");

src/EyesWebDriver.js

@@ -251,5 +251,4 @@ (function () {
 
-            // Optimization
             if (currentFrames.size() > 0) {
-                promise.then(function () {
+                promise = promise.then(function () {
                     return that.switchTo().defaultContent();
@@ -259,3 +258,3 @@ });
 
-            promise.then(function () {
+            promise = promise.then(function () {
                 that._logger.verbose("Extracting viewport size...");
@@ -269,3 +268,3 @@ return EyesSeleniumUtils.getViewportSizeOrDisplaySize(that._logger, that._driver, that.getPromiseFactory());
             if (currentFrames.size() > 0) {
-                promise.then(function () {
+                promise = promise.then(function () {
                     return that.switchTo().frames(currentFrames);
@@ -272,0 +271,0 @@ });

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

271214

increased by0.33%

Number of package files

38

increased by2.7%

Lines of code

5568

increased by0.45%

Worsened metrics

Number of low supply chain risk alerts

20

increased by5.26%

Dependency changes

• Updatedeyes.sdk@^3.6.5

• Updatedeyes.utils@^3.6.4