eyes.selenium - npm Package Compare versions

Comparing version 3.8.1 to 3.8.2

package.json

 {
   "name": "eyes.selenium",
-  "version": "3.8.1",
+  "version": "3.8.2",
   "description": "Applitools Eyes SDK For Selenium JavaScript WebDriver",
@@ -75,3 +75,3 @@ "keywords": [
   },
-  "gitHead": "e42e09aff5f2a7dfd167f5c40490729a42b2dcf1"
+  "gitHead": "5b641287f140c228e701bff257b5a10f0d6ba6e9"
 }

src/capture/EyesWebDriverScreenshot.js

@@ -241,7 +241,4 @@ (function () {
 
-        var sizeFromRegion = GeometryUtils.createSizeFromRegion(region);
-        var sizeFromSubRegion = GeometryUtils.createSizeFromRegion(asIsSubScreenshotRegion);
-        if (GeometryUtils.isRegionEmpty(asIsSubScreenshotRegion) || (throwIfClipped &&
-            !(sizeFromRegion.height == sizeFromSubRegion.height && sizeFromRegion.width == sizeFromSubRegion.width))) {
-            throw new Error("Region ", region, ", (", coordinatesType, ") is out of screenshot bounds ", this._frameWindow);
+        if (GeometryUtils.isRegionEmpty(asIsSubScreenshotRegion) || (throwIfClipped && !(region.height === asIsSubScreenshotRegion.height && region.width === asIsSubScreenshotRegion.width))) {
+            throw new Error("Region " + JSON.stringify(region) + ", (" + coordinatesType + ") is out of screenshot bounds " + JSON.stringify(this._frameWindow));
         }
@@ -289,6 +286,6 @@
         // if it is actually a sub-screenshot of a region).
-        if (this._frameChain.size() == 0 && this._screenshotType == ScreenshotType.ENTIRE_FRAME) {
-            if ((from == CoordinatesType.CONTEXT_RELATIVE
-                || from == CoordinatesType.CONTEXT_AS_IS)
-                && to == CoordinatesType.SCREENSHOT_AS_IS) {
+        if (this._frameChain.size() == 0 && this._screenshotType === ScreenshotType.ENTIRE_FRAME) {
+            if ((from === CoordinatesType.CONTEXT_RELATIVE
+                || from === CoordinatesType.CONTEXT_AS_IS)
+                && to === CoordinatesType.SCREENSHOT_AS_IS) {
 
@@ -298,4 +295,4 @@ // If this is not a sub-screenshot, this will have no effect.
 
-            } else if (from == CoordinatesType.SCREENSHOT_AS_IS &&
-                (to == CoordinatesType.CONTEXT_RELATIVE || to == CoordinatesType.CONTEXT_AS_IS)) {
+            } else if (from === CoordinatesType.SCREENSHOT_AS_IS &&
+                (to === CoordinatesType.CONTEXT_RELATIVE || to === CoordinatesType.CONTEXT_AS_IS)) {
 
@@ -302,0 +299,0 @@ result = GeometryUtils.locationOffset(result, {

src/EyesRemoteWebElement.js

@@ -20,3 +20,6 @@ (function () {
 
-    var JS_GET_LOCATION = "var rect = arguments[0].getBoundingClientRect(); return [rect.left, rect.top]";
+    var JS_GET_LOCATION = "var rect = arguments[0].getBoundingClientRect(); " +
+      "var offsetLeft = window.pageXOffset || document.documentElement.scrollLeft; " +
+      "var offsetTop = window.pageYOffset || document.documentElement.scrollTop; " +
+      "return [rect.left + offsetLeft, rect.top + offsetTop]";
 
@@ -23,0 +26,0 @@ /**

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

277885

increased by0.03%

No dependency changes